Another nit

Another nit

[Perry Smith]

[-- Attachment #1: Type: text/plain, Size: 378 bytes --]

Isn’t this example wrong?  From admin/notes/tree-sitter/starter-guide

>     (match NODE-TYPE PARENT-TYPE NODE-FIELD
>            NODE-INDEX-MIN NODE-INDEX-MAX)
> 
>     => checks everything. If an argument is nil, don’t match that. Eg,
>     (match nil nil TYPE) is the same as (parent-is TYPE)

Seems like (match nil TYPE) would be the same as (parent-is TYPE)


[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: Another nit

[Yuan Fu]

> On Dec 9, 2022, at 8:11 PM, Perry Smith <pedz@easesoftware.com> wrote:
> 
> Isn’t this example wrong?  From admin/notes/tree-sitter/starter-guide
> 
>>    (match NODE-TYPE PARENT-TYPE NODE-FIELD
>>           NODE-INDEX-MIN NODE-INDEX-MAX)
>> 
>>    => checks everything. If an argument is nil, don’t match that. Eg,
>>    (match nil nil TYPE) is the same as (parent-is TYPE)
> 
> Seems like (match nil TYPE) would be the same as (parent-is TYPE)
> 

You are right, thanks! I fixed that.

Yuan

Can the tree-sitter/build-module/build.sh support Mingw64 on Windows OS

[Eason Huang]

Hi emacs-devel team,

Recently the script from admin/notes/tree-sitter/build-module/build.sh
only support macOS and Linux. It would be nice to support Windows system
as well.

I can confirm that we only need to use soext="dll" and it will work well
on mingw64 of msys2.

The $(uname) will return "MINGW64_NT-10.0-22000" on the mingw64.

But I am not sure how to adapt the below code to support mingw64.

from line 6 of build.sh:
```
if [ $(uname) == "Darwin" ]
then
    soext="dylib"
else
    soext="so"
fi
```

-- 
Eason Huang

Re: Can the tree-sitter/build-module/build.sh support Mingw64 on Windows OS

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > Recently the script from admin/notes/tree-sitter/build-module/build.sh
  > only support macOS and Linux.

Macos is an operating system, but Linux is just a kernel.
The operating system we give preference to is not Linux;
it is GNU+Linux, which is the GNU operating system combined
with Linux as the kernel.

See https://gnu.org/gnu/linux-and-gnu.html and
https://gnu.org/gnu/gnu-linux-faq.html, plus the history in
https://gnu.org/gnu/the-gnu-project.html.

Thanks for suggesting improvements in Emacs.
-- 
Dr Richard Stallman (https://stallman.org)
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)

Re: Can the tree-sitter/build-module/build.sh support Mingw64 on Windows OS

[Eason Huang]

Richard Stallman <rms@gnu.org> writes:

> [[[ To any NSA and FBI agents reading my email: please consider    ]]]
> [[[ whether defending the US Constitution against all enemies,     ]]]
> [[[ foreign or domestic, requires you to follow Snowden's example. ]]]
>
>   > Recently the script from admin/notes/tree-sitter/build-module/build.sh
>   > only support macOS and Linux.
>
> Macos is an operating system, but Linux is just a kernel.
> The operating system we give preference to is not Linux;
> it is GNU+Linux, which is the GNU operating system combined
> with Linux as the kernel.
>
> See https://gnu.org/gnu/linux-and-gnu.html and
> https://gnu.org/gnu/gnu-linux-faq.html, plus the history in
> https://gnu.org/gnu/the-gnu-project.html.
>
> Thanks for suggesting improvements in Emacs.

Hello Richard,

Thanks for correct me and sharing the infomation about the GNU history.
Now it clear for me, what I mean is GNU/Linux.


-- 
Eason Huang