From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: "Eli Zaretskii" Newsgroups: gmane.emacs.devel Subject: Re: Current CVS version install breaks on Mac OSX Date: Sun, 14 Mar 2004 19:08:30 +0200 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <3028-Sun14Mar2004190829+0200-eliz@elta.co.il> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: deer.gmane.org X-Trace: sea.gmane.org 1079285096 32313 80.91.224.253 (14 Mar 2004 17:24:56 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 14 Mar 2004 17:24:56 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Sun Mar 14 18:24:52 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1B2ZM3-0001Hq-00 for ; Sun, 14 Mar 2004 18:24:51 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1B2ZM3-0002gR-00 for ; Sun, 14 Mar 2004 18:24:51 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.30) id 1B2ZDf-0002SF-VZ for emacs-devel@quimby.gnus.org; Sun, 14 Mar 2004 12:16:11 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30) id 1B2Z9q-0001H5-Gq for emacs-devel@gnu.org; Sun, 14 Mar 2004 12:12:14 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30) id 1B2Z9J-00019Z-Fr for emacs-devel@gnu.org; Sun, 14 Mar 2004 12:12:12 -0500 Original-Received: from [192.114.186.23] (helo=aragorn.inter.net.il) by monty-python.gnu.org with esmtp (Exim 4.30) id 1B2Z7v-0000wv-8Q for emacs-devel@gnu.org; Sun, 14 Mar 2004 12:10:15 -0500 Original-Received: from zaretski (pns03-199-205.inter.net.il [80.230.199.205]) by aragorn.inter.net.il (MOS 3.4.4-GR) with ESMTP id CPH70961; Sun, 14 Mar 2004 19:10:08 +0200 (IST) Original-To: Piet van Oostrum X-Mailer: emacs 21.3.50 (via feedmail 8 I) and Blat ver 1.8.9 In-reply-to: (message from Piet van Oostrum on 14 Mar 2004 16:13:17 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:20462 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:20462 > From: Piet van Oostrum > Date: 14 Mar 2004 16:13:17 +0100 > > Current CVS version install breaks on Mac OSX for the Carbon version > ( ./configure --enable-carbon-app --without-x) > > This is caused by this change: > > 2004-03-13 Eli Zaretskii > > * Makefile.in (XMENU_OBJ): Include xmenu.o if HAVE_MENUS is > defined. Does it build with the same configure options if you take out my change? > I don't understand why that include is there because it is in the > 'not HAVE_X_WINDOWS' branch. In the 'HAVE_X_WINDOWS' branch it is > already there conditionalized on 'not HAVE_CARBON' I installed that (and a related change to emacs.c) to solve 2 problems: - the MS-DOS port would not build because xmenu.o was not linked into temacs; and - the Unix and GNU versions would not build when configured --without-x (see a bug report posted to emacs-pretest-bug a couple of days ago). I don't have access to Mac OS X, so I cannot tell what change is required. Can you suggest a change that would only fix the Carbon build? > I think xmenu.o only works with HAVE_X_WINDOWS. Not true, it is used by any system that defines HAVE_MENUS (the MS-DOS port is one of them; I'm not sure if it is the only one, though). > Anyway in Carbon Emacs it > won't compile because the X11 headers are not included. Moreover it shouldn't > be included as macmenu.o takes over the required functionality. Will this be fixed if the XMENU_OBJ definition I added, in the non-X branch, is conditioned with "#ifndef HAVE_CARBON"? If so, please feel free to commit such a change.