From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.devel Subject: Re: MS-Windows build using Posix configury Date: Tue, 16 Apr 2013 20:42:54 -0400 Message-ID: <2zip3mhtrl.fsf@fencepost.gnu.org> References: <83d2tu49lu.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1366159378 6424 80.91.229.3 (17 Apr 2013 00:42:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 17 Apr 2013 00:42:58 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 17 02:43:02 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1USGSj-0000QV-PY for ged-emacs-devel@m.gmane.org; Wed, 17 Apr 2013 02:43:01 +0200 Original-Received: from localhost ([::1]:57081 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USGSi-0005hs-Lt for ged-emacs-devel@m.gmane.org; Tue, 16 Apr 2013 20:43:00 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:49865) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USGSf-0005hn-Bs for emacs-devel@gnu.org; Tue, 16 Apr 2013 20:42:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1USGSe-00055n-Jm for emacs-devel@gnu.org; Tue, 16 Apr 2013 20:42:57 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50563) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USGSe-00055i-GE for emacs-devel@gnu.org; Tue, 16 Apr 2013 20:42:56 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1USGSc-0003M5-Vq; Tue, 16 Apr 2013 20:42:55 -0400 X-Spook: e-cash Ft. Knox Maple Putin event security genetic Osama X-Ran: 8:RW5BS[=%j^OwW9SYw^ykP($G$)kS&3>_|D?GW\\K+3T:R38'2/[@&o"Bn$;{i]#90e}~ X-Hue: red X-Attribution: GM In-Reply-To: <83d2tu49lu.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 16 Apr 2013 21:24:29 +0300") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:158963 Archived-At: Eli Zaretskii wrote: > gnu-linux|freebsd|netbsd) > AC_DEFINE(HAVE_SOUND, 1, [Define to 1 if you have sound support.]) > ;; > + mingw32) > + AC_DEFINE(HAVE_SOUND, 1, [Define to 1 if you have sound support.]) > + ;; [...] > +if test "${opsys}" = "mingw32"; then > + AC_DEFINE(NULL_DEVICE, ["NUL:"], [Name of the file to open to get > + a null file, or a data sink.]) > +else > + AC_DEFINE(NULL_DEVICE, ["/dev/null"], [Name of the file to open to get > + a null file, or a data sink.]) > +fi > > -AC_DEFINE(SEPCHAR, [':'], [Character that separates PATH elements.]) > +if test "${opsys}" = "mingw32"; then > + AC_DEFINE(SEPCHAR, [';'], [Character that separates PATH elements.]) > +else > + AC_DEFINE(SEPCHAR, [':'], [Character that separates PATH elements.]) > +fi With things like this, I think it is better to have a single unconditional AH_TEMPLATE that gives the doc string, then as many AC_DEFINEs as needed that just set the value and don't duplicate the doc. (There are probably other instances of this.)