It seems there was some code merge problem for this patch commit. I was compiling this on my MBP 10.6.3 and I got this:

./configure --with-ns

...

make install

...

gcc -c -Demacs -DHAVE_CONFIG_H -I. -I/Users/wyuenho/packages/emacs/emacs-23/src -Dtemacs -g -O2 -Wdeclaration-after-statement -Wno-pointer-sign -MMD -MF deps/nsterm.d nsterm.m

nsterm.m: In function 'x_set_window_size':

nsterm.m:1189: warning: ISO C90 forbids mixed declarations and code

nsterm.m: In function 'ns_draw_fringe_bitmap':

nsterm.m:2203: warning: ISO C90 forbids mixed declarations and code

nsterm.m: In function '-[EmacsView keyDown:]':

nsterm.m:4481: warning: 'wantsToDelayTextChangeNotifications' is deprecated (declared at /System/Library/Frameworks/AppKit.framework/Headers/NSInputManager.h:112)

nsterm.m: In function '-[EmacsView initFrameFromEmacs:]':

nsterm.m:5089: warning: class 'EmacsView' does not implement the 'NSWindowDelegate' protocol

nsterm.m: In function '-[EmacsScroller judge]':

nsterm.m:5761: warning: ISO C90 forbids mixed declarations and code

nsterm.m: In function '-[EmacsScroller setPosition:portion:whole:]':

nsterm.m:5800: warning: 'setFloatValue:knobProportion:' is deprecated (declared at /System/Library/Frameworks/AppKit.framework/Headers/NSScroller.h:107)

nsterm.m:5807: warning: 'setFloatValue:knobProportion:' is deprecated (declared at /System/Library/Frameworks/AppKit.framework/Headers/NSScroller.h:107)

gcc -c -Demacs -DHAVE_CONFIG_H -I. -I/Users/wyuenho/packages/emacs/emacs-23/src -Dtemacs -g -O2 -Wdeclaration-after-statement -Wno-pointer-sign -MMD -MF deps/nsfns.d nsfns.m

nsfns.m: In function 'ns_get_screen':

nsfns.m:227: warning: assignment makes pointer from integer without a cast

nsfns.m: At top level:

nsfns.m:690: error: conflicting types for 'ns_set_doc_edited'

nsterm.h:712: error: previous declaration of 'ns_set_doc_edited' was here

nsfns.m: In function 'Fx_display_color_cells':

nsfns.m:2377: warning: ISO C90 forbids mixed declarations and code

make[1]: *** [nsfns.o] Error 1

make: *** [src] Error 2

On Tue, Mar 30, 2010 at 9:05 PM, David Reitter <david.reitter@gmail.com> wrote:

On Mar 30, 2010, at 3:43 AM, Adrian Robert wrote:

>> One other thing I noticed which looking through the code is that the
>> Nextstep port assigns a special value, `t', to frame-title-format, and
>> processes it specially. Is there any reason to do this? If not, I
>> think this should be removed; this looks like a misfeature to me, since
>> it is not compatible with the variable as documented and can confuse
>> other people's Lisp code.
>
> Ah, OK -- this variable and value was checked for in the code I moved in my patch, but I had no idea it was set specially by NS lisp code. I'll look into it.

IIRC, NS displays the file's name as the title and requires you to set it that way if drag&drop of the file proxy icons (displayed next to the name of the frame) is supposed to work. That's all standard functionality on NS or at least on the Mac. If the frame name is different, I think drag&drop doesn't work right. See xdisp.c:9503ff and also ns_set_name_as_filename() in nsfns.m.

Introducing a ns-* variable to override would confuse users (frame-title-format won't work as expected), but if we set the file name with this NS function iff ns-frame-title-format is "%f", then that would be consistent with the other platforms.