From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.devel Subject: Re: server.el test failures Date: Thu, 2 Mar 2023 23:15:34 -0800 Message-ID: <2f012e8c-ce15-fd24-d4d5-d744a338a682@gmail.com> References: <877h40vb8h.fsf@mail.jurta.org> <861qmvcglp.fsf@aarsen.me> <98e880a0-d076-cfd9-b39d-50c84fa8975a@gmail.com> <811d85e0-4032-68df-bc0c-1073ff5d1b96@cs.ucla.edu> <5a38c18d-263c-223b-7335-8395a10eb494@gmail.com> <00864fe6-b63a-685f-2d20-4e1fd5a5573e@cs.ucla.edu> <3e7c26d6-215a-6c29-5304-0e32f42b2174@gmail.com> <87zg8z5afj.fsf@gmail.com> <83ttz7giib.fsf@gnu.org> <87r0ub561t.fsf@gmail.com> <83sfergdgf.fsf@gnu.org> <87h6v6qlq7.fsf@gmail.com> <83ilfmgf88.fsf@gnu.org> <87cz5uq6s1.fsf@gmail.com> <84c54b68-e787-2bc5-0908-52d953b557d2@gmail.com> <83wn41fvc9.fsf@gnu.org> <878rggrict.fsf@gmail.com> <83pm9qco9v.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14642"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rpluim@gmail.com, eggert@cs.ucla.edu, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 03 08:16:43 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXzel-0003eJ-35 for ged-emacs-devel@m.gmane-mx.org; Fri, 03 Mar 2023 08:16:43 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pXzdv-0005fe-BL; Fri, 03 Mar 2023 02:15:51 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXzdk-0005aX-BA for emacs-devel@gnu.org; Fri, 03 Mar 2023 02:15:47 -0500 Original-Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pXzdh-0001Vs-7V; Fri, 03 Mar 2023 02:15:40 -0500 Original-Received: by mail-pl1-x62d.google.com with SMTP id a9so1769395plh.11; Thu, 02 Mar 2023 23:15:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677827735; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=va4oVik2spJTAGL3WKnNefqrGMXdGKGoPkfAo2TocO0=; b=YAdNM5KPRs/1LOMjJDpdYXj7hqeaKrk+SEqmC4LXs4HDtfLDU3R5rn+SoOCGPYMN1B aSWzE9qYa+JmX7fw2doGPb6JdAjXXp+1AsHSi0AQQFQQALSS6zIUJg0msBl6gqzbHUA2 wlejyEKOPbNPH/Zko+z8ya+WbwlBFw+Uyy7QU2nZgRRib3aCH0xW++wq5KRQMTvEH/K8 qMlTaQNFWPNzXsf6NZB/NmrumR8WZysUwjPmSaTgBX4Pxo0+a0RQuOSRwIlKR6vZf55k AvhlCKWwcj3QdB6mLA9GW9s7tYnT83uHE2FGQ1BMZESPtdRi7H8zp3i7yQhWLucruAaH D4Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677827735; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=va4oVik2spJTAGL3WKnNefqrGMXdGKGoPkfAo2TocO0=; b=dRFJeIa1rA2ZkIfmJfTF37QIiK1vOPwxWpPx29yHpIJnHEsUhqrgncD2qc/y6Bh+jc /zbcmvtqWvlGaRCCaCZNfwwfVr2basWl5x17wqw0z5Az/ekqcpxUMF1pMiMB/rGVNW2x 6zDmipugxw4F0v1fvXkauvmKovia7IVOblW+rKg4B16uX2z9ysW664+p+JT7hQ2j2mN5 cAfRR095R29DM3KwRjzBy9VxdTlv36zmf6ilrrRrLbvK7o5wu07XcdIvLzwKRN2ljNEj OakiX9aTVBkpf8a3Uh1o1pWfxq0MZUG+S7fiz+8KndkRVJBHv4IzwUuxjkGAUivdRc3t qWtg== X-Gm-Message-State: AO0yUKXaB95cF5pv0unRQhgIHjVWgPk+41ZS6ehYsH5n5LCa7TP2K9EQ W0BeQTeu/gFNLTGPsg+E+gCDkx2YR+c= X-Google-Smtp-Source: AK7set+HNjWGDUsvvHAJSWnjyynsY5R1vvs7OVxKHLUTCWkSwZtg6/GS8PoTCzpAdH+PiKSNu/UHBg== X-Received: by 2002:a05:6a20:7fa7:b0:cb:77f0:9a42 with SMTP id d39-20020a056a207fa700b000cb77f09a42mr1665051pzj.33.1677827734948; Thu, 02 Mar 2023 23:15:34 -0800 (PST) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id d19-20020a63d713000000b00502dc899394sm780410pgg.66.2023.03.02.23.15.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Mar 2023 23:15:34 -0800 (PST) Content-Language: en-US In-Reply-To: <83pm9qco9v.fsf@gnu.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::62d; envelope-from=jporterbugs@gmail.com; helo=mail-pl1-x62d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:303909 Archived-At: On 3/2/2023 11:00 PM, Eli Zaretskii wrote: >> Date: Thu, 2 Mar 2023 14:15:49 -0800 >> Cc: Eli Zaretskii , eggert@cs.ucla.edu, emacs-devel@gnu.org >> From: Jim Porter >> >> Would that be safe? Since 'parameters' is an argument, we don't actually >> know how it was created or if modifying in-place would be ok. If it were >> just a regular quoted list, using 'setf' could cause problems. > > If this aspect could be an issue, perhaps it is better to implement > the change without touching 'parameters' at all? It isn't hard, it > just might make the change less elegant and slightly larger. Pushing onto the front of 'parameters' should be safe, in the sense that after 'make-frame' returns, the caller wouldn't be able to tell that we did anything to it. So long as the caller can't tell, I think it's ok. However, there might be a better way to do this anyway; I'll think it over.