From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: "Phillip Lord" Newsgroups: gmane.emacs.devel Subject: Re: Reformat all of src/ Date: Fri, 30 Dec 2016 10:30:23 -0000 Message-ID: <2ef9531effde4d1639e69c7520af2bc0.squirrel@cloud103.planethippo.com> References: <87h95olvg0.fsf@gmail.com> <228ccc55affe1320a030a5652c63e005.squirrel@cloud103.planethippo.com> <84ddbf7683fbed9e34fa9ad65a88956f.squirrel@cloud103.planethippo.com> <83zijeu2tu.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1483093871 22893 195.159.176.226 (30 Dec 2016 10:31:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 30 Dec 2016 10:31:11 +0000 (UTC) User-Agent: SquirrelMail/1.5.2 [SVN] Cc: emacs-devel@gnu.org, eggert@cs.ucla.edu, dgutov@yandex.ru, Phillip Lord To: "Eli Zaretskii" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Dec 30 11:31:05 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cMuSl-0004rn-6k for ged-emacs-devel@m.gmane.org; Fri, 30 Dec 2016 11:31:03 +0100 Original-Received: from localhost ([::1]:39258 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cMuSp-00058w-Uj for ged-emacs-devel@m.gmane.org; Fri, 30 Dec 2016 05:31:07 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54827) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cMuSH-00058q-Ul for emacs-devel@gnu.org; Fri, 30 Dec 2016 05:30:34 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cMuSH-0008Dz-6T for emacs-devel@gnu.org; Fri, 30 Dec 2016 05:30:33 -0500 Original-Received: from mailgw.mycpanelcloud.co.uk ([185.116.214.213]:46691) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cMuSB-0008AM-AY; Fri, 30 Dec 2016 05:30:27 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by mailgw.mycpanelcloud.co.uk (Postfix) with ESMTP id E5839C4227; Fri, 30 Dec 2016 10:30:02 +0000 (GMT) X-Virus-Scanned: by SpamTitan at mycpanelcloud.co.uk Original-Received: from mailgw.mycpanelcloud.co.uk (localhost [127.0.0.1]) by mailgw.mycpanelcloud.co.uk (Postfix) with ESMTP id 38651C4270; Fri, 30 Dec 2016 10:30:02 +0000 (GMT) Original-Received: from cloud103.planethippo.com (cloud103.planethippo.com [31.216.48.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mailgw.mycpanelcloud.co.uk (Postfix) with ESMTPS id 289A7C422B; Fri, 30 Dec 2016 10:30:02 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=russet.org.uk; s=default; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Cc:To:From:Subject:Date:References:In-Reply-To:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=wsUT+X++Kvf8J2T2iplkJ+5JQLFNXX4C534kBhYD34Q=; b=BIP7/Hm2/WFCD+2Zm1wzLD+39Q CoF7cgPlH+LXBq8+/kBaBboL57E1RpiykLmm+g9PUN7Y/JGVnX7H5zy4t9magGQJd44GS1+jj7h21 vDwPIYGteXOd3Umc3ln1L9VP8H6Z3bZVDCvpufiBgB6l27xTa4Q3t6NimOnqgpBB9Eq3ae0g5LU8q SsMK0C9amgxov78/r+709Txl5stzse7PEmxiVGNUqRfDjHEQ58MoyXE9mDYIvQiv79WH73WDxTKq8 pxrUahyHxgQmVL3g0Ak249n/56rWqA3uWoFNNISSB8Jb65PX3pq+NqeI9ZExM/x9zhnLx26kopbrx N8yxm8hA==; Original-Received: from [127.0.0.1] (port=55163 helo=cloud103.planethippo.com) by cloud103.planethippo.com with esmtpa (Exim 4.87) (envelope-from ) id 1cMuS7-000rI3-BA; Fri, 30 Dec 2016 10:30:23 +0000 Original-Received: from 151.65.229.35 ([151.65.229.35]) (SquirrelMail authenticated user phillip.lord@russet.org.uk) by cloud103.planethippo.com with HTTP; Fri, 30 Dec 2016 10:30:23 -0000 In-Reply-To: <83zijeu2tu.fsf@gnu.org> X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cloud103.planethippo.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - russet.org.uk X-Get-Message-Sender-Via: cloud103.planethippo.com: authenticated_id: phillip.lord@russet.org.uk X-Authenticated-Sender: cloud103.planethippo.com: phillip.lord@russet.org.uk X-detected-operating-system: by eggs.gnu.org: FreeBSD 8.x [fuzzy] X-Received-From: 185.116.214.213 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:210992 Archived-At: On Thu, December 29, 2016 4:17 pm, Eli Zaretskii wrote: >> Date: Thu, 29 Dec 2016 13:18:59 -0000 >> From: "Phillip Lord" >> Cc: Phillip Lord , emacs-devel@gnu.org, >> Dmitry Gutov >> >> >> I just checked and I think that comparing git diff --numstat output >> with and without -b should identify when whitespace-only changes have >> happened; this could be caught in the commit hook. > > Every mandatory check in the commit hook is a potential annoyance > (think of someone, such as myself, who needs to push changes for > others), so I'd prefer not to add any, unless we really must When you say "push" changes, I guess you mean commit patches? AFAICT, commit hooks do not run on pushes, so there should be no problem. But, yes, for patches, then indeed if it is you applying them, then you will b= e affected by the commit hook. On the other hand, if the person who creates the patch uses git to do so, the commit hook should affect their local commit when creating the patch. Likewise with pull requests. But, I agree, it is a small additional hassle. Phil