From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 5811404: Replace eldoc-documentation-function with a hook Date: Fri, 8 Jul 2016 03:06:18 +0300 Message-ID: <2eba57a5-8b70-8bc2-15c2-8e9233fced90@yandex.ru> References: <20160707032857.31916.95107@vcs.savannah.gnu.org> <20160707032857.E4A1422015C@vcs.savannah.gnu.org> <20160707235954.GA6381@holos.localdomain> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1467936400 6143 80.91.229.3 (8 Jul 2016 00:06:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 8 Jul 2016 00:06:40 +0000 (UTC) Cc: Stefan Monnier , emacs-devel@gnu.org To: Mark Oteiza , John Wiegley Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jul 08 02:06:32 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bLJJP-0006iI-EO for ged-emacs-devel@m.gmane.org; Fri, 08 Jul 2016 02:06:31 +0200 Original-Received: from localhost ([::1]:42844 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLJJO-000316-KI for ged-emacs-devel@m.gmane.org; Thu, 07 Jul 2016 20:06:30 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47752) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLJJJ-00030y-74 for emacs-devel@gnu.org; Thu, 07 Jul 2016 20:06:26 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bLJJF-0002xW-5F for emacs-devel@gnu.org; Thu, 07 Jul 2016 20:06:25 -0400 Original-Received: from mail-wm0-x234.google.com ([2a00:1450:400c:c09::234]:38022) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLJJE-0002xO-UR for emacs-devel@gnu.org; Thu, 07 Jul 2016 20:06:21 -0400 Original-Received: by mail-wm0-x234.google.com with SMTP id n127so1159033wme.1 for ; Thu, 07 Jul 2016 17:06:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=xjWVqSWsna7c3mJGcD04CsnYebyiSX0/lmL9AD3/kXk=; b=Oa1Yb6YHG8HHO+V0FfV9VD6uec7m61tAzI7MYB8JE/ClnLzJwaGjSV8A8iStzyBRa9 Z7lAu32b+8zu5CzNszAUwb/psWk5uzY3gVo2XpfQscZnQyGux5A7h7/V/DLC+IBAXSyy qgMF/hcoo9fVLc6W2/h7YFvjJXMu6XF3ilDDdkq1aljqtpl6b8uu+1iGbtg7F3uUUhyF CUpcL/nanMef7yCSNIa3fqbDhFTSEjFCOyLS/S/HJsuBs01JtGzQ/oGL7PcXhZ0sw7Fq CkVBE23FsXOhqapV/VWTuqmcynPA7bV5cSp2TISNgt0gDnjCA1nK9V42JfrbyzKfkWyj XrJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=xjWVqSWsna7c3mJGcD04CsnYebyiSX0/lmL9AD3/kXk=; b=WGytoCkvzhiwIkiBQg1C0gOLbLeDHto6wRdwimhoGLMSzC6Vr/lPT5rx9w5d/i7EyM BH+iI6bzH81J8UPNBn2FHTjgkbq+BS2AC8DOQl2t6+yhwkpj6rL2EuSrvm0LAx6a3clP efatcMriaxFoDY1NwZ95plQ3kC6uS0oB86TtcmJs0COcVFdfnn/b40PyDQs7lGgi6eFU OGYmblnQRuhD552d2Mvv6+LkzLH5V5flkXPdgcB45jBlv/zy4Po/8+bNyTwvl2FF2vO5 1RQuFAa4/FHZwc9H6XaYYkSEPLNVe2Rp9F7llA2i/efYkGi0FDMC6AqYkdHrZz5r4vvj B2bg== X-Gm-Message-State: ALyK8tKx8EMW1Zsw4nSehhpqghcZfyJyNftb74rl8lSGolI2qKhBJcOISa25Dlnjx5Q8Xw== X-Received: by 10.194.123.166 with SMTP id mb6mr2653773wjb.94.1467936380076; Thu, 07 Jul 2016 17:06:20 -0700 (PDT) Original-Received: from [192.168.1.2] ([185.105.173.135]) by smtp.googlemail.com with ESMTPSA id v70sm265355wmf.18.2016.07.07.17.06.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Jul 2016 17:06:19 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:47.0) Gecko/20100101 Thunderbird/47.0 In-Reply-To: <20160707235954.GA6381@holos.localdomain> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::234 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:205398 Archived-At: On 07/08/2016 02:59 AM, Mark Oteiza wrote: > It is unclear what discussion you are talking about. Perhaps it's > here[1], but if not, I hope you will read it Did you? https://lists.gnu.org/archive/html/emacs-devel/2016-06/msg00331.html > One could refer to a number of sources for developer > opinion on using advice in core, but perhaps it is best to quote the > Elisp manual: > > […] advice should be reserved for the cases where you cannot modify > a function’s behavior in any other way. If it is possible to do > the same thing via a hook, that is preferable (see Hooks). […] In > particular, Emacs’s own source files should not put advice on > functions in Emacs. (There are currently a few exceptions to this > convention, but we aim to correct them.) > > [0] http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=fd020a29 > [1] https://lists.gnu.org/archive/html/emacs-devel/2016-06/msg00138.html