Re: master 5f9b5803bea: Fix zooming images in SHR

[Jim Porter <jporterbugs@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 387 bytes --]

On 6/26/2024 6:49 AM, Eli Zaretskii wrote:
>> Date: Tue, 25 Jun 2024 22:09:20 -0700
>> Cc: jm@pub.pink, emacs-devel@gnu.org
>> From: Jim Porter <jporterbugs@gmail.com>
>>
>> Hmm. What do you see if you try this patch? (Warning, it may print quite
>> a bit since it'll dump the full buffer contents including properties.)
> 
> It doesn't apply, please resend as attachment.

Here you go.

[-- Attachment #2: shr-test.diff --]
[-- Type: text/plain, Size: 1963 bytes --]

diff --git a/test/lisp/net/shr-tests.el b/test/lisp/net/shr-tests.el
index 4864fc488e2..c4c861bf958 100644
--- a/test/lisp/net/shr-tests.el
+++ b/test/lisp/net/shr-tests.el
@@ -138,7 +138,8 @@ shr-test/zoom-image
   (skip-unless (bound-and-true-p image-types))
   (let ((image (expand-file-name "data/image/blank-100x200.png"
                                  (getenv "EMACS_TEST_DIRECTORY"))))
-    (dolist (alt '(nil "" "nothing to see here"))
+    (dolist (alt '(nil ;; "" "nothing to see here"
+                       ))
       (with-temp-buffer
         (ert-info ((format "image with alt=%S" alt))
           (let ((attrs (if alt (format " alt=\"%s\"" alt) "")))
@@ -156,16 +157,21 @@ shr-test/zoom-image
                      (shr-width 80)
                      (shr-use-fonts nil)
                      (shr-image-animate nil)
-                     (inhibit-message t)
+                     ;; (inhibit-message t)
                      (dom (libxml-parse-html-region (point-min) (point-max))))
             ;; Render the document.
             (erase-buffer)
             (shr-insert-document dom)
-            (shr-test-wait-for (lambda () (= put-image-calls 1)))
+            (message "Initial buffer contents:\n%S\n\n" (buffer-string))
+            (shr-test-wait-for (lambda () (= put-image-calls 1))
+                               "Timed out waiting for initial load")
+            (message "Fully-loaded buffer contents:\n%S\n\n" (buffer-string))
             ;; Now zoom the image.
             (goto-char (point-min))
             (shr-zoom-image)
-            (shr-test-wait-for (lambda () (= put-image-calls 2)))
+            (shr-test-wait-for (lambda () (= put-image-calls 2))
+                               "Timed out waiting to zoom image")
+            (message "Final buffer contents:\n%S\n\n" (buffer-string))
             ;; Check that we got a sliced image.
             (let ((slice-count 0))
               (goto-char (point-min))