From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: discoverability, better defaults and which-key in Emacs Date: Sun, 11 Feb 2024 04:17:21 +0200 Message-ID: <2dab155b-05a1-4672-b327-680a683f63e4@gutov.dev> References: <874jetaxri.fsf@jeremybryant.net> <87le84oqbd.fsf@yahoo.com> <87plxdpsxw.fsf@posteo.net> <87r0hridvr.fsf@posteo.net> <5dd3d04c-c0eb-43fe-b7c2-957f80261ea3@gutov.dev> <87eddqiw84.fsf@posteo.net> <32071337-c91d-46ad-bb9b-10b8d0c83965@gutov.dev> <86h6ikzc38.fsf@gnu.org> <1056a72d-af5c-487e-be33-67522fe47d17@gutov.dev> <87r0hnohgv.fsf@gmail.com> <86a5obxwy9.fsf@gnu.org> <61ffccc8-56c0-4b14-9420-2d0fd9cac216@gutov.dev> <86r0hnw1l1.fsf@gnu.org> <86o7crvza4.fsf@gnu.org> <941e2791-bb35-4de6-b7a7-e3dce4938a1d@gutov.dev> <8c6f06a7-e5e3-499a-88c4-d2b035262c4d@gutov.dev> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------deCUOA5gMA1bMc3F9tRQj0o2" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37945"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: visuweshm@gmail.com, justin@burkett.cc, philipk@posteo.net, luangruo@yahoo.com, jb@jeremybryant.net, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Feb 11 03:18:39 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rYzQS-0009eI-UP for ged-emacs-devel@m.gmane-mx.org; Sun, 11 Feb 2024 03:18:37 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rYzPU-0002Wh-M8; Sat, 10 Feb 2024 21:17:36 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rYzPT-0002WU-7s for emacs-devel@gnu.org; Sat, 10 Feb 2024 21:17:35 -0500 Original-Received: from wout1-smtp.messagingengine.com ([64.147.123.24]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rYzPQ-0000vX-Nq; Sat, 10 Feb 2024 21:17:34 -0500 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 20E17320094F; Sat, 10 Feb 2024 21:17:26 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sat, 10 Feb 2024 21:17:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1707617845; x=1707704245; bh=KyQTGOJXl2 5GzSTbFV6n/gjjfI7RaYez+hniURrHk5A=; b=XAjTwsBNmz3ggTanQ95C+CS/u7 LBDs+xL7u4wLKalZLcYKdcy94KflugjwfiwxFT/r4B3yzyOvdL7QY63JsffyJ+JY jcDgJCm9lLySN5nXhfYiAGPi2UNCQQilj1cP2Ob9hzkOl6JfshQXTA+BNtifo+qb QCctm0BhVHepOPr4teXuxmcaA8hnrZl/AAZdF9T5nqtdyhZPOIExpcQVmFYDHbha ko0btgtb54GKRfGqlPYKP9BOPjVJmnt2hW9Q3lZXawf1/1yOojzkItkoDSQPnven GRrR0b6SUtlB2WWH9vNsOLVUBwnS0OsnEQz0u/csGiihSJc8/B8V/ciDZTyQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1707617845; x=1707704245; bh=KyQTGOJXl25GzSTbFV6n/gjjfI7R aYez+hniURrHk5A=; b=sXoxXiRKas/Eg7jCQco8UnQ3ECl6+yNB/J+jKDfw+ZO9 j2hwMMiIh8u9EfjN0v84hiFo2idyD2ed1iFPgE7NEpVWXurMvhKXBaLxZsI13thS 3mG26qUuP3YtL1XXVUvAxqDbP+ovfTGyJ9szAE/cfCB8yO/OMwiauIzVXUFzknNo v4b/t69YVqzzfJzDeEcXxuG5n14+DwkYn8CAT5qy5g4YpDioKReSO+ZxmcpUXPQx y6AFS3CuGyA8dcOSb5UsgwvsMxDw3cOzbd1NksFyPckfcQJFrJihceNC1tzhXK4y H0/x0bKwsDrHGW6k0oONBCy2d8sClKc/SKy48r44bw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledruddtgdegiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpegtkfffgggfuffhvfevfhgjsehmtderredtvdejnecuhfhrohhmpeffmhhithhr hicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrthhtvg hrnheptddvueegvdetledvgeevgfeutdfgteehgfegffektdekgeevieefiedujeeuffff necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepughmih htrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 10 Feb 2024 21:17:22 -0500 (EST) Content-Language: en-US In-Reply-To: <8c6f06a7-e5e3-499a-88c4-d2b035262c4d@gutov.dev> Received-SPF: pass client-ip=64.147.123.24; envelope-from=dmitry@gutov.dev; helo=wout1-smtp.messagingengine.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_SBL_A=0.1 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:316106 Archived-At: This is a multi-part message in MIME format. --------------deCUOA5gMA1bMc3F9tRQj0o2 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 08/02/2024 18:12, Dmitry Gutov wrote: > On 08/02/2024 16:43, Dmitry Gutov wrote: >> If you can come up with a code that detects at run time that help-key >> and/or F1 was rebound to a key that will not invoke >> describe-prefix-bindings, such a key should indeed better be removed >> from the message.  But can we reliably do that?  If we cannot, having >> two keys there instead of one is better. > > Here's a rough draft. > > It seems to work in the basic cases that I've tried (changing help-char > to something with a binding and rebinding ), but doesn't account for > key translations for far (e.g. if help-char is ?X and the prefix map has > ?x, this isn't caught). > > Also, piping the current used map through so many methods is pretty > messy, I'm sure whether I've used the appropriate value in other > callsites of echo_now and echo_dash. There's also echo_update... > > So if anybody has something simpler in mind that'd be welcome. Here's that simpler version. It doesn't address the "key translations" example above, but it seems rare enough, and it should be possible to fix later. So I suggest we install this now. --------------deCUOA5gMA1bMc3F9tRQj0o2 Content-Type: text/x-patch; charset=UTF-8; name="echo_keystrokes_help_v4.diff" Content-Disposition: attachment; filename="echo_keystrokes_help_v4.diff" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpc3AvaGVscC5lbCBiL2xpc3AvaGVscC5lbAppbmRleCA3MmE0Zjhh ODAwZC4uMDdlZWQyODYxYzIgMTAwNjQ0Ci0tLSBhL2xpc3AvaGVscC5lbAorKysgYi9saXNw L2hlbHAuZWwKQEAgLTIyNTMsNiArMjI1MywyNyBAQCBoZWxwLWZvcm0tc2hvdwogCSh3aXRo LW91dHB1dC10by10ZW1wLWJ1ZmZlciAiICpDaGFyIEhlbHAqIgogCSAgKHByaW5jIG1zZykp KSkpCiAKKyhkZWZ1biBoZWxwLS1hcHBlbmQta2V5c3Ryb2tlcy1oZWxwIChzdHIpCisgIChs ZXQqICgoa2V5cyAodGhpcy1zaW5nbGUtY29tbWFuZC1rZXlzKSkKKyAgICAgICAgIChiaW5k aW5ncyAoZGVsZXRlIG5pbAorICAgICAgICAgICAgICAgICAgICAgICAgICAgKG1hcGNhciAo bGFtYmRhIChtYXApIChsb29rdXAta2V5IG1hcCBrZXlzIHQpKQorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAoY3VycmVudC1hY3RpdmUtbWFwcyB0KSkpKSkKKyAgICAo Y2F0Y2ggJ3JlcworICAgICAgKGRvbGlzdCAodmFsIGhlbHAtZXZlbnQtbGlzdCkKKyAgICAg ICAgKGxldCAoKGtleSAodmVjdG9yIChpZiAoZXFsIHZhbCAnaGVscCkKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBoZWxwLWNoYXIKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgdmFsKSkpKQorICAgICAgICAgICh1bmxlc3MgKHNlcS1maW5kIChsYW1iZGEgKG1h cCkgKGFuZCAoa2V5bWFwcCBtYXApIChsb29rdXAta2V5IG1hcCBrZXkpKSkKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICBiaW5kaW5ncykKKyAgICAgICAgICAgICh0aHJvdyAncmVz CisgICAgICAgICAgICAgICAgICAgKGNvbmNhdAorICAgICAgICAgICAgICAgICAgICBzdHIK KyAgICAgICAgICAgICAgICAgICAgKHN1YnN0aXR1dGUtY29tbWFuZC1rZXlzCisgICAgICAg ICAgICAgICAgICAgICAoZm9ybWF0CisgICAgICAgICAgICAgICAgICAgICAgIiAoXFxgJXMn IGZvciBoZWxwKSIKKyAgICAgICAgICAgICAgICAgICAgICAoa2V5LWRlc2NyaXB0aW9uIGtl eSkpKSkpKSkpCisgICAgICBzdHIpKSkKKwogDAogKGRlZnVuIGhlbHAtLWRvY3N0cmluZy1x dW90ZSAoc3RyaW5nKQogICAiUmV0dXJuIGEgZG9jIHN0cmluZyB0aGF0IHJlcHJlc2VudHMg U1RSSU5HLgpkaWZmIC0tZ2l0IGEvc3JjL2tleWJvYXJkLmMgYi9zcmMva2V5Ym9hcmQuYwpp bmRleCAxMGNkZWY2NzM0OC4uOGNjMWIyZWM3NTYgMTAwNjQ0Ci0tLSBhL3NyYy9rZXlib2Fy ZC5jCisrKyBiL3NyYy9rZXlib2FyZC5jCkBAIC01OTQsMTQgKzU5NCw5IEBAIGVjaG9fZGFz aCAodm9pZCkKIAkJICAgIGNvbmNhdDIgKEtWQVIgKGN1cnJlbnRfa2JvYXJkLCBlY2hvX3N0 cmluZyksIGRhc2gpKTsKIAogICBpZiAoZWNob19rZXlzdHJva2VzX2hlbHApCi0gICAgewot ICAgICAgTGlzcF9PYmplY3QgaGVscDsKLQotICAgICAgaGVscCA9IGJ1aWxkX3N0cmluZyAo IiAoXFxgQy1oJyBvciBcXGA8ZjE+JyBmb3IgaGVscCkiKTsKLSAgICAgIGtzZXRfZWNob19z dHJpbmcgKGN1cnJlbnRfa2JvYXJkLAotCQkJY29uY2F0MiAoS1ZBUiAoY3VycmVudF9rYm9h cmQsIGVjaG9fc3RyaW5nKSwKLQkJCQkgY2FsbG4gKFFzdWJzdGl0dXRlX2NvbW1hbmRfa2V5 cywgaGVscCkpKTsKLSAgICB9CisgICAga3NldF9lY2hvX3N0cmluZyAoY3VycmVudF9rYm9h cmQsCisJCSAgICAgIGNhbGxuIChpbnRlcm5fY19zdHJpbmcgKCJoZWxwLS1hcHBlbmQta2V5 c3Ryb2tlcy1oZWxwIiksCisJCQkgICAgIEtWQVIgKGN1cnJlbnRfa2JvYXJkLCBlY2hvX3N0 cmluZykpKTsKIAogICBlY2hvX25vdyAoKTsKIH0K --------------deCUOA5gMA1bMc3F9tRQj0o2--