From: Dmitry Gutov <dgutov@yandex.ru>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: Eli Zaretskii <eliz@gnu.org>,
Nikolay Kudryavtsev <nikolay.kudryavtsev@gmail.com>,
emacs-devel@gnu.org
Subject: Re: Patches for Emacs 25.2
Date: Mon, 7 Nov 2016 11:36:22 +0200 [thread overview]
Message-ID: <2d749ac6-636b-14f2-e5a9-dcc0e9ba7541@yandex.ru> (raw)
In-Reply-To: <87oa1r64vg.fsf@gmx.de>
On 07.11.2016 11:01, Michael Albinus wrote:
>> Can't we move the (file-remote-p ... 'localname) call to the first
>> hunk here? Then the patch will only change one place, and we get rid
>> of the added `or' here.
>
> I let it to Nikolay.
Not sure I understand.
> However, given that this construct
>
> (or (file-remote-p FILE 'localname) FILE)
>
> happens several times in the lisp sources, I wonder whether we shall
> give it an own defmacro or defsubst (in master, of course).
I have no strong opinion either way, but your commit in master fixing
this problem does not have this construct.
next prev parent reply other threads:[~2016-11-07 9:36 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 7:09 Patches for Emacs 25.2 Michael Albinus
2016-10-18 7:24 ` Eli Zaretskii
2016-10-18 7:47 ` Michael Albinus
2016-10-18 8:09 ` Nikolay Kudryavtsev
2016-10-18 8:25 ` Michael Albinus
2016-10-18 9:24 ` Eli Zaretskii
2016-10-18 11:05 ` Nikolay Kudryavtsev
2016-10-18 11:29 ` Eli Zaretskii
2016-10-18 11:59 ` Nikolay Kudryavtsev
2016-10-18 12:32 ` Michael Albinus
2016-10-18 14:38 ` Eli Zaretskii
2016-11-07 0:08 ` Dmitry Gutov
2016-11-07 9:01 ` Michael Albinus
2016-11-07 9:36 ` Dmitry Gutov [this message]
2016-11-07 10:31 ` Michael Albinus
2016-11-07 10:39 ` Dmitry Gutov
2016-11-07 10:58 ` Michael Albinus
2016-11-19 23:03 ` Dmitry Gutov
2016-11-20 15:34 ` file-local-name (was: Patches for Emacs 25.2) Michael Albinus
2016-11-19 23:04 ` Patches for Emacs 25.2 Dmitry Gutov
2016-11-20 8:49 ` Michael Albinus
2016-12-31 4:20 ` Nikolay Kudryavtsev
2016-12-31 11:32 ` Dmitry Gutov
2016-12-31 11:40 ` Eli Zaretskii
2016-12-31 11:44 ` Dmitry Gutov
2017-01-02 10:21 ` Nikolay Kudryavtsev
2017-01-02 10:32 ` Dmitry Gutov
2017-01-02 12:22 ` Michael Albinus
2017-01-02 18:43 ` Nikolay Kudryavtsev
2017-01-02 18:54 ` Michael Albinus
2017-01-02 19:08 ` Dmitry Gutov
2017-01-02 19:56 ` Michael Albinus
2017-01-02 20:08 ` Dmitry Gutov
2017-01-02 19:54 ` Michael Albinus
2017-01-02 20:52 ` Nikolay Kudryavtsev
2017-01-02 19:13 ` Dmitry Gutov
2016-10-18 9:13 ` Eli Zaretskii
2016-10-18 9:55 ` Michael Albinus
2016-10-18 10:05 ` Eli Zaretskii
2016-10-18 11:24 ` Michael Albinus
2016-10-18 11:30 ` Eli Zaretskii
2016-12-16 0:05 ` Dmitry Gutov
2016-12-16 8:10 ` Eli Zaretskii
2016-12-16 18:33 ` Dmitry Gutov
2016-12-16 21:11 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d749ac6-636b-14f2-e5a9-dcc0e9ba7541@yandex.ru \
--to=dgutov@yandex.ru \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=michael.albinus@gmx.de \
--cc=nikolay.kudryavtsev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).