From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Ken Manheimer" Newsgroups: gmane.emacs.devel Subject: Re: pdbtrack [was Re: python.el fixes for Emacs 22] Date: Thu, 21 Feb 2008 17:40:40 -0500 Message-ID: <2cd46e7f0802211440i44f1efc5n19e892066a63ece9@mail.gmail.com> References: <18356.54892.186541.669277@kahikatea.snap.net.nz> <861w7euz7a.fsf@lola.quinscape.zz> <2cd46e7f0802150943x46e9bcb0i4c3b6075d48cc979@mail.gmail.com> <18363.29854.271108.937443@kahikatea.snap.net.nz> <18363.37318.759923.736701@kahikatea.snap.net.nz> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1203633749 2426 80.91.229.12 (21 Feb 2008 22:42:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 21 Feb 2008 22:42:29 +0000 (UTC) Cc: Glenn Morris , emacs-devel@gnu.org To: "Nick Roberts" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 21 23:42:41 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JSK7b-00068s-2p for ged-emacs-devel@m.gmane.org; Thu, 21 Feb 2008 23:42:31 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JSK75-0005Q7-Sx for ged-emacs-devel@m.gmane.org; Thu, 21 Feb 2008 17:41:59 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JSK5v-0004qX-DP for emacs-devel@gnu.org; Thu, 21 Feb 2008 17:40:47 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JSK5q-0004na-VJ for emacs-devel@gnu.org; Thu, 21 Feb 2008 17:40:44 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JSK5q-0004nV-RX for emacs-devel@gnu.org; Thu, 21 Feb 2008 17:40:42 -0500 Original-Received: from el-out-1112.google.com ([209.85.162.183]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JSK5q-00010Q-M0 for emacs-devel@gnu.org; Thu, 21 Feb 2008 17:40:42 -0500 Original-Received: by el-out-1112.google.com with SMTP id m34so202133ele.10 for ; Thu, 21 Feb 2008 14:40:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=Tj8j/oatdS+mecY4x4QNUISErbKcZxnlgQChkzbvyKU=; b=pLJ7Ic3a8EOPj+dMrZmx+11oNYD6tcFsUTeq/Z++0M1jiawA/OAO5o2qR9M84bgXeaAJ9u8dGxxGRqAh03bdooZO+dyKWnZXtOfmclMQ0yVJ9jtfy41a7XGjeIFykez2FHrpYnnV+dy+F1Q2sGT+dcoVrebxppJK+I7Ftl2+eNY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=Iy0FGyDWmx70/136Uf50Xj3/Kc+gtknV2c7PHXz/FSqEdqkqQcasnzG+Kja7zgdigCp6jsJdYdnarEDQ9DplbU84Lq3OLRccGcbYhUwSyiERP9bZ6MY1/uqEnIclFscyFTGFXIFIEdzDc9/6Gffrw2HI/SFJTcu7VwC1ROsfh/U= Original-Received: by 10.114.193.1 with SMTP id q1mr678598waf.75.1203633641008; Thu, 21 Feb 2008 14:40:41 -0800 (PST) Original-Received: by 10.114.160.13 with HTTP; Thu, 21 Feb 2008 14:40:40 -0800 (PST) In-Reply-To: <18363.37318.759923.736701@kahikatea.snap.net.nz> Content-Disposition: inline X-detected-kernel: by monty-python.gnu.org: Linux 2.4-2.6 (Google crawlbot) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:89884 Archived-At: On Tue, Feb 19, 2008 at 9:34 PM, Nick Roberts wrote: > > It uses four undefined functions: > > > > python-goto-beyond-block, python-nesting-level, python-safe, > > python-execute-file > > > > Can I ask people to check for byte-compiler warnings when they install > > things? Almost all are either genuine errors or are trivially > > suppressible these days. none of these functions have anything to do with the pdbtrack changes that nick made. they all appear to be preexisting artifacts of an incomplete adoption of code from python-mode.el. (if so, the python.el file commentary ought to acknowledge that.) i just checked in some refinements of the pdbtrack provisions without settling these dangling functions. i'm about to spend some more time seeing about settling them. from a quick glance, though, the changes are not trivial. in general, i don't think it's reasonable to expect everyone who touches a file to settle all preexisting issues. > I don't know what to do about these: remove references to them or install the > functions from python-mode.el of which I no longer have a copy, but I'm sure > Ken will. i do have a copy, and will look at copying over more code, or inhibiting the dangling references. this obviously is delicate attribution territory, mitigated somewhat by the fact that (1) the python-mode authors are interested in pursuing a consolidation, and (2) some code was probably copied, already, if the matches against routines in python-mode.el is any evidence. > Let's not forget the bigger picture too. Byte-compiler warnings on the trunk > at this stage aren't the end of the world. i can understand the desire to minimize all incidental warnings, so new warnings are visible. still, i think this is a less trivial situation than was being supposed. -- ken http://myriadicity.net