From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler Newsgroups: gmane.emacs.devel Subject: Re: [External] : Improvement proposals for `completing-read' Date: Fri, 9 Apr 2021 13:47:14 +0200 Message-ID: <2c312bb5-bfe9-d1f1-b7b7-9af1a44617ce@daniel-mendler.de> References: <3470841e-d0ef-69d2-aa58-67fd0fd57645@daniel-mendler.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21488"; mail-complaints-to="usenet@ciao.gmane.io" To: "emacs-devel@gnu.org" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Apr 09 13:48:35 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lUpco-0005Rx-QX for ged-emacs-devel@m.gmane-mx.org; Fri, 09 Apr 2021 13:48:34 +0200 Original-Received: from localhost ([::1]:45432 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lUpcn-0000Fd-Pc for ged-emacs-devel@m.gmane-mx.org; Fri, 09 Apr 2021 07:48:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38462) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUpbf-00087t-E8 for emacs-devel@gnu.org; Fri, 09 Apr 2021 07:47:23 -0400 Original-Received: from server.qxqx.de ([2a01:4f8:121:346::180]:33921 helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUpbc-0006NW-Ki for emacs-devel@gnu.org; Fri, 09 Apr 2021 07:47:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:To:Subject:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=WZ0sx08qC7TyrVnXB9/b1dVVdTlu3EyCTg/67QNcFHE=; b=NElCN85FUXwFL71LkR90aSyYK4 yr0ZNOa8J7KiLW97lndiF8ddtTznPctNj+VTvCFWbOK+cidwHKGHmluXchTEglXPIESQ+CcArgOA9 nltNNoVJ/Jog9HNobRKcY1gCxxs8rZ/87tC0AxIWv5/dLhI+xMuJt06grM+Q8gFe7Gkk=; In-Reply-To: Content-Language: en-US Received-SPF: pass client-ip=2a01:4f8:121:346::180; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267708 Archived-At: On 4/9/21 1:19 PM, Jean Louis wrote: > * Drew Adams [2021-04-08 20:21]: >> Why is it even a use case? Why disable history when >> `completing-read' against the history? Maybe you >> have a good reason - what is it? > > This way, though the documentation does not say something about > it, but I do not see any history and I do not need to have > history variable, but function thinks there is history: > (completing-read "Choose: " '("Jane" "Joe") nil nil nil t) > > So it is effectively "disabled". This is actually illegal and will break `completion-all-sorted-completions`. My proposal is to explicitly allow this, the value `t` for the HIST argument. Please take a look at my original mail. > Maybe it was meant here to disable the general minibuffer > history, but that is obviously easy to do. Other way to disable > would be to encompass `completing-read' with one `let': > > (let ((history)) > (completing-read "Choose: " '("Jane" "Joe") nil nil nil 'history)) Sure there are workarounds. Note that the history variable must be dynamically bound. Then the history variable may also end up in the savehist. It is better to fix this properly. Daniel Mendler