* Re: master bbc18031aff 1/3: Go around calling the default process filter (reducing GC churn)
[not found] ` <20240609001229.B5286C1FB41@vcs2.savannah.gnu.org>
@ 2024-06-09 1:10 ` Po Lu
2024-06-09 2:10 ` Dmitry Gutov
0 siblings, 1 reply; 2+ messages in thread
From: Po Lu @ 2024-06-09 1:10 UTC (permalink / raw)
To: emacs-devel; +Cc: Dmitry Gutov
Dmitry Gutov <dgutov@yandex.ru> writes:
> +static void
> +read_and_insert_process_output (struct Lisp_Process *p, char *buf,
> + ssize_t nread,
> + struct coding_system *process_coding);
The identifier of a function declaration should not be broken after its
type, and its parameter list should not hold argument names, but only
their types.
> +static void read_and_insert_process_output (struct Lisp_Process *p, char *buf,
> + ssize_t nread,
> + struct coding_system *process_coding)
The inverse applies here.
> + if (NILP (BVAR (XBUFFER(p->buffer), enable_multibyte_characters))
Space absent after `XBUFFER'.
> + DEFVAR_BOOL ("read-process-output-fast", read_process_output_fast,
> + doc: /* Non-nil to optimize the insertion of process output.
How about `fast_read_process_output'?
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: master bbc18031aff 1/3: Go around calling the default process filter (reducing GC churn)
2024-06-09 1:10 ` master bbc18031aff 1/3: Go around calling the default process filter (reducing GC churn) Po Lu
@ 2024-06-09 2:10 ` Dmitry Gutov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Gutov @ 2024-06-09 2:10 UTC (permalink / raw)
To: Po Lu, emacs-devel
On 09/06/2024 04:10, Po Lu wrote:
> Dmitry Gutov <dgutov@yandex.ru> writes:
>
>> +static void
>> +read_and_insert_process_output (struct Lisp_Process *p, char *buf,
>> + ssize_t nread,
>> + struct coding_system *process_coding);
>
> The identifier of a function declaration should not be broken after its
> type, and its parameter list should not hold argument names, but only
> their types.
>
>> +static void read_and_insert_process_output (struct Lisp_Process *p, char *buf,
>> + ssize_t nread,
>> + struct coding_system *process_coding)
>
> The inverse applies here.
>
>> + if (NILP (BVAR (XBUFFER(p->buffer), enable_multibyte_characters))
>
> Space absent after `XBUFFER'.
I see you've made the edits. Thanks!
>> + DEFVAR_BOOL ("read-process-output-fast", read_process_output_fast,
>> + doc: /* Non-nil to optimize the insertion of process output.
>
> How about `fast_read_process_output'?
Sounds good to me.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-06-09 2:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <171789194904.738.7241072628567534095@vcs2.savannah.gnu.org>
[not found] ` <20240609001229.B5286C1FB41@vcs2.savannah.gnu.org>
2024-06-09 1:10 ` master bbc18031aff 1/3: Go around calling the default process filter (reducing GC churn) Po Lu
2024-06-09 2:10 ` Dmitry Gutov
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).