From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.devel Subject: Re: master 5b3c4004a9 2/2: Remove calls to intern with a static string from code that runs on X Date: Tue, 20 Sep 2022 11:24:00 +0000 Message-ID: <2b1180d2e5ee5ff71aa1@heytings.org> References: <166355307855.3830.3892166668612546304@vcs2.savannah.gnu.org> <20220919020439.67823C00874@vcs2.savannah.gnu.org> <874jx328ye.fsf@gnus.org> <877d1zsufw.fsf@yahoo.com> <87bkrbredr.fsf@yahoo.com> <878rmfpy2g.fsf@yahoo.com> <87fsgmn8cy.fsf@yahoo.com> <2b1180d2e5035730c58d@heytings.org> <87tu52lart.fsf@yahoo.com> <2b1180d2e5a07d0773c9@heytings.org> <87a66ul30g.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37050"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 20 16:19:35 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oae60-0009DE-DQ for ged-emacs-devel@m.gmane-mx.org; Tue, 20 Sep 2022 16:19:32 +0200 Original-Received: from localhost ([::1]:33106 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oae5x-0007wS-Ki for ged-emacs-devel@m.gmane-mx.org; Tue, 20 Sep 2022 10:19:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36202) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oabMD-0003ff-B6 for emacs-devel@gnu.org; Tue, 20 Sep 2022 07:24:07 -0400 Original-Received: from heytings.org ([95.142.160.155]:48934) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oabMB-0007Dt-NB for emacs-devel@gnu.org; Tue, 20 Sep 2022 07:24:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1663673041; bh=gU87sQ26j4BiUDxJtx3acGcY5qMqfJHEe2nLrs11u58=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=MAR5z2nlltBFf/z3AOHrog7eAy1V97pUi2kDHpWFnPX0WRQjaYKlzv9Dpob917ECi gnRNGnDfx7KXksEVSb7qGmUL4BS+Y8WZFVkEA51xCX6teXwIo6oCJgaTeZpx/D+TDw BdmumXOjarT/kjhvE4kx9Gcrz7pReG9Zd2ovVAMtIyJT/svBZU9kG9Ab575qDYgeYJ Eosr4wThqOhXjZZpA1PggxDqpuN4TfHv6HN0UZ9svxlQSdHBirlbU+tRQz7m+3f+Xk WmJMX0rXVRdOfkh1GuHeGT9gGvd978rkYdRxgqOcg8W91MtfbhYbG5fhM+eBluObBh lTHoQV7BE6n1w== In-Reply-To: <87a66ul30g.fsf@yahoo.com> Received-SPF: pass client-ip=95.142.160.155; envelope-from=gregory@heytings.org; helo=heytings.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:295802 Archived-At: >> That question means "Can you please try to reproduce the issue with >> emacs -Q?". If not, it's probably something that is specific to your >> configuration. > > But it used to work. So this has broken how I work with Emacs, and I > want it changed. > > And no, it doesn't happen in emacs -Q. > Apparently you have a bug in your configuration, why should Emacs be adapted to circumvent the bug in your configuration? >> There is nothing much different in that message from any other "echo" >> in other Makefiles, and I don't see why a leading indentation could >> change the way a pattern such as "[Makefile:412: advice-on-failure]" is >> detected and fontified. It seems like a bug somewhere. If you replace >> dashes with, say, '*', or '.', or numbers like "1." and "2.", is your >> problem solved? > > The problem seems to be indentation in the Makefile. > That can't be the cause of the problem you see. The message is indented with exactly two spaces, like all other "CC", "ELC", "GEN", "INFO"... messages. > > What exactly is the problem with making the message easier to understand > for others, even though you yourself think it is fine? > Because I do not think your message is easier to understand, I find it more difficult to understand. When say git prints an error message, it's not a paragraph in prose. Do you know other program that prints a paragraph in prose when a failure occurs? > > But since no colors are used here, that is besides the point. Printing > a message like this upon something as simple as a Makefile failing: > > !BEWARE! ...mundane advice.. > !BEWARE! ...mundane advice.. > !BEWARE! ...mundane advice.. > > amounts to what is considered by normal people as yelling in their > faces, which is not welcome in software, or in real life. > No, these !BEWARE! are like a traffic warning script. If the warning text itself had been written in capitals, that could have been considered as "yelling".