From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.devel Subject: Re: master 5b3c4004a9 2/2: Remove calls to intern with a static string from code that runs on X Date: Tue, 20 Sep 2022 08:48:53 +0000 Message-ID: <2b1180d2e5a07d0773c9@heytings.org> References: <166355307855.3830.3892166668612546304@vcs2.savannah.gnu.org> <20220919020439.67823C00874@vcs2.savannah.gnu.org> <874jx328ye.fsf@gnus.org> <877d1zsufw.fsf@yahoo.com> <87bkrbredr.fsf@yahoo.com> <878rmfpy2g.fsf@yahoo.com> <87fsgmn8cy.fsf@yahoo.com> <2b1180d2e5035730c58d@heytings.org> <87tu52lart.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6184"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 20 12:12:33 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oaaEx-0001Qy-74 for ged-emacs-devel@m.gmane-mx.org; Tue, 20 Sep 2022 12:12:31 +0200 Original-Received: from localhost ([::1]:54882 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oaaEq-0003P6-OK for ged-emacs-devel@m.gmane-mx.org; Tue, 20 Sep 2022 06:12:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48180) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oaYw8-00089V-Oq for emacs-devel@gnu.org; Tue, 20 Sep 2022 04:49:00 -0400 Original-Received: from heytings.org ([95.142.160.155]:48754) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oaYw4-0003bv-HY for emacs-devel@gnu.org; Tue, 20 Sep 2022 04:49:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1663663733; bh=HkHF1QTZlgC8mPwTT7xfjpno25edCQ1Mgn7vc2mbUC4=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=PM/0q/nR96RCAfaxYOMWj/cxrX/r+wFkpUlqkOALs2b0bBHgqZMPZmQ3ck6e/9Lt1 7lBSBAkqNUPfPipzKN/fnff5G3Vf2U4NumOvMTjncsD3nNejnWdFu0z9RoFiUXc409 sU8ieat5QyHmYJNZ3ye+Yqc/pxwtXcpidG6ggmGsI3axz+GS7V+oLCxSdHiEbHg0kr c2gmRDB2nvehlK+NMQYHVm2s6u5jvYYq0kir1WDXH4y4nKY5LeOWE89yvZBPNYzXFj npEs0CSaVg4pVUXePGgX/B60RvnS37DEZinT83s9zISR9+p8+qHTwqbBALUOTPw/kx +r10KBCmmYlWQ== In-Reply-To: <87tu52lart.fsf@yahoo.com> Received-SPF: pass client-ip=95.142.160.155; envelope-from=gregory@heytings.org; helo=heytings.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:295794 Archived-At: >> I'm puzzled. Is that with emacs -Q? > > No. I don't develop software in "emacs -Q". > That question means "Can you please try to reproduce the issue with emacs -Q?". If not, it's probably something that is specific to your configuration. >> I'm at 9035c20888, and all links seem to be fontified and to work >> correctly, each one takes me to the right place in the Makefile. Do >> you have a recipe, perhaps? > > The recipe is not very relevant, since we already know the fix. Which > is to remove indentation and leading dashes from the message. > There is nothing much different in that message from any other "echo" in other Makefiles, and I don't see why a leading indentation could change the way a pattern such as "[Makefile:412: advice-on-failure]" is detected and fontified. It seems like a bug somewhere. If you replace dashes with, say, '*', or '.', or numbers like "1." and "2.", is your problem solved? > > At the same time, it would be good to remove bullet lists from the > message, and reword it in plain English. > That's your opinion. Nobody else said something similar, and I disagree. What such an advice should display is a bullet list of possible actions, that the use can copy-paste and immediately try. > > Emphasis is better conveyed verbally, rather than with exclamation marks > and capitals. > That's perhaps correct in a docstring or a manual, but not in a terminal, in which capitals and e.g. or colors are commonly used to put emphasis on something.