From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: master 305dbc7 2/4: Move description of value to syntax-ppss function. Date: Sat, 15 Feb 2020 17:14:31 +0200 Message-ID: <2ade5926-99c8-0052-b1e3-6ba4b46b972c@yandex.ru> References: <20191030121649.15369.13207@vcs0.savannah.gnu.org> <20191030121651.BFCF8204DF@vcs0.savannah.gnu.org> <87eeyutgwa.fsf@gnus.org> <333d1d46-ab79-5818-4367-b28ed915aff6@yandex.ru> <87a79itfzp.fsf@gnus.org> <875zk6tfo7.fsf@gnus.org> <871ruuou5c.fsf@gnus.org> <7fbe5ad6-2ea6-5a5d-d77e-6df2ba143eb4@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="100688"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 Cc: Lars Ingebrigtsen , Stefan Monnier , Emacs developers To: Noam Postavsky Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Feb 15 16:15:10 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j2z9w-000Q3R-MR for ged-emacs-devel@m.gmane-mx.org; Sat, 15 Feb 2020 16:15:08 +0100 Original-Received: from localhost ([::1]:51932 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j2z9v-0001Ib-Nv for ged-emacs-devel@m.gmane-mx.org; Sat, 15 Feb 2020 10:15:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41487) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j2z9S-0000tC-La for emacs-devel@gnu.org; Sat, 15 Feb 2020 10:14:39 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j2z9R-0003wz-LO for emacs-devel@gnu.org; Sat, 15 Feb 2020 10:14:38 -0500 Original-Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]:46430) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j2z9R-0003uV-Ev for emacs-devel@gnu.org; Sat, 15 Feb 2020 10:14:37 -0500 Original-Received: by mail-wr1-x435.google.com with SMTP id z7so14452994wrl.13 for ; Sat, 15 Feb 2020 07:14:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=jPxd3cphyJf6KHMaYYJEtFnHFnXZkFo2XuJrrqJoVMo=; b=ODpMmLuqL5iromXNvUSI2x+ENqOunuYIQ/gxnJQMM//MtMHnPyVdT0MhWGVaVNtvLw QU67P7uF5QZrRDlrq8/JPciOlxWfhbJpbFYnnHtcEwUShR5H0zRSDPBG1PXODjGzsPb7 9lJmehe50Akr+LgLtg12J+ix2vLnM5LxvSaa/uyv4kiVc8fJGOb5LM2awzsDgQ4EC3E4 e4vE5/5u8qeUhzyMjQtEQelc9GbQebEbJ1cYRgrw46ljPzACko/wE8i3+0JSuPTpyEHx fL8qaOKbHGLVI1HBE3XHRfxnD7+cR5pjcpCPYVSZtitJpTdWyp6rhJo2WhNN3cEQGhKw c8zQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jPxd3cphyJf6KHMaYYJEtFnHFnXZkFo2XuJrrqJoVMo=; b=jxQidyn76IJ21qT0O2j4KDXlKkMHPqXeHdIWHBfzbUGYCA1ad4HbZPVApRBY/WKQWj MzC1aKH0NWVdcx+k+a7DDUpBU6X22FBeIT+jHz3kvkB+ARAoq5p/t3U3rsi87nzhaJIV lvFRSi8aMGq3xRtWi+d5IeloW7X2kUXvTW74mkaY3VQpUzhNMfIkxNLXOi4qU7lZw0dU 7xZkkTvRnWeUOjBRH1asImTHgdv6v2Lwk9vsunZiaN5jdN89NwMaAjDsDh96rL7BbCt+ VD31LzjVtffw6mxex3sdMppm1mBww7sSET63PhFaJOW8bOSDZsMeZIAyjg9mS1j4dFnZ SCQA== X-Gm-Message-State: APjAAAVvss1odaAegkUJOpExmh6NScAmoECbn8RgSz0O5uUa6ttM6W39 P7OMvoHmjDn7jNe2GjPh3wxl8TZG X-Google-Smtp-Source: APXvYqw8G4FkdyQLBv4YjIPs/I5vLvSA57saVQMW7SOWmuESHimgkIwEd3VO0vBvZZlbadbwHJwHqg== X-Received: by 2002:a5d:62d1:: with SMTP id o17mr10862641wrv.9.1581779674548; Sat, 15 Feb 2020 07:14:34 -0800 (PST) Original-Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id g25sm22068448wmh.3.2020.02.15.07.14.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 15 Feb 2020 07:14:33 -0800 (PST) In-Reply-To: Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::435 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:244949 Archived-At: On 15.02.2020 16:55, Noam Postavsky wrote: >>> - (comment-nesting nil :documentation "\ >>> + (comment nil :documentation "\ >> >> Doesn't this name imply some other value? Like a string (comment opener >> or its contents)? > > Hmm, you might be right about that. How about 'comment-depth': two > characters shorter, and the other names also use "depth" rather than > "nesting". Sounds good. >>> - (open-paren-positions >>> + (open-parens >>> nil :documentation >>> "List of positions of currently open parens, outermost first.") >>> - (two-character-syntax nil :documentation "\ >>> + (syntax-sequence nil :documentation "\ >>> When the last position scanned holds the first character of a >>> (potential) two character construct, the syntax of that position, >>> otherwise nil. That construct can be a two character comment >> >> These look okay to me. > > I'm actually feeling that the two-character-syntax one should be left > as is, it's kind of obscure so having a longer and more explicit name > seems better. Agree (I also have never used it). >> min-depth too, but, like last-complete-sexp-start, these fields in >> values returned by syntax-ppss are unreliable/undefined, so they won't >> be used in most Lisp programs anyway. > > I might be biased by having worked on the lisp indentation code which > uses those fields quite a bit. So... Lisp indentation code calls parse-partial-sexp directly? Anyway, I said min-depth is okay, but if we're going to have comment-depth, maybe min-depth starts to sound more ambiguous.