Re: make fails for Gnu Elpa

[Jackson Ray Hamilton <jackson@jacksonrayhamilton.com>]

[-- Attachment #1: Type: text/plain, Size: 2000 bytes --]

Weird, the order of the arguments to tar produces the same output with
both of those commands on my machine.

$ tar --version
tar (GNU tar) 1.27.1

Michael, does the attached patch fix the issue for you?

Jackson

On 12/27/2016 06:35 PM, Noam Postavsky wrote:
> On Tue, Dec 27, 2016 at 9:58 AM, Michael Heerdegen
> <michael_heerdegen@web.de> wrote:
>> Jackson Ray Hamilton <jackson@jacksonrayhamilton.com> writes:
>>
>>> Hi Michael,
>>>
>>> Sorry about that.  The GNUmakefile is supposed to not compile that
>>> file.  I've just pushed another patch in that area; will you pull and
>>> see if the issue still occurs?
>>
>> Yes, still occurs.
>>
>>> That doesn't happen on my system (Debian 8).  Can you also please
>>> describe your system?
>>
>> Debian testing (mostly).  make is from testing, version 4.1-9.
> 
> I think the problem is that the file arguments to tar have to go after
> the other options. Changing directory doesn't seem needed.
> 
> ~/src/emacs/elpa$ pt=packages/context-coloring
> ~/src/emacs/elpa$ tar -cvh $pt/*.el -X $pt/.elpaignore > /dev/null
> packages/context-coloring/context-coloring-benchmark.el
> packages/context-coloring/context-coloring-coverage.el
> packages/context-coloring/context-coloring.el
> packages/context-coloring/context-coloring-emacs-lisp.el
> packages/context-coloring/context-coloring-javascript.el
> packages/context-coloring/context-coloring-test.el
> ~/src/emacs/elpa$ tar -cvh -X $pt/.elpaignore $pt/*.el > /dev/null
> packages/context-coloring/context-coloring.el
> packages/context-coloring/context-coloring-emacs-lisp.el
> packages/context-coloring/context-coloring-javascript.el
> ~/src/emacs/elpa$ tar --version
> tar (GNU tar) 1.29
> Copyright (C) 2015 Free Software Foundation, Inc.
> License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>.
> This is free software: you are free to change and redistribute it.
> There is NO WARRANTY, to the extent permitted by law.
> 
> Written by John Gilmore and Jay Fenlason.
> 

[-- Attachment #2: 0001-Put-tar-d-files-at-the-end-to-fix-build-in-some-envi.patch --]
[-- Type: text/x-patch, Size: 872 bytes --]

From 098f6c9ad4e9b2613f4a6c1046b45a18c9758406 Mon Sep 17 00:00:00 2001
From: Jackson Ray Hamilton <jackson@jacksonrayhamilton.com>
Date: Thu, 29 Dec 2016 00:28:25 -0800
Subject: [PATCH] Put tar'd files at the end to fix build in some environments.

---
 GNUmakefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/GNUmakefile b/GNUmakefile
index 8edb2f8..e9dd3db 100644
--- a/GNUmakefile
+++ b/GNUmakefile
@@ -153,8 +153,8 @@ included_els := $(shell \
           prev=$$(pwd);					\
           cd $$pt;					\
           if [ -f .elpaignore ]; then			\
-              tar -ch *.el --no-recursion		\
-                  --exclude-vcs -X .elpaignore		\
+              tar -ch --no-recursion			\
+                  --exclude-vcs -X .elpaignore *.el	\
                 | tar --list;				\
           else						\
               ls -1 *.el;				\
-- 
2.1.4