From: "Jostein Kjønigsen" <jostein@secure.kjonigsen.net>
To: Randy Taylor <dev@rjt.dev>, jostein@kjonigsen.net
Cc: Yuan Fu <casouri@gmail.com>, Eli Zaretskii <eliz@gnu.org>,
Juri Linkov <juri@linkov.net>, emacs-devel <emacs-devel@gnu.org>,
theo@thornhill.no
Subject: Re: toml-ts-mode (code-review done)
Date: Wed, 14 Dec 2022 19:53:25 +0100 [thread overview]
Message-ID: <2a9504c6-edc6-a254-ecf0-bd7b578e48c1@secure.kjonigsen.net> (raw)
In-Reply-To: <AjB9ioRmmwT6XkZJJWCGQp9ssakHopeAOeBHgznzpLS2vgDfHLQGk8S6mBfQwHj1586QqKXxHnXuBch7Uv6LBlDEgrU79flMHtZx_F-7UGs=@rjt.dev>
[-- Attachment #1: Type: text/plain, Size: 576 bytes --]
On 14.12.2022 14:24, Randy Taylor wrote:
>
> On Wednesday, December 14th, 2022 at 03:40, Jostein Kjønigsen
> <jostein@secure.kjonigsen.net> wrote:
> Nice catch. Fixed.
>>
>> Attached is a new revision. Final revision? Is this good for merging
>> now? :)
>>
>> --
>>
>> Jostein
>>
> Looks good to me!
>
Great! Thanks for
So what's the next move from here on? Are there any other things which
needs to be completed before this can be merged?
I'm asking since this is my first full "original" submissions, which
isn't a patch to an existing package/module. :)
--
Jostein
[-- Attachment #2: Type: text/html, Size: 1688 bytes --]
next prev parent reply other threads:[~2022-12-14 18:53 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-11 13:28 toml-ts-mode: first draft Jostein Kjønigsen
2022-12-11 17:09 ` Juri Linkov
2022-12-11 17:23 ` Jostein Kjønigsen
2022-12-11 17:40 ` Eli Zaretskii
2022-12-11 18:19 ` Stefan Kangas
2022-12-11 18:23 ` Eli Zaretskii
2022-12-11 21:43 ` Stefan Kangas
2022-12-12 3:28 ` Eli Zaretskii
2022-12-12 17:04 ` Juri Linkov
2022-12-11 19:56 ` Jostein Kjønigsen
2022-12-11 20:07 ` Eli Zaretskii
2022-12-11 20:31 ` Jostein Kjønigsen
2022-12-11 20:38 ` Eli Zaretskii
2022-12-11 20:49 ` Jostein Kjønigsen
2022-12-11 23:01 ` Yuan Fu
2022-12-12 13:10 ` Jostein Kjønigsen
2022-12-12 13:53 ` Theodor Thornhill
2022-12-12 20:41 ` Jostein Kjønigsen
2022-12-12 21:17 ` Randy Taylor
2022-12-13 20:43 ` Jostein Kjønigsen
2022-12-13 22:37 ` Randy Taylor
2022-12-14 8:40 ` Jostein Kjønigsen
2022-12-14 13:24 ` Randy Taylor
2022-12-14 18:53 ` Jostein Kjønigsen [this message]
2022-12-14 19:02 ` toml-ts-mode (code-review done) Theodor Thornhill
2022-12-14 20:37 ` Yuan Fu
2022-12-14 22:02 ` Jostein Kjønigsen
2022-12-15 2:24 ` Randy Taylor
2022-12-15 12:52 ` Jostein Kjønigsen
2022-12-15 13:22 ` Theodor Thornhill
2022-12-15 13:45 ` Jostein Kjønigsen
2022-12-15 14:22 ` Eli Zaretskii
2022-12-15 14:28 ` Jostein Kjønigsen
2022-12-13 10:45 ` toml-ts-mode: first draft Rudolf Schlatte
2022-12-13 13:20 ` Eli Zaretskii
2022-12-13 14:22 ` Rudi Schlatte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a9504c6-edc6-a254-ecf0-bd7b578e48c1@secure.kjonigsen.net \
--to=jostein@secure.kjonigsen.net \
--cc=casouri@gmail.com \
--cc=dev@rjt.dev \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=jostein@kjonigsen.net \
--cc=juri@linkov.net \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).