From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.devel Subject: Re: Emacs regexp scan (Sep 29) Date: Sat, 5 Oct 2019 12:03:45 +0200 Message-ID: <2DA91502-8B38-4DE6-BCBC-CB59BE1E94A7@acm.org> References: <1697CA97-B2E6-4202-B14D-99DCF93954FD@acm.org> <02405f0d-788f-1b87-0269-b06eb2d67ff8@cs.ucla.edu> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="95900"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Oct 05 12:04:14 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iGgv7-000OnE-Ia for ged-emacs-devel@m.gmane.org; Sat, 05 Oct 2019 12:04:13 +0200 Original-Received: from localhost ([::1]:55386 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iGgv6-0007Yf-DZ for ged-emacs-devel@m.gmane.org; Sat, 05 Oct 2019 06:04:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39328) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iGguy-0007YX-Va for emacs-devel@gnu.org; Sat, 05 Oct 2019 06:04:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iGgux-0003uJ-Og for emacs-devel@gnu.org; Sat, 05 Oct 2019 06:04:04 -0400 Original-Received: from mail157c50.megamailservers.eu ([91.136.10.167]:48380 helo=mail51c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iGguw-0003qv-Mq for emacs-devel@gnu.org; Sat, 05 Oct 2019 06:04:03 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1570269828; bh=u7CEGusGBkIEoM2Lab5d2rCU1Gce3RUe8rFDQ3vbUCM=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=FCklcNI//JA666WIDIQUYwvSmLrRQZmKThWfWJ1XMsOvaBtKSHw/hv66j/ymJpvVA u///1D/k2I5reu9Zo3t7dP1mDn54g3L0g+FR+wFkVRIvEZx5SBdOdNRjmN1iV1Nlr3 +ceiXB0JEOVI2+0Z9GJjm5N4wG+3SSs6zclAmuVc= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.1.65] (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail51c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x95A3jfN026052; Sat, 5 Oct 2019 10:03:48 +0000 In-Reply-To: <02405f0d-788f-1b87-0269-b06eb2d67ff8@cs.ucla.edu> X-Mailer: Apple Mail (2.3445.104.11) X-CTCH-RefID: str=0001.0A0B0209.5D986A84.0036, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=GNR27dFK c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=xIruM2BQEcBp-HkU9REA:9 a=CjuIK1q_8ugA:10 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] [fuzzy] X-Received-From: 91.136.10.167 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:240608 Archived-At: 4 okt. 2019 kl. 23.42 skrev Paul Eggert : >=20 > Thanks, I installed the attached patch, which I hope fixes all the = bugs and style glitches uncovered by that scan, along with some other = style glitches I noticed in the neighborhood. Thank you, I've reviewed it and found no errors. I also grepped for = similar mistakes (missing \ or u in Unicode escapes) but didn't find = anything else. Just a small complaint remaining: (defconst gurmukhi-composable-pattern [...] - ("Y" . "[\u0A2F-u0A30\u0A35\u0A39]") ; YA, RA, VA, HA + ("Y" . "[\u0A2F-\u0A30\u0A35\u0A39]") ; YA, RA, VA, HA The hyphen can be removed. (You can run the checker yourself by installing the `relint' package = from GNU ELPA, and running M-x relint-directory RET RET.)