From: "Mattias Engdegård" <mattiase@acm.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: Emacs regexp scan (Sep 29)
Date: Sat, 5 Oct 2019 12:03:45 +0200 [thread overview]
Message-ID: <2DA91502-8B38-4DE6-BCBC-CB59BE1E94A7@acm.org> (raw)
In-Reply-To: <02405f0d-788f-1b87-0269-b06eb2d67ff8@cs.ucla.edu>
4 okt. 2019 kl. 23.42 skrev Paul Eggert <eggert@cs.ucla.edu>:
>
> Thanks, I installed the attached patch, which I hope fixes all the bugs and style glitches uncovered by that scan, along with some other style glitches I noticed in the neighborhood.
Thank you, I've reviewed it and found no errors. I also grepped for similar mistakes (missing \ or u in Unicode escapes) but didn't find anything else.
Just a small complaint remaining:
(defconst gurmukhi-composable-pattern
[...]
- ("Y" . "[\u0A2F-u0A30\u0A35\u0A39]") ; YA, RA, VA, HA
+ ("Y" . "[\u0A2F-\u0A30\u0A35\u0A39]") ; YA, RA, VA, HA
The hyphen can be removed.
(You can run the checker yourself by installing the `relint' package from GNU ELPA, and running
M-x relint-directory RET <Emacs source dir> RET.)
prev parent reply other threads:[~2019-10-05 10:03 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-29 19:39 Emacs regexp scan (Sep 29) Mattias Engdegård
2019-10-04 21:42 ` Paul Eggert
2019-10-05 8:10 ` Eli Zaretskii
2019-10-05 9:37 ` Mattias Engdegård
2019-10-05 10:49 ` Eli Zaretskii
2019-10-05 15:16 ` Stefan Monnier
2019-10-05 16:02 ` Eli Zaretskii
2019-10-05 9:52 ` Paul Eggert
2019-10-05 10:59 ` Eli Zaretskii
2019-10-05 15:20 ` Stefan Monnier
2019-10-05 16:03 ` Eli Zaretskii
2019-10-06 13:42 ` Stefan Monnier
2019-10-06 18:01 ` Eli Zaretskii
2019-10-05 19:19 ` Paul Eggert
2019-10-05 19:31 ` Eli Zaretskii
2019-10-05 19:50 ` Paul Eggert
2019-10-06 17:19 ` Eli Zaretskii
2019-10-06 17:33 ` Paul Eggert
2019-10-06 18:53 ` Eli Zaretskii
2019-10-06 19:19 ` Paul Eggert
2019-10-06 19:31 ` Eli Zaretskii
2019-10-05 16:59 ` Lars Ingebrigtsen
2019-10-05 18:52 ` Paul Eggert
2019-10-05 10:03 ` Mattias Engdegård [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2DA91502-8B38-4DE6-BCBC-CB59BE1E94A7@acm.org \
--to=mattiase@acm.org \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).