unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: David Reitter <david.reitter@gmail.com>
To: emacs- devel <emacs-devel@gnu.org>
Subject: slow make-frame + face initialization / importing x resources
Date: Fri, 13 Jul 2007 18:55:49 +0100	[thread overview]
Message-ID: <2CB90CD5-24E4-4EA9-BF74-5E9AE248BF6B@gmail.com> (raw)

I wonder if something can be done about the very slow `make-frame'.

Make-frame creates a frame-local copy of each face defined, and when  
you have a couple of faces defined for various modes, just a modest  
number of them (I have 700, defined with color-theme) will slow down  
frame creation to a point where it's just not tolerable any more.

Here's a bit of code to demonstrate the effect (with just "empty'  
faces):

(require 'cl)
(loop for X from 0 to 2000 do
       (make-face (intern (format "face%s" X))))
(let ((ti (current-time)))
   (loop for X from 0 to 10 do
	(make-frame))
   (print (format-time-string "%S" (time-since ti))))

The problem seems to be due to `x-create-frame-with-faces',  
specifically this form:

(dolist (face (delq 'default (face-list)))
       (condition-case ()
	  (progn
	    (face-spec-set face (face-user-default-spec face) frame)
	    (if (memq window-system '(x w32 mac))
		(make-face-x-resource-internal face frame))
	    (internal-merge-in-global-face face frame))
	(error nil)))

Frame creation time improves tremendously when I take out that call  
to `make-face-x-resource-internal'.
Is the import of x-resources necessary on Mac and Windows?
Also, is it necessary to do that every time a frame is created?  
Couldn't they be imported once at startup time?

             reply	other threads:[~2007-07-13 17:55 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-13 17:55 David Reitter [this message]
2007-07-13 23:08 ` slow make-frame + face initialization / importing x resources Richard Stallman
2007-07-14  1:21   ` Stefan Monnier
2007-07-14 22:32     ` Richard Stallman
2007-07-14  1:55   ` Stefan Monnier
2007-07-14 20:53     ` David Reitter
2007-07-14 21:28       ` Eli Zaretskii
2007-07-15  1:29         ` Stefan Monnier
2007-07-15 13:50           ` Jan Djärv
2007-07-15 14:07             ` David Kastrup
2007-07-15 22:02               ` Jan Djärv
2007-07-15 22:54             ` Richard Stallman
2007-07-15 22:53           ` Richard Stallman
2007-07-15  8:26         ` Juanma Barranquero
2007-07-15  9:35         ` David Reitter
2007-07-15 20:10           ` chad brown
2007-07-15 22:08             ` David Reitter
2007-07-16  1:40           ` Stefan Monnier
2007-07-16  3:19           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2CB90CD5-24E4-4EA9-BF74-5E9AE248BF6B@gmail.com \
    --to=david.reitter@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).