From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Scott Wheeler Newsgroups: gmane.emacs.devel Subject: [patch] Fix ns-antialias-text in Mac OS for 24.4 Date: Thu, 23 Oct 2014 03:31:43 +0200 Message-ID: <2C5AA177-0F30-418C-ACA3-11BFA9E76E73@gmx.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 (Mac OS X Mail 8.0 \(1990.1\)) Content-Type: multipart/mixed; boundary="Apple-Mail=_37C75C3A-9D89-47B8-96D5-918322113740" X-Trace: ger.gmane.org 1414031766 29390 80.91.229.3 (23 Oct 2014 02:36:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 23 Oct 2014 02:36:06 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 23 04:36:00 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Xh8Fr-0006lA-B5 for ged-emacs-devel@m.gmane.org; Thu, 23 Oct 2014 04:35:59 +0200 Original-Received: from localhost ([::1]:34041 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xh8Fq-0005Hx-Ri for ged-emacs-devel@m.gmane.org; Wed, 22 Oct 2014 22:35:58 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50331) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xh7Fo-0006PC-IL for emacs-devel@gnu.org; Wed, 22 Oct 2014 21:31:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xh7Fi-0003o4-GH for emacs-devel@gnu.org; Wed, 22 Oct 2014 21:31:52 -0400 Original-Received: from smtp113.iad3a.emailsrvr.com ([173.203.187.113]:54477) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xh7Fi-0003no-Cs for emacs-devel@gnu.org; Wed, 22 Oct 2014 21:31:46 -0400 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp7.relay.iad3a.emailsrvr.com (SMTP Server) with ESMTP id 7C11F1801B5 for ; Wed, 22 Oct 2014 21:31:45 -0400 (EDT) X-Virus-Scanned: OK Original-Received: by smtp7.relay.iad3a.emailsrvr.com (Authenticated sender: scott-AT-directededge.com) with ESMTPSA id 3056518019A for ; Wed, 22 Oct 2014 21:31:45 -0400 (EDT) X-Sender-Id: scott@directededge.com Original-Received: from [192.168.0.245] ([UNAVAILABLE]. [91.64.6.34]) (using TLSv1 with cipher DHE-RSA-AES256-SHA) by 0.0.0.0:465 (trex/5.2.13); Thu, 23 Oct 2014 01:31:45 GMT X-Mailer: Apple Mail (2.1990.1) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 173.203.187.113 X-Mailman-Approved-At: Wed, 22 Oct 2014 22:35:46 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:175710 Archived-At: --Apple-Mail=_37C75C3A-9D89-47B8-96D5-918322113740 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Hi fellows =E2=80=94 In the recent release ns-antialias-text / mac-allow-anti-aliasing were = broken for Mac (they have no effect). I did a binary search through the = commits until I pinned it on this and the following commit: = https://gitorious.org/emacs-transition/review6/commit/61cf50507d6564d741c0= ec399b6a33fa248669a5 The patch was very simple =E2=80=94 it just needs to check the setting = again, and is attached for review. -Scott --Apple-Mail=_37C75C3A-9D89-47B8-96D5-918322113740 Content-Disposition: attachment; filename=emacs-fix-ns-antialias-text-mac-os.patch Content-Type: application/octet-stream; name="emacs-fix-ns-antialias-text-mac-os.patch" Content-Transfer-Encoding: 7bit commit 6ee23077cee8f619edd4c4ffccfdbcf976da6866 Author: Scott Wheeler Date: Thu Oct 23 03:13:14 2014 +0200 Check to see if the user has explicitly disabled anti-aliasing diff --git a/src/macfont.m b/src/macfont.m index 1bb3fb1..55b9a9f 100644 --- a/src/macfont.m +++ b/src/macfont.m @@ -2763,7 +2763,8 @@ macfont_draw (struct glyph_string *s, int from, int to, int x, int y, CGFloat advance_delta = 0; int y_draw = -s->ybase; int no_antialias_p = - (macfont_info->antialias == MACFONT_ANTIALIAS_OFF + (NILP (ns_antialias_text) + || macfont_info->antialias == MACFONT_ANTIALIAS_OFF || (macfont_info->antialias == MACFONT_ANTIALIAS_DEFAULT && font_size <= macfont_antialias_threshold)); --Apple-Mail=_37C75C3A-9D89-47B8-96D5-918322113740--