From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Paul W. Rankin" via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: src/nsterm.m: fix window tabbing on macOS Date: Sun, 6 Jun 2021 16:48:32 +1000 Message-ID: <2C0F466D-0FEB-439B-8049-D8EA5FC0B21B@bydasein.com> References: <9cdf9d6dc55ccd4894d758d3237b0be2@purelymail.com> <03FB7137-A02D-4B94-AF1F-8B7E84DEF5DB@bydasein.com> <39fa782b82e274d3e9c40e934df89d68@purelymail.com> <4cf0b73bcefc7d159881d368b3a4b7f5@purelymail.com> <228099F1-BAB6-4E3A-AD0F-FB4282817CEB@bydasein.com> <83mts3ikoa.fsf@gnu.org> Reply-To: "Paul W. Rankin" Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="Apple-Mail=_F440C1A0-65EE-4273-BFD0-9E26015BEB90" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5985"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Alan Third , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jun 06 08:50:04 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lpmbj-0001Jo-QT for ged-emacs-devel@m.gmane-mx.org; Sun, 06 Jun 2021 08:50:04 +0200 Original-Received: from localhost ([::1]:42520 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lpmbi-0002qg-S0 for ged-emacs-devel@m.gmane-mx.org; Sun, 06 Jun 2021 02:50:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48012) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lpmb0-0002AV-7M for emacs-devel@gnu.org; Sun, 06 Jun 2021 02:49:18 -0400 Original-Received: from sendmail.purelymail.com ([34.202.193.197]:45394) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lpmau-0004Ci-NK for emacs-devel@gnu.org; Sun, 06 Jun 2021 02:49:17 -0400 DKIM-Signature: a=rsa-sha256; b=xJgeOQMQdjdjgMMqHawKKPe597GhCQwfuE3b4SEDAM3yOhPkM7xCQZ1STWmDRuhgiDs3v6TrIFzIZpBTS1MTE4la5S0gSWDUmCY+9k+1LDr7pPjUp/ZJT+MoAJqhy93dZdf1HEhxhDicaDw9yoQ+A3CzK7PqRVdlUwzhooR//4TD0idytVoqnZNgucVhS1hQg09NbXKlGScYGmqICZ/DnSyAQMmOD8oE7j0atGNxEQVeWn9EQPs0oc7QsnJKNrWOwK/SXSuNXMZ0r2lyps0QpA171C8zwWBAXqDCAT9E9Gv4LxX1+yXkX1QXRTXvPL0Bd6H36voUMhRzOHyHR9B6iQ==; s=purelymail3; d=bydasein.com; v=1; bh=WEmdd7+iWFElQ0qnsyj5rAEH4pxllKGx+tMZKakV2V8=; h=Received:From:To; DKIM-Signature: a=rsa-sha256; b=a9GOpbfRZu4YOs3bl5IVeBZRNf1hc9iDQacbdQr3T8PXh2yvf4FnJ0hQokI3T8HIoocGgCJ5D8ZmV8AiHi11OuPXIbj1Y04qyDcsP5Veqfu5F1gA/THMu8wCvHX9wF1XEojcZw3iTbna8+lzxXirkwx6+yvzaZuBpUTdigIQwGLu2NFWA7xudUCqVkBOQbQjYh7LudMA9LYgntcKAq4uo1JaVfF7COpgqUVLTnmbut+N3OPkOAJtuP3/sBOKgbtvEctWuFjkMsS9XK1mcZZMpqSQLqnvrxQjAA58ck2lyxbgT4dJKAaXmQF6kcTLWbEmAA/iKEG01d8Sug3fYjMtIA==; s=purelymail3; d=purelymail.com; v=1; bh=WEmdd7+iWFElQ0qnsyj5rAEH4pxllKGx+tMZKakV2V8=; h=Feedback-ID:Received:From:To; Feedback-ID: 791:353:null:purelymail X-Pm-Original-To: emacs-devel@gnu.org Original-Received: by ip-172-30-0-124.ec2.internal (JAMES SMTP Server ) with ESMTPA ID 814298285; Sun, 06 Jun 2021 06:48:38 +0000 (UTC) In-Reply-To: <83mts3ikoa.fsf@gnu.org> X-Mailer: Apple Mail (2.3654.100.0.2.22) Received-SPF: pass client-ip=34.202.193.197; envelope-from=pwr@bydasein.com; helo=sendmail.purelymail.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270464 Archived-At: --Apple-Mail=_F440C1A0-65EE-4273-BFD0-9E26015BEB90 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On 6 Jun 2021, at 4:14 pm, Eli Zaretskii wrote: >=20 >> Feedback-ID: 791:353:null:purelymail >> Date: Sun, 6 Jun 2021 14:01:26 +1000 >> Cc: emacs-devel@gnu.org >> From: "Paul W. Rankin" via "Emacs development discussions." = >>=20 >> ++++ >> +** On macOS, Emacs now supports native tabs (available in macOS = 10.12 >> +and later). Native tabbing behavior is specified system-wide via >> +System Preferences, under under General > 'Prefer tabs when opening >> +documents'. In macOS versions 10.15 and earlier, this option is >> +located under Dock instead. Note that this feature is unrelated to = the >> +Emacs 'tab-bar-mode'. >=20 > Thanks. A minor nit: since NEWS is displayed in Outline mode, the > first sentence of any entry is its heading, and should not take more > than one line. If you have some details that make it longer, move > those details to the subsequent lines. For example: >=20 > ** On macOS, Emacs now supports native tabs. > These tabs are available in macOS 10.12 and later. > ... No problemo. Revised patch attached. --Apple-Mail=_F440C1A0-65EE-4273-BFD0-9E26015BEB90 Content-Disposition: attachment; filename=0001-src-nsterm.m-fix-window-tabbing-on-macOS.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-src-nsterm.m-fix-window-tabbing-on-macOS.patch" Content-Transfer-Encoding: quoted-printable =46rom=20b2a9842399c3eafccab1964764ad383a37f26b11=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20"Paul=20W.=20Rankin"=20=0A= Date:=20Sat,=208=20May=202021=2019:09:59=20+1000=0ASubject:=20[PATCH]=20= src/nsterm.m:=20fix=20window=20tabbing=20on=20macOS=0A=0A*=20= src/nsterm.m:=20remove=20NSWindowTabbingModeDisallowed=20to=20respect=0A=20= =20system-wide=20preferences=0A*=20etc/NEWS:=20add=20mention=20of=20= native=20tab=20support=20in=20macOS=20and=20where=0A=20=20to=20specify=20= system-wide=20setting=0A---=0A=20etc/NEWS=20=20=20=20=20|=208=20++++++++=0A= =20src/nsterm.m=20|=208=20--------=0A=202=20files=20changed,=208=20= insertions(+),=208=20deletions(-)=0A=0Adiff=20--git=20a/etc/NEWS=20= b/etc/NEWS=0Aindex=2032d7c4fe18..278cc5ea3c=20100644=0A---=20a/etc/NEWS=0A= +++=20b/etc/NEWS=0A@@=20-3110,6=20+3110,14=20@@=20The=20new=20variable=20= 'xwidget-webkit-download-dir'=20says=20where=20to=20download=20to.=0A=20= 'module-file-suffix'=20now=20has=20the=20value=20".dylib"=20on=20macOS,=20= but=20the=0A=20".so"=20suffix=20is=20supported=20as=20well.=0A=20=0A++++=0A= +**=20On=20macOS,=20Emacs=20now=20supports=20native=20tabs=20(in=20macOS=20= 10.12=20and=20later).=0A+Native=20tabbing=20behavior=20is=20specified=20= system-wide=20via=20System=0A+Preferences,=20under=20under=20General=20>=20= 'Prefer=20tabs=20when=20opening=0A+documents'.=20In=20macOS=20versions=20= 10.15=20and=20earlier,=20this=20option=20is=0A+located=20under=20Dock=20= instead.=20Note=20that=20this=20feature=20is=20unrelated=20to=20the=0A= +Emacs=20'tab-bar-mode'.=0A+=0A=20+++=0A=20**=20On=20MS-Windows,=20Emacs=20= can=20now=20toggle=20the=20IME.=0A=20A=20new=20function=20= 'w32-set-ime-open-status'=20can=20now=20be=20used=20to=20disable=0Adiff=20= --git=20a/src/nsterm.m=20b/src/nsterm.m=0Aindex=20bb20886ab1..5fd4885801=20= 100644=0A---=20a/src/nsterm.m=0A+++=20b/src/nsterm.m=0A@@=20-7628,14=20= +7628,6=20@@=20-=20(instancetype)=20initFrameFromEmacs:=20(struct=20= frame=20*)f=0A=20=20=20=20=20=20=20=20=20=20selector:@selector=20= (viewDidResize:)=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20= name:NSViewFrameDidChangeNotification=20object:nil];=0A=20=0A-=20=20/*=20= macOS=20Sierra=20automatically=20enables=20tabbed=20windows.=20=20We=20= can't=0A-=20=20=20=20=20allow=20this=20to=20be=20enabled=20until=20it's=20= available=20on=20a=20Free=20system.=0A-=20=20=20=20=20Currently=20it=20= only=20happens=20by=20accident=20and=20is=20buggy=20anyway.=20=20*/=0A= -#ifdef=20NS_IMPL_COCOA=0A-=20=20if=20([win=20respondsToSelector:=20= @selector(setTabbingMode:)])=0A-=20=20=20=20[win=20setTabbingMode:=20= NSWindowTabbingModeDisallowed];=0A-#endif=0A-=0A=20=20=20= ns_window_num++;=0A=20=20=20return=20self;=0A=20}=0A--=20=0A2.30.1=0A=0A= --Apple-Mail=_F440C1A0-65EE-4273-BFD0-9E26015BEB90--