From: "David Kågedal" <davidk@lysator.liu.se>
To: rms@gnu.org
Cc: emacs-devel@gnu.org
Subject: Re: Is this tempo.el patch correct?
Date: Fri, 9 Mar 2007 23:46:38 +0100 [thread overview]
Message-ID: <2B5FE2FA-5F8E-45AF-9CAD-56630730421B@lysator.liu.se> (raw)
In-Reply-To: <E1HPmbn-0000Yh-KC@fencepost.gnu.org>
9 mar 2007 kl. 22.26 skrev Richard Stallman:
> David K}gedal, author of tempo.el, seems not to be responding,
> so we are on our own unless someone can find a better way to
> contact him.
>
> Would someone please DTRT and then ack?
I'm sorry. I'm here, and I put your mail on the pile of things to
take care of RSN.
Since I haven't really done anything with tempo.el for ten years, it
takes a bit of mental effort to review patches. But I'll have a look
tomorrow.
> ------- Start of forwarded message -------
> To: emacs-pretest-bug@gnu.org
> From: Lawrence Mitchell <wence@gmx.li>
> Date: Fri, 02 Mar 2007 14:39:11 +0000
> MIME-Version: 1.0
> Content-Type: text/plain; charset=us-ascii
> Subject: r> insertion marker not handled correctly in tempo
> X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=failed
> version=3.0.4
>
>
> If you define a tempo template that includes the "r>" insertion
> marker, attempting to use that template results in an error that the
> function "r>" is undefined.
>
> This bug may be reproduced as follows:
>
> emacs -Q
>
> Evaluate:
>
> (progn
> (require 'tempo)
> (tempo-define-template
> "show-bug"
> '("Some string" n> (r> "body: ")))
> (setq debug-on-error t)
> (tempo-template-show-bug))
>
>
> The following patch fixes this problem in, I believe, the correct
> manner:
>
> Index: tempo.el
> ===================================================================
> RCS file: /sources/emacs/emacs/lisp/tempo.el,v
> retrieving revision 1.20.6.11
> diff -c -r1.20.6.11 tempo.el
> *** tempo.el 26 Jan 2007 06:15:15 -0000 1.20.6.11
> - --- tempo.el 2 Mar 2007 14:36:39 -0000
> ***************
> *** 352,357 ****
> - --- 352,364 ----
> (goto-char tempo-region-stop)
> (tempo-insert-prompt-compat
> (cdr element))))
> + ((and (consp element)
> + (eq (car element) 'r>)) (if on-region
> + (progn
> + (goto-char tempo-
> region-stop)
> + (indent-region (mark)
> (point) nil))
> + (tempo-insert-prompt-compat
> + (cdr element))))
> ((and (consp element)
> (eq (car element) 's)) (tempo-insert-named (car (cdr
> element))))
> ((and (consp element)
>
> Changelog entry:
>
> 2007-03-02 Lawrence Mitchell <wence@gmx.li>
>
> * tempo.el (tempo-insert): Deal with 'r> if it appears
> specified with a prompt argument.
>
>
> Cheers,
>
> Lawrence
>
> - --
> Lawrence Mitchell <wence@gmx.li>
>
>
> _______________________________________________
> emacs-pretest-bug mailing list
> emacs-pretest-bug@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug
> ------- End of forwarded message -------
>
--
David Kågedal
davidk@lysator.liu.se
next prev parent reply other threads:[~2007-03-09 22:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-09 21:26 Is this tempo.el patch correct? Richard Stallman
2007-03-09 22:46 ` David Kågedal [this message]
2007-03-11 4:23 ` Richard Stallman
2007-03-10 15:55 ` David Hansen
2007-03-10 20:00 ` Lawrence Mitchell
2007-03-11 20:00 ` Richard Stallman
-- strict thread matches above, loose matches on Subject: below --
2007-03-02 23:47 Richard Stallman
2007-03-11 13:29 ` David Kågedal
2007-03-12 1:27 ` Richard Stallman
2007-03-12 22:11 ` Kim F. Storm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2B5FE2FA-5F8E-45AF-9CAD-56630730421B@lysator.liu.se \
--to=davidk@lysator.liu.se \
--cc=emacs-devel@gnu.org \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).