From: David Reitter <david.reitter@gmail.com>
To: Francis Devereux <francis@devrx.org>
Cc: Adrian Robert <adrian.b.robert@gmail.com>,
4736@emacsbugs.donarmstrong.com, John Whitley <whitley@acm.org>,
emacs-devel@gnu.org
Subject: Re: 23.1; ns-antialias-text set to nil has no effect
Date: Sun, 14 Feb 2010 10:38:38 -0500 [thread overview]
Message-ID: <2A6D0821-4E99-48D0-A710-2D01006A09E4@gmail.com> (raw)
In-Reply-To: <B92EACBD-D004-40A8-8FAB-C5CB4EBBA76A@devrx.org>
[-- Attachment #1: Type: text/plain, Size: 1729 bytes --]
On Feb 14, 2010, at 8:31 AM, Francis Devereux wrote:
> On 17 Oct 2009, at 13:16, Adrian Robert wrote:
>
>> http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=4736
>
> I've also discovered that if I build Emacs as a 32 bit binary on 10.6 (the default is 64 bit on 10.6) with the following command then ns-antialias-text works. The commands I used to build are:
> LDFLAGS="-arch i386" CFLAGS="-g -O2 -arch i386 -march=core2" ../trunk/configure --build=i386-apple-darwin10.2.0 --with-ns && make -j2 && make install
ns_antialias_text is wrongly declared as an int instead of Lisp_Object, and the nonstandard pointer comparison to Qnil helped cover it up, I suppose. That also explains why it happened to work on 32bit. Try the patch below.
diff --git a/src/nsfont.m b/src/nsfont.m
index 934fefa..1b157ce 100644
--- a/src/nsfont.m
+++ b/src/nsfont.m
@@ -50,7 +50,7 @@ extern Lisp_Object Qnormal, Qbold, Qitalic, Qcondensed, Qexpanded;
static Lisp_Object Vns_reg_to_script;
static Lisp_Object Qapple, Qroman, Qmedium;
extern Lisp_Object Qappend;
-extern int ns_antialias_text;
+extern Lisp_Object ns_antialias_text;
extern float ns_antialias_threshold;
extern int ns_tmp_flags;
extern struct nsfont_info *ns_tmp_font;
@@ -1243,7 +1245,7 @@ nsfont_draw (struct glyph_string *s, int from, int to, int x, int y,
CGContextSetFont (gcontext, font->cgfont);
CGContextSetFontSize (gcontext, font->size);
- if (ns_antialias_text == Qnil || font->size <= ns_antialias_threshold)
+ if (NILP (ns_antialias_text) || font->size <= ns_antialias_threshold)
CGContextSetShouldAntialias (gcontext, 0);
else
CGContextSetShouldAntialias (gcontext, 1);
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 203 bytes --]
next prev parent reply other threads:[~2010-02-14 15:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <3D80FB40-724F-4789-8807-E1C8A8A40375@gmail.com>
2010-02-14 13:31 ` 23.1; ns-antialias-text set to nil has no effect Francis Devereux
2010-02-14 15:38 ` David Reitter [this message]
2010-02-14 16:01 ` Francis Devereux
2010-02-15 23:36 ` John Whitley
2010-02-25 20:40 ` Francis Devereux
2010-02-26 0:49 ` Chong Yidong
2010-02-27 20:42 ` Francis Devereux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2A6D0821-4E99-48D0-A710-2D01006A09E4@gmail.com \
--to=david.reitter@gmail.com \
--cc=4736@emacsbugs.donarmstrong.com \
--cc=adrian.b.robert@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=francis@devrx.org \
--cc=whitley@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).