From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: "Eli Zaretskii" Newsgroups: gmane.emacs.devel Subject: Re: [PATCHES] 21.3.50 for Cygwin: patch 5 Date: Sat, 04 Jan 2003 13:07:28 +0300 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <2950-Sat04Jan2003130727+0200-eliz@is.elta.co.il> References: <3E15B803.8080507@hekimian.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: main.gmane.org X-Trace: main.gmane.org 1041678741 23743 80.91.224.249 (4 Jan 2003 11:12:21 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Sat, 4 Jan 2003 11:12:21 +0000 (UTC) Cc: emacs-devel@gnu.org Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18UmE0-0006Ap-00 for ; Sat, 04 Jan 2003 12:12:20 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 18UmH4-0004Pm-00 for ; Sat, 04 Jan 2003 12:15:30 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18UmEr-0007iZ-08 for emacs-devel@quimby.gnus.org; Sat, 04 Jan 2003 06:13:13 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 18UmCH-0007O7-00 for emacs-devel@gnu.org; Sat, 04 Jan 2003 06:10:33 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 18UmC6-00071G-00 for emacs-devel@gnu.org; Sat, 04 Jan 2003 06:10:27 -0500 Original-Received: from gandalf.inter.net.il ([192.114.186.22]) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18UmBv-0006kd-00 for emacs-devel@gnu.org; Sat, 04 Jan 2003 06:10:12 -0500 Original-Received: from zaretsky ([80.230.235.33]) by gandalf.inter.net.il (Mirapoint Messaging Server MOS 3.2.1-GA) with ESMTP id ABX00064; Sat, 4 Jan 2003 13:10:04 +0200 (IST) Original-To: joseph.buehler@spirentcom.com X-Mailer: emacs 21.3.50 (via feedmail 8 I) and Blat ver 1.8.9 In-reply-to: <3E15B803.8080507@hekimian.com> (message from Joe Buehler on Fri, 03 Jan 2003 11:19:15 -0500) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:10458 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:10458 > Date: Fri, 03 Jan 2003 11:19:15 -0500 > From: Joe Buehler > > The problem is that _P is defined in the cygwin header files in a manner > that is incompatible with its usage above. It is one of a set of macros > used in code that classifies characters as white space, printable, etc.: Ouch! This IMHO warrants a bug report to Cygwin maintainers. > The above usage in pop.c does not seem correct to me -- aren't symbols > beginning with _ supposed to be reserved for the compilation system, to avoid > conflicts such as this one? That's true, except that _P is used in many libraries' header files to allow prototypes in ANSI compilers without breaking non-ANSI ones. Okay, if this is the case, please make the #undef _P thing conditioned on Cygwin. That would at least limit the effect of the change to the Cygwin build. I'd also suggest a comment there explaining why is this done, which mentions the use of _P in ctype.h macros.