From: Dmitry Gutov <dgutov@yandex.ru>
To: "Eli Zaretskii" <eliz@gnu.org>, "Óscar Fuentes" <ofv@wanadoo.es>
Cc: emacs-devel@gnu.org
Subject: Re: [External] : Re: command mode-specificity [was: scratch/command 064f146 1/2: Change...]
Date: Wed, 17 Feb 2021 17:59:26 +0200 [thread overview]
Message-ID: <2943d7ae-84fd-7762-609e-9e4afcbf4c8d@yandex.ru> (raw)
In-Reply-To: <83mtw27l21.fsf@gnu.org>
On 17.02.2021 17:47, Eli Zaretskii wrote:
> If the implementation were to change, such that it didn't actually
> remove commands from the list of completion candidate, then perhaps we
> could make this the default (but even then I'm not sure).
What if we remove them from the list of completions, but still allow
them if the user typed one out explicitly and pressed RET?
Like this:
diff --git a/lisp/simple.el b/lisp/simple.el
index 215f4399f4..b2ae560c45 100644
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -1967,7 +1967,9 @@ read-extended-command
'(metadata
(affixation-function . read-extended-command--affixation)
(category . command))
- (complete-with-action action obarray string pred)))
+ (complete-with-action action obarray string
+ (unless (eq action 'lambda)
+ pred))))
(lambda (sym)
(and (commandp sym)
(funcall read-extended-command-predicate sym buffer)))
next prev parent reply other threads:[~2021-02-17 15:59 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 19:50 command mode-specificity [was: scratch/command 064f146 1/2: Change...] Drew Adams
2021-02-16 19:54 ` Stefan Monnier
2021-02-16 20:23 ` [External] : " Drew Adams
2021-02-16 20:53 ` Lars Ingebrigtsen
2021-02-16 22:05 ` Drew Adams
2021-02-16 22:15 ` Lars Ingebrigtsen
2021-02-16 22:31 ` Drew Adams
2021-02-16 22:38 ` Lars Ingebrigtsen
2021-02-16 23:22 ` Drew Adams
2021-02-17 0:35 ` Óscar Fuentes
2021-02-17 15:47 ` Eli Zaretskii
2021-02-17 15:59 ` Dmitry Gutov [this message]
2021-02-17 16:15 ` Stefan Monnier
2021-02-17 16:17 ` Eli Zaretskii
2021-02-17 19:52 ` Dmitry Gutov
2021-02-17 20:21 ` Eli Zaretskii
2021-02-17 22:05 ` Dmitry Gutov
2021-02-17 17:36 ` Óscar Fuentes
2021-02-17 18:44 ` Drew Adams
2021-02-17 17:57 ` Drew Adams
2021-02-17 2:39 ` Yuan Fu
2021-02-17 3:22 ` Eli Zaretskii
2021-02-17 0:13 ` Óscar Fuentes
2021-02-17 0:17 ` Drew Adams
2021-02-17 0:54 ` Óscar Fuentes
2021-02-17 18:11 ` Drew Adams
2021-02-17 18:40 ` Stefan Kangas
2021-02-17 19:01 ` Drew Adams
2021-02-17 20:09 ` Yuan Fu
2021-02-17 22:31 ` Lars Ingebrigtsen
2021-02-17 0:40 ` Stefan Monnier
2021-02-17 0:59 ` Óscar Fuentes
2021-02-17 11:20 ` Lars Ingebrigtsen
2021-02-17 14:01 ` Stefan Monnier
2021-02-17 14:19 ` Lars Ingebrigtsen
2021-02-17 15:20 ` Stefan Monnier
2021-02-17 15:42 ` Lars Ingebrigtsen
2021-02-17 16:12 ` Stefan Monnier
2021-02-17 18:26 ` Lars Ingebrigtsen
2021-02-17 18:47 ` Drew Adams
2021-02-17 18:41 ` Drew Adams
2021-02-17 18:28 ` Drew Adams
2021-02-17 16:07 ` Eli Zaretskii
2021-02-17 19:30 ` Lars Ingebrigtsen
2021-02-17 20:07 ` Eli Zaretskii
2021-02-17 21:00 ` Óscar Fuentes
2021-02-18 11:33 ` Lars Ingebrigtsen
2021-02-18 14:37 ` Eli Zaretskii
2021-02-18 15:53 ` Lars Ingebrigtsen
2021-02-20 13:30 ` Lars Ingebrigtsen
2021-02-20 14:43 ` Stefan Monnier
2021-02-20 14:52 ` Lars Ingebrigtsen
2021-02-20 18:00 ` Dmitry Gutov
2021-02-21 13:10 ` Lars Ingebrigtsen
2021-02-21 19:57 ` Dmitry Gutov
2021-02-19 12:09 ` [External] : " Lars Ingebrigtsen
2021-02-19 12:27 ` Eli Zaretskii
2021-02-18 16:30 ` Alan Mackenzie
2021-02-18 16:55 ` Óscar Fuentes
2021-02-18 17:08 ` Alan Mackenzie
2021-02-18 17:20 ` Óscar Fuentes
2021-02-18 17:35 ` Alan Mackenzie
2021-02-18 17:55 ` Robert Pluim
2021-02-18 18:15 ` Yuan Fu
2021-02-19 8:47 ` Robert Pluim
2021-02-19 8:55 ` Eli Zaretskii
2021-02-19 11:21 ` Robert Pluim
2021-02-19 12:25 ` Eli Zaretskii
2021-02-18 18:15 ` Alan Mackenzie
2021-02-18 19:32 ` Óscar Fuentes
2021-02-18 20:14 ` Alan Mackenzie
2021-02-18 20:24 ` Eli Zaretskii
2021-02-18 19:42 ` Eli Zaretskii
2021-02-18 19:57 ` Alan Mackenzie
2021-02-18 20:04 ` Eli Zaretskii
2021-02-19 12:10 ` Lars Ingebrigtsen
2021-02-19 12:41 ` Dmitry Gutov
2021-02-19 12:57 ` Lars Ingebrigtsen
2021-02-19 13:12 ` Dmitry Gutov
2021-02-17 19:02 ` Yuan Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2943d7ae-84fd-7762-609e-9e4afcbf4c8d@yandex.ru \
--to=dgutov@yandex.ru \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=ofv@wanadoo.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).