Problems due to grep.el introduction

Problems due to grep.el introduction

[Eli Zaretskii]

Since the `grep' command and related functions are now on a separate
file grep.el, unbundled Lisp packages that used `grep'-related
features will become broken if they require `compile' and rely on
`grep'-related variables and functions to become defined as a result.
Moreover, the fact that grep.el was added is not even mentioned in
NEWS, AFAICS.

(I bumped into this when I installed ID-utils on a machine with a
relatively recent CVS snapshot of Emacs, and found that "M-x gid"
barfs becaise grep-regex-alist is not defined.)

We definitely should mention grep.el in NEWS, but beyond that, I
wonder whether we should add to compile.el a series of calls to
`autoload' that would cause grep.el to be autoloaded whenever some
program that requires only compile references a `grep'-related
variable or function.  Like this, for example:

   (autoload 'grep-regex-alist "grep")

Comments?

Re: Problems due to grep.el introduction

[Andreas Schwab]

"Eli Zaretskii" <eliz@gnu.org> writes:

> We definitely should mention grep.el in NEWS, but beyond that, I
> wonder whether we should add to compile.el a series of calls to
> `autoload' that would cause grep.el to be autoloaded whenever some
> program that requires only compile references a `grep'-related
> variable or function.  Like this, for example:
>
>    (autoload 'grep-regex-alist "grep")
>
> Comments?

autoload doesn't work with variables.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: Problems due to grep.el introduction

[Eli Zaretskii]

> From: Andreas Schwab <schwab@suse.de>
> Date: Thu, 24 Jun 2004 10:51:03 +0200
> 
> >    (autoload 'grep-regex-alist "grep")
> >
> > Comments?
> 
> autoload doesn't work with variables.

So maybe the example was bad, but the original question still stands:
should we do that for some grep-* functions that were previously in
compile?

Re: Problems due to grep.el introduction

[Luc Teirlinck]

Eli Zaretskii wrote:

   > From: Andreas Schwab <schwab@suse.de>
   > Date: Thu, 24 Jun 2004 10:51:03 +0200
   > 
   > >    (autoload 'grep-regex-alist "grep")
   > >
   > > Comments?
   > 
   > autoload doesn't work with variables.

   So maybe the example was bad, but the original question still stands:
   should we do that for some grep-* functions that were previously in
   compile?

Why not just use autoload cookies in grep.el, rather than adding
autoloads to compile.el?  Those _do_ work for variables and many
functions and some user options in grep.el already have autoload
cookies.  Otherwise, the autoloads you add to compile.el will
eventually be duplicated in grep.el _anyway_.  For instance, that is
what wound up happening to 34 of the 38 similar "dired-aux autoloads"
in dired.el.  That caused plenty of trouble because the autoloads in
dired.el never got updated, resulting in obsolete docstrings being
displayed and the like.  I recently removed all 38 "dired-aux
autoloads" in dired and added 4 autoload cookies to dired-aux.

Sincerely,

Luc.

Re: Problems due to grep.el introduction

[Eli Zaretskii]

> Date: Thu, 24 Jun 2004 14:14:15 -0500 (CDT)
> From: Luc Teirlinck <teirllm@dms.auburn.edu>
> 
> Why not just use autoload cookies in grep.el, rather than adding
> autoloads to compile.el?

The reason I didn't suggest that was because those variables were not
autoloaded before the split.

But if this is the only practical solution, I don't mind.

Re: Problems due to grep.el introduction

[Eli Zaretskii]

> Date: Thu, 24 Jun 2004 14:14:15 -0500 (CDT)
> From: Luc Teirlinck <teirllm@dms.auburn.edu>
> 
> Why not just use autoload cookies in grep.el, rather than adding
> autoloads to compile.el?

Done.

Re: Problems due to grep.el introduction

[Kim F. Storm]

"Eli Zaretskii" <eliz@gnu.org> writes:

> Since the `grep' command and related functions are now on a separate
> file grep.el, unbundled Lisp packages that used `grep'-related
> features will become broken if they require `compile' and rely on
> `grep'-related variables and functions to become defined as a result.
> Moreover, the fact that grep.el was added is not even mentioned in
> NEWS, AFAICS.
> 
> (I bumped into this when I installed ID-utils on a machine with a
> relatively recent CVS snapshot of Emacs, and found that "M-x gid"
> barfs becaise grep-regex-alist is not defined.)
> 
> We definitely should mention grep.el in NEWS, 

I didn't think it would cause problems which is why I didn't document
it.  But it's not that trivial...

If some external package uses grep and does (require 'compile),
it is not sufficient just to change that into (require 'grep),
as that would break compatibility with pre 21.4 emacs which doesn't
have grep.el

For 21.4, the simplest fix would be to add (require 'grep)
at the end of compile.el -- after (provide 'compile).



-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

Re: Problems due to grep.el introduction

[Eli Zaretskii]

> From: storm@cua.dk (Kim F. Storm)
> Date: 24 Jun 2004 13:26:50 +0200
> 
> For 21.4, the simplest fix would be to add (require 'grep)
> at the end of compile.el -- after (provide 'compile).

But that would defeat the reason behind creating grep.el, won't it?

Re: Problems due to grep.el introduction

[Kim F. Storm]

"Eli Zaretskii" <eliz@gnu.org> writes:

> > From: storm@cua.dk (Kim F. Storm)
> > Date: 24 Jun 2004 13:26:50 +0200
> > 
> > For 21.4, the simplest fix would be to add (require 'grep)
> > at the end of compile.el -- after (provide 'compile).
> 
> But that would defeat the reason behind creating grep.el, won't it?

Not really.

In my mind, the primary reason for the split was to clarify the
interface between compile itself and the users of compile (such as
grep).  A secondary purpose was to be able to enhance those packages
independently (as have been done subsequently).

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk