unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Eli Zaretskii" <eliz@elta.co.il>
Cc: Karl Berry <karl@freefriends.org>
Subject: RMAIL against Texinfo
Date: Sun, 01 Feb 2004 19:16:02 +0200	[thread overview]
Message-ID: <2914-Sun01Feb2004191602+0200-eliz@elta.co.il> (raw)

Recently, I became annoyed by the fact that when I reply to a message
sent via texinfo-pretest or texinfo-help mailing lists, the list
address is somehow removed from the list of addressees to whom my
reply is sent.  After some debugging, it turned out that the default
value of rmail-dont-reply-to-names was this:

    "info-\\|eliz@elta\\.co\\.il>\\|eliz\\>"

And that "info-" thingie would remove texinfo-* lists from my replies!

That seems like a simple bug to me: the intent was to remove the
"info-*" mailing lists, which are essentially read-only (you are sent
information, but are not supposed to reply), so the regexp should
have been anchored at the beginning of a word, like this:

    "\\<info-\\|\\<eliz@elta\\.co\\.il\\>\\|\\<eliz\\>"

(I think my username and email addresses should get the same anchors,
to avoid filtering out someone whose username happens to be "noteliz",
for example.)

However, given that the code, both in rmail.el and in mail-utils.el,
which did this is VERY old, I'd like to ask if someone sees any bad
side effects from the changes I suggest below.

TIA

Index: lisp/mail/rmail.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/mail/rmail.el,v
retrieving revision 1.378
diff -u -r1.378 rmail.el
--- lisp/mail/rmail.el	30 Dec 2003 11:42:37 -0000	1.378
+++ lisp/mail/rmail.el	1 Feb 2004 17:18:49 -0000
@@ -139,9 +139,9 @@
   :group 'rmail-reply)
 
 ;;;###autoload
-(defvar rmail-default-dont-reply-to-names "info-" "\
-A regular expression specifying part of the value of the default value of
-the variable `rmail-dont-reply-to-names', for when the user does not set
+(defvar rmail-default-dont-reply-to-names "\\<info-" "\
+A regular expression specifying part of the default value of the
+variable `rmail-dont-reply-to-names', for when the user does not set
 `rmail-dont-reply-to-names' explicitly.  (The other part of the default
 value is the user's email address and name.)
 It is useful to set this variable in the site customization file.")


Index: lisp/mail/mail-utils.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/mail/mail-utils.el,v
retrieving revision 1.54
diff -u -r1.54 mail-utils.el
--- lisp/mail/mail-utils.el	1 Sep 2003 15:45:29 -0000	1.54
+++ lisp/mail/mail-utils.el	1 Feb 2004 17:19:39 -0000
@@ -216,9 +216,11 @@
                       "")
                     (if (and user-mail-address
                              (not (equal user-mail-address user-login-name)))
-                        (concat (regexp-quote user-mail-address) "\\|")
+                        (concat "\\<"
+				(regexp-quote user-mail-address)
+				"\\>\\|")
                       "")
-                    (concat (regexp-quote user-login-name) "\\>"))))
+                    (concat "\\<" (regexp-quote user-login-name) "\\>"))))
   ;; Split up DESTINATIONS and match each element separately.
   (let ((start-pos 0) (cur-pos 0)
 	(case-fold-search t))

             reply	other threads:[~2004-02-01 17:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-01 17:16 Eli Zaretskii [this message]
2004-02-01 21:51 ` RMAIL against Texinfo Kai Grossjohann
2004-02-02  5:59   ` Eli Zaretskii
2004-02-02  7:33     ` Kai Grossjohann
2004-02-02 19:04       ` Eli Zaretskii
2004-02-03  8:34         ` Kai Grossjohann
2004-02-03 10:13           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2914-Sun01Feb2004191602+0200-eliz@elta.co.il \
    --to=eliz@elta.co.il \
    --cc=karl@freefriends.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).