From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 9ed3685a77: Lots of refactorings and a few minor improvements. Date: Wed, 4 Jan 2017 10:23:10 -0800 Organization: UCLA Computer Science Department Message-ID: <28fe59fd-191f-64c0-2333-7462403d976c@cs.ucla.edu> References: <492.1483523991@eskebo.fritz.box> <4331.1483545171@eskebo.fritz.box> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1483554243 4336 195.159.176.226 (4 Jan 2017 18:24:03 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 4 Jan 2017 18:24:03 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 Cc: Emacs Development To: Stefan Merten , Tino Calancha , Kaushal Modi Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jan 04 19:23:58 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cOqE2-0008Dh-QM for ged-emacs-devel@m.gmane.org; Wed, 04 Jan 2017 19:23:50 +0100 Original-Received: from localhost ([::1]:40833 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cOqE7-0007Uz-0V for ged-emacs-devel@m.gmane.org; Wed, 04 Jan 2017 13:23:55 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45827) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cOqDY-0007Ud-Vd for Emacs-devel@gnu.org; Wed, 04 Jan 2017 13:23:22 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cOqDV-0000QH-Ru for Emacs-devel@gnu.org; Wed, 04 Jan 2017 13:23:20 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:50668) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cOqDV-0000P0-LM for Emacs-devel@gnu.org; Wed, 04 Jan 2017 13:23:17 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id D44FC1600A2; Wed, 4 Jan 2017 10:23:14 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id OVt9QheujYIp; Wed, 4 Jan 2017 10:23:13 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id E5E8E1600AA; Wed, 4 Jan 2017 10:23:13 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id eRHhjXldCFSq; Wed, 4 Jan 2017 10:23:13 -0800 (PST) Original-Received: from [192.168.1.9] (unknown [47.153.178.162]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id C554F1600A5; Wed, 4 Jan 2017 10:23:13 -0800 (PST) In-Reply-To: <4331.1483545171@eskebo.fritz.box> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:211105 Archived-At: Stefan Merten wrote: > I got the impression, that lately few people care about these rules I'm afraid that impression is incorrect. Many developers care (hence this= thread=20 :-). > See for example: > > http://git.savannah.gnu.org/cgit/emacs.git/commit/lisp/textmodes/rst.el= ?id=3D92e5b41c7c5898820356fc66456804a45bbe7852 > http://git.savannah.gnu.org/cgit/emacs.git/commit/lisp/textmodes/rst.el= ?id=3Dc61ee94959ba96b2a327df0684593f7e569e30be Those examples merely rename locals or adjust comments, and typically thi= s=20 doesn't need to be mentioned in ChangeLogs. Your changes did more than th= at. > I hope the commit message below is what you require. Much better, thanks. My main problem with it is that "Refactor by removin= g old=20 functions, introducing new functions and change existing functions" is to= o=20 vague. Please write for an audience that includes people who have code th= at=20 calls (say) rst-comment-region and want to know how to adjust the code af= ter=20 your changes to the API. At this point, by the way, the commit is done. We're talking about what y= ou=20 should do next time. (You can change the ChangeLog.3 file later if you li= ke, but=20 that's not urgent.)