From: Paul Eggert <eggert@cs.ucla.edu>
To: Stefan Merten <stefan@merten-home.de>,
Tino Calancha <tino.calancha@gmail.com>,
Kaushal Modi <kaushal.modi@gmail.com>
Cc: Emacs Development <Emacs-devel@gnu.org>
Subject: Re: [Emacs-diffs] master 9ed3685a77: Lots of refactorings and a few minor improvements.
Date: Wed, 4 Jan 2017 10:23:10 -0800 [thread overview]
Message-ID: <28fe59fd-191f-64c0-2333-7462403d976c@cs.ucla.edu> (raw)
In-Reply-To: <4331.1483545171@eskebo.fritz.box>
Stefan Merten wrote:
> I got the impression, that lately few people care about these rules
I'm afraid that impression is incorrect. Many developers care (hence this thread
:-).
> See for example:
>
> http://git.savannah.gnu.org/cgit/emacs.git/commit/lisp/textmodes/rst.el?id=92e5b41c7c5898820356fc66456804a45bbe7852
> http://git.savannah.gnu.org/cgit/emacs.git/commit/lisp/textmodes/rst.el?id=c61ee94959ba96b2a327df0684593f7e569e30be
Those examples merely rename locals or adjust comments, and typically this
doesn't need to be mentioned in ChangeLogs. Your changes did more than that.
> I hope the commit message below is what you require.
Much better, thanks. My main problem with it is that "Refactor by removing old
functions, introducing new functions and change existing functions" is too
vague. Please write for an audience that includes people who have code that
calls (say) rst-comment-region and want to know how to adjust the code after
your changes to the API.
At this point, by the way, the commit is done. We're talking about what you
should do next time. (You can change the ChangeLog.3 file later if you like, but
that's not urgent.)
next prev parent reply other threads:[~2017-01-04 18:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-04 2:27 [Emacs-diffs] master 9ed3685a77: Lots of refactorings and a few minor improvements Tino Calancha
2017-01-04 3:05 ` Paul Eggert
2017-01-04 13:56 ` Kaushal Modi
[not found] ` <492.1483523991@eskebo.fritz.box>
[not found] ` <4331.1483545171@eskebo.fritz.box>
2017-01-04 18:23 ` Paul Eggert [this message]
2017-01-07 10:45 ` Refactoring in rst.el (was: Re: [Emacs-diffs] master 9ed3685a77: Lots of refactorings and a few minor improvements.) Stefan Merten
2017-01-07 17:18 ` Refactoring in rst.el Paul Eggert
2017-01-14 15:18 ` Stefan Merten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28fe59fd-191f-64c0-2333-7462403d976c@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=Emacs-devel@gnu.org \
--cc=kaushal.modi@gmail.com \
--cc=stefan@merten-home.de \
--cc=tino.calancha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).