From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Use vtable for eww-bookmarks Date: Sun, 8 Dec 2024 20:52:44 -0800 Message-ID: <28ba395f-5c52-1fc8-a99a-9bae461520d8@gmail.com> References: <87ldx0vufd.fsf@sebasmonia.com> <8fde5a67-f778-f0c8-bcdd-ece08c95d369@gmail.com> <87h67nm4su.fsf@sebasmonia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30226"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Adam Porter , emacs-devel@gnu.org, eliz@gnu.org To: =?UTF-8?B?U2ViYXN0acOhbiBNb27DrWE=?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Dec 09 05:53:52 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tKVmK-0007lF-By for ged-emacs-devel@m.gmane-mx.org; Mon, 09 Dec 2024 05:53:52 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tKVlL-0001jD-J4; Sun, 08 Dec 2024 23:52:51 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tKVlJ-0001if-Hl for emacs-devel@gnu.org; Sun, 08 Dec 2024 23:52:49 -0500 Original-Received: from mail-pg1-x52f.google.com ([2607:f8b0:4864:20::52f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tKVlI-0002fZ-7E; Sun, 08 Dec 2024 23:52:49 -0500 Original-Received: by mail-pg1-x52f.google.com with SMTP id 41be03b00d2f7-7fd35b301bdso863217a12.2; Sun, 08 Dec 2024 20:52:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733719965; x=1734324765; darn=gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=MpacfrZA4hHDXrDKte+i/duZI3Xcrdo+wDVn9FDnQeA=; b=CnNDngbSBydN+npmqYnilvIKiH0UWCz9yKdxtoQIBM/zLjVtkmimhuqB3fGsQiAqRe XqSmfp+KcPbmEBuk3USTZeoabNxb3MkOkmFxAMRfa5H9064YDHIX21hm2LxwvU11X7vG C1dUuYsMf48x9VeYHvOHd2cIllzIYV7mk94hjc7rSxd/7RT66RW/1YzM7bXrP5ZISvap kyeTZB+6xf+UHWCCXGc5ub4SK+z0p0KqmMI8P24FApPCqPuVmpOLbmZoSCfyVGGWRuiY /COnVfAicGXcQLZnq+sCYhwj+/jFTuHx3NDYo39Gz9nQL9HzvoWAGeworlTCWp1Cmq/j Gi4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733719965; x=1734324765; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MpacfrZA4hHDXrDKte+i/duZI3Xcrdo+wDVn9FDnQeA=; b=SPv3FqwECwXvPYwLBUwqGQffhdtZojK7uNTcm5BObgTmCvFEzxA9seil0qg1Ycl5kJ B4LWAlVwViQwvfck4Cxbo7e8NsphXOU7xtsZyiUEnoaIPh1QlL8KhpU/TDYQFBHWRvbs 1MzC82jULbkmK1aRp+6DH2UHADgoL2XMTN5qo+zaVl099mgCLbTdaA8rN1GYsbTpUfeE JmUP2v1hnZ0CKQf7gO1nzd/wbWL+o8bftTVlr87rIvi9cN5bN920JyG4U1bTEon19KpD lDBxRYa6KnUX9GYydEUnBGcMdh5p55ZX+WZjn0v1GTRORrhmDMHnC5nMkNZs+0m5OV3w 4NCQ== X-Forwarded-Encrypted: i=1; AJvYcCWjB/6Nxf5Q++hJhKqXEuQLuTz1lZAuiiyJlen+NHIB7Prveo83dO7JeMpT6VOrJAlDL3T0vUr7SKEG134=@gnu.org, AJvYcCXVVd/pv7HjfNv0qXQxZqlnADadDLZ0Nyw4USu96WurtBUI6ykwU1JQa3Rri2J5SmPoc8mt@gnu.org X-Gm-Message-State: AOJu0YzoCDWwgYuPUuWG1rTZAcz+zySvvaS+USWQoKyFn44CWPDwS/OQ 4JYYArzii8duTOkhLIN/qXin57X1P5/DIV9iKcaEP8O42SCuHsil X-Gm-Gg: ASbGncsy7rZk3W97zgjtb7DJKEb+JorpNiYxqvfRJDYSG8Q01r5aZQbLfk2Maba69AX f/w5vS4bp7FVVvkN8yjXeRR4si6SuKE+mmqtAbpLIeBUPlL4KWVb8fWxB8K1qvkJilayjRLvmu2 v06VROH+plLJj6yqns4RmWcHcieca0eBr8CGrTCwJfbAVHw5sUPwIqVrX+R9A1ccszneizgOXkE EaLJfAzsJn8klxyL2UVDGzlHKH8bmZI5ZzKXCjjcFuCVz5YY+pPhNWWYTISMKXtjM4F3bMwOyxQ NKFamfDaypEE1m9lP8l7unAZgnw= X-Google-Smtp-Source: AGHT+IGBNOohKBTrM6S0oeX3kJ5JmSXMO7AA8EmMOxzs5aMgxY5T+7Zmx+479MMbrNZSWUM2pSJN0g== X-Received: by 2002:a05:6a21:6f01:b0:1e0:c1d5:f3ac with SMTP id adf61e73a8af0-1e187122793mr18213892637.32.1733719965364; Sun, 08 Dec 2024 20:52:45 -0800 (PST) Original-Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-725e82197e4sm1555172b3a.72.2024.12.08.20.52.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 08 Dec 2024 20:52:44 -0800 (PST) Content-Language: en-US In-Reply-To: <87h67nm4su.fsf@sebasmonia.com> Received-SPF: pass client-ip=2607:f8b0:4864:20::52f; envelope-from=jporterbugs@gmail.com; helo=mail-pg1-x52f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:326233 Archived-At: On 12/1/2024 2:12 PM, Sebastián Monía wrote: > Generalizing this feature can be challenging in that different types of > information could need very different handing. I think in this case, I'll defer to you and Adam (and Eli) about the best path forward here. The existing behavior is a bit odd, and since I don't use EWW's bookmarks, I don't have a good sense of the right way to improve things here. Or in other words, I don't have any objections to the code, but I'm not confident that I know enough about this corner to do a properly thorough review.