From: Jim Porter <jporterbugs@gmail.com>
To: "Sebastián Monía" <sebastian@sebasmonia.com>
Cc: Adam Porter <adam@alphapapa.net>, emacs-devel@gnu.org, eliz@gnu.org
Subject: Re: [PATCH] Use vtable for eww-bookmarks
Date: Sun, 8 Dec 2024 20:52:44 -0800 [thread overview]
Message-ID: <28ba395f-5c52-1fc8-a99a-9bae461520d8@gmail.com> (raw)
In-Reply-To: <87h67nm4su.fsf@sebasmonia.com>
On 12/1/2024 2:12 PM, Sebastián Monía wrote:
> Generalizing this feature can be challenging in that different types of
> information could need very different handing.
I think in this case, I'll defer to you and Adam (and Eli) about the
best path forward here. The existing behavior is a bit odd, and since I
don't use EWW's bookmarks, I don't have a good sense of the right way to
improve things here. Or in other words, I don't have any objections to
the code, but I'm not confident that I know enough about this corner to
do a properly thorough review.
next prev parent reply other threads:[~2024-12-09 4:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-05 22:53 [PATCH] Use vtable for eww-bookmarks Sebastián Monía
2024-11-06 12:21 ` Eli Zaretskii
2024-11-06 13:36 ` Sebastián Monía
2024-11-06 14:33 ` Eli Zaretskii
2024-11-06 14:43 ` Visuwesh
2024-11-06 16:52 ` Sebastián Monía
2024-11-06 20:49 ` Sebastián Monía
2024-11-07 2:00 ` Visuwesh
2024-11-07 2:00 ` Visuwesh
2024-11-20 19:27 ` Sebastián Monía
2024-11-11 7:38 ` Jim Porter
2024-11-23 19:12 ` Jim Porter
2024-11-27 20:02 ` Sebastián Monía
2024-11-28 19:49 ` Jim Porter
2024-12-01 5:33 ` Sebastián Monía
2024-12-01 6:39 ` Adam Porter
2024-12-01 16:17 ` Sebastián Monía
2024-12-01 19:31 ` Jim Porter
2024-12-01 22:12 ` Sebastián Monía
2024-12-09 4:52 ` Jim Porter [this message]
2024-12-10 19:16 ` Sebastián Monía
2024-12-12 4:15 ` Sebastián Monía
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28ba395f-5c52-1fc8-a99a-9bae461520d8@gmail.com \
--to=jporterbugs@gmail.com \
--cc=adam@alphapapa.net \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=sebastian@sebasmonia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).