From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Reitter Newsgroups: gmane.emacs.devel Subject: Re: visual-line-mode Date: Wed, 9 Jul 2008 10:31:08 -0400 Message-ID: <28B7F099-6A4E-4C02-B9FB-AC47188A2ABC@gmail.com> References: <87zlp4raab.fsf@catnip.gol.com> <87d4lzehq2.fsf@stupidchicken.com> <87skuqbwr8.fsf@stupidchicken.com> <85E9BC5B-7337-4CD4-A783-6B2FAEBAEBCA@gmail.com> <87tzf6c5il.fsf@stupidchicken.com> <87abgxx0ju.fsf@stupidchicken.com> <4D997CA8-A2ED-4E12-9F91-76E98AE95210@gmail.com> <87prpsjhre.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (Apple Message framework v926) Content-Type: multipart/signed; boundary=Apple-Mail-6--1064016678; micalg=sha1; protocol="application/pkcs7-signature" X-Trace: ger.gmane.org 1215620515 29558 80.91.229.12 (9 Jul 2008 16:21:55 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 9 Jul 2008 16:21:55 +0000 (UTC) Cc: Emacs-Devel devel , "Lennart Borgman \(gmail\)" , Stefan Monnier , Miles Bader To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 09 18:22:41 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KGcR0-0004w2-Ig for ged-emacs-devel@m.gmane.org; Wed, 09 Jul 2008 18:22:27 +0200 Original-Received: from localhost ([127.0.0.1]:57447 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KGcQ3-0001XV-JG for ged-emacs-devel@m.gmane.org; Wed, 09 Jul 2008 12:21:27 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KGcJn-0007bA-Go for emacs-devel@gnu.org; Wed, 09 Jul 2008 12:14:59 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KGcJl-0007aH-PT for emacs-devel@gnu.org; Wed, 09 Jul 2008 12:14:59 -0400 Original-Received: from [199.232.76.173] (port=39258 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KGcJl-0007a5-Eg for emacs-devel@gnu.org; Wed, 09 Jul 2008 12:14:57 -0400 Original-Received: from mx20.gnu.org ([199.232.41.8]:47455) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KGbMt-0004Nw-Dx for emacs-devel@gnu.org; Wed, 09 Jul 2008 11:14:08 -0400 Original-Received: from an-out-0708.google.com ([209.85.132.250]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KGahM-00017S-Jt for emacs-devel@gnu.org; Wed, 09 Jul 2008 10:31:12 -0400 Original-Received: by an-out-0708.google.com with SMTP id c38so549248ana.84 for ; Wed, 09 Jul 2008 07:31:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:cc:message-id:from:to :in-reply-to:content-type:mime-version:subject:date:references :x-mailer; bh=s2ygBBGEBZc0Cwvq8TOEZi4D8GblKbXb0g4ZJ4TtFmg=; b=rjbNATl7IroRHTLw7ybtqy/CDq6Nyy8PEsUJDO8vOKR7kiuCH3Js22bnaMLJUKBF0t 2fvZEw7NjczsM8j8MIeovZv0+bZZw7q404x6McEwN+KtFO2jKWIxeMDT2s36aX2Qin33 kawss1JrOl9MYBz9V2fJ2l7/0W69gi3ubkl38= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=cc:message-id:from:to:in-reply-to:content-type:mime-version:subject :date:references:x-mailer; b=QVXtO1JsJsMyqXCa/gbB/46j/Tfx+3J21/Wt6BPNb22h7Z6IGQNhmt8DvGcC8fFwpm L4PH6HVQC+Z5GGNu49doCoZlFHAIm6PVyGY4/Kodu7bo7zphPDucEhTU4cxuCDqVEi1v Sa+LgUqaqV6xFUNik3J9i8LcdbvO2jQKkRqYo= Original-Received: by 10.101.71.9 with SMTP id y9mr6350447ank.145.1215613871539; Wed, 09 Jul 2008 07:31:11 -0700 (PDT) Original-Received: from ?128.237.227.125? ( [128.237.227.125]) by mx.google.com with ESMTPS id c1sm6796950ana.26.2008.07.09.07.31.09 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 09 Jul 2008 07:31:10 -0700 (PDT) In-Reply-To: <87prpsjhre.fsf@stupidchicken.com> X-Mailer: Apple Mail (2.926) X-detected-kernel: by mx20.gnu.org: Linux 2.6 (newer, 2) X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:100487 Archived-At: --Apple-Mail-6--1064016678 Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit On 5 Jul 2008, at 19:41, Chong Yidong wrote: > > Good, I've checked it in (together with a couple other minor fixes). Can you post a patch for these minor fixes? I'm running this on 22 (because the trunk does not run on my system). At least in the previous version, there's also a problem with posn-x- y, which returns a position too far when given coordinates that are to the right of a word-wrapped line (i.e. in the blank space). This can also be seen if you just click into that space (mouse-set-point). I can post a detailed recipe after I've made sure I've got the up-to- date patch. My new code isn't iterative. It's faster and shouldn't lead to excessive garbage collections as before. > One thing that's not clear to me is whether your minor mode correctly > handles invisible/intangible text and point motion hooks. One of the > reasons line-move-1 and line-move-finish is so complicated is, > unfortunately, the need to DTRT for these. I don't see anything > analogous in your code; am I missing something? OK, I'll bind `inhibit-point-motion-hooks' except for the last movement command. Regarding invisible text, the original code went a long way to handle this efficiently. With the new method (I'll post some code soon), this is handled elegantly and without any hassle thanks to posn-x-y. Regarding intangible text, this works fine with my working version. I'm not sure about "fields", perhaps because I don't know much about their implementation. Can you point me to a test case? Customize buffers perhaps? Thanks for pointing out these issues. --Apple-Mail-6--1064016678 Content-Disposition: attachment; filename=smime.p7s Content-Type: application/pkcs7-signature; name=smime.p7s Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIFxDCCAn0w ggHmoAMCAQICEEfSZyInpN9bVdFPsdICbiIwDQYJKoZIhvcNAQEFBQAwYjELMAkGA1UEBhMCWkEx JTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQ ZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBMB4XDTA3MTIwOTIzMDM0OFoXDTA4MTIwODIzMDM0 OFowYjEQMA4GA1UEBBMHUmVpdHRlcjEOMAwGA1UEKhMFRGF2aWQxFjAUBgNVBAMTDURhdmlkIFJl aXR0ZXIxJjAkBgkqhkiG9w0BCQEWF2RhdmlkLnJlaXR0ZXJAZ21haWwuY29tMIGfMA0GCSqGSIb3 DQEBAQUAA4GNADCBiQKBgQDIS4kZGULD+CxprkxDnEccAnZ2GQQxfn55aiAPoy5kJ+uLhelaZP4p lgx3Vq8xYK1bjsLepGYp8qzVlHsyQPb6OfvRzrUXHxlJrHME0+Lblx37PBLxGDxc5W8qfZFJpej8 Dk3LUMga8laR9CRghbALoTV3UThUSMqk1cVwTY99KQIDAQABozQwMjAiBgNVHREEGzAZgRdkYXZp ZC5yZWl0dGVyQGdtYWlsLmNvbTAMBgNVHRMBAf8EAjAAMA0GCSqGSIb3DQEBBQUAA4GBAKU8XIS6 R/R3Hg6ae5p0i4iUJURq+sDVMX9RGB3Ge5V8oKKglIQGaY03leem65pqICL6mdgX/Px21JoaKVAA 8XITLFVEFHL6BfZ/eePnzNi93rnaNe7hLUwLdGztdYmqN8zF0DOCybL1M1JDB3cTr0XwHJwxziSf oEeENGNETykjMIIDPzCCAqigAwIBAgIBDTANBgkqhkiG9w0BAQUFADCB0TELMAkGA1UEBhMCWkEx FTATBgNVBAgTDFdlc3Rlcm4gQ2FwZTESMBAGA1UEBxMJQ2FwZSBUb3duMRowGAYDVQQKExFUaGF3 dGUgQ29uc3VsdGluZzEoMCYGA1UECxMfQ2VydGlmaWNhdGlvbiBTZXJ2aWNlcyBEaXZpc2lvbjEk MCIGA1UEAxMbVGhhd3RlIFBlcnNvbmFsIEZyZWVtYWlsIENBMSswKQYJKoZIhvcNAQkBFhxwZXJz b25hbC1mcmVlbWFpbEB0aGF3dGUuY29tMB4XDTAzMDcxNzAwMDAwMFoXDTEzMDcxNjIzNTk1OVow YjELMAkGA1UEBhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAq BgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBMIGfMA0GCSqGSIb3DQEB AQUAA4GNADCBiQKBgQDEpjxVc1X7TrnKmVoeaMB1BHCd3+n/ox7svc31W/Iadr1/DDph8r9RzgHU 5VAKMNcCY1osiRVwjt3J8CuFWqo/cVbLrzwLB+fxH5E2JCoTzyvV84J3PQO+K/67GD4Hv0CAAmTX p6a7n2XRxSpUhQ9IBH+nttE8YQRAHmQZcmC3+wIDAQABo4GUMIGRMBIGA1UdEwEB/wQIMAYBAf8C AQAwQwYDVR0fBDwwOjA4oDagNIYyaHR0cDovL2NybC50aGF3dGUuY29tL1RoYXd0ZVBlcnNvbmFs RnJlZW1haWxDQS5jcmwwCwYDVR0PBAQDAgEGMCkGA1UdEQQiMCCkHjAcMRowGAYDVQQDExFQcml2 YXRlTGFiZWwyLTEzODANBgkqhkiG9w0BAQUFAAOBgQBIjNFQg+oLLswNo2asZw9/r6y+whehQ5aU nX9MIbj4Nh+qLZ82L8D0HFAgk3A8/a3hYWLD2ToZfoSxmRsAxRoLgnSeJVCUYsfbJ3FXJY3dqZw5 jowgT2Vfldr394fWxghOrvbqNOUQGls1TXfjViF4gtwhGTXeJLHTHUb/XV9lTzGCAo8wggKLAgEB MHYwYjELMAkGA1UEBhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4x LDAqBgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBAhBH0mciJ6TfW1XR T7HSAm4iMAkGBSsOAwIaBQCgggFvMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcN AQkFMQ8XDTA4MDcwOTE0MzEwOFowIwYJKoZIhvcNAQkEMRYEFJpJvgCe0c659Uh1Et8J0U5cuXyx MIGFBgkrBgEEAYI3EAQxeDB2MGIxCzAJBgNVBAYTAlpBMSUwIwYDVQQKExxUaGF3dGUgQ29uc3Vs dGluZyAoUHR5KSBMdGQuMSwwKgYDVQQDEyNUaGF3dGUgUGVyc29uYWwgRnJlZW1haWwgSXNzdWlu ZyBDQQIQR9JnIiek31tV0U+x0gJuIjCBhwYLKoZIhvcNAQkQAgsxeKB2MGIxCzAJBgNVBAYTAlpB MSUwIwYDVQQKExxUaGF3dGUgQ29uc3VsdGluZyAoUHR5KSBMdGQuMSwwKgYDVQQDEyNUaGF3dGUg UGVyc29uYWwgRnJlZW1haWwgSXNzdWluZyBDQQIQR9JnIiek31tV0U+x0gJuIjANBgkqhkiG9w0B AQEFAASBgKYXS1NOOzIoVroP4dOdejt1jMNKUEa4s6kHUmo3Wk9MO7qnE/qeXaB+MS1cJC+ZjgHW oI8wrMmuHhDzPCLRzDHxArkhEqy1Q7cyUYnWujK9Z9LxPgXvZQbyB8L/jHVn/0FvJQLF82bwrXlo hQa9nnU8+mDWMRJ1xR6NyKi8r9tdAAAAAAAA --Apple-Mail-6--1064016678--