From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.devel Subject: Re: master d08c947: Make compilation-mode regexp matching case-sensitive (bug#40119) Date: Thu, 26 Mar 2020 17:25:02 +0100 Message-ID: <289F6919-4BA3-476D-AF78-390944A79624@acm.org> References: <20200325204155.5002.75177@vcs0.savannah.gnu.org> <20200325204157.3643820E43@vcs0.savannah.gnu.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.14\)) Content-Type: multipart/mixed; boundary="Apple-Mail=_2D30B329-9320-4923-AE5A-9E390E3DCE5F" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="53830"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Mar 26 18:11:04 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jHW24-000DsS-L8 for ged-emacs-devel@m.gmane-mx.org; Thu, 26 Mar 2020 18:11:04 +0100 Original-Received: from localhost ([::1]:56810 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jHW23-0003rR-Iy for ged-emacs-devel@m.gmane-mx.org; Thu, 26 Mar 2020 13:11:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39061) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jHW1S-0003DZ-Kl for emacs-devel@gnu.org; Thu, 26 Mar 2020 13:10:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jHW1R-00053g-4r for emacs-devel@gnu.org; Thu, 26 Mar 2020 13:10:26 -0400 Original-Received: from mail1475c50.megamailservers.eu ([91.136.14.75]:52352 helo=mail118c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jHW1P-0004z0-4M for emacs-devel@gnu.org; Thu, 26 Mar 2020 13:10:25 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1585239905; bh=Zuc5VqPPqj9FtXLjYLru7KqWLdj4GWMt5ac8HG2/JwE=; h=From:Subject:Date:In-Reply-To:Cc:To:References:From; b=W200bTYq8DsCjM1jitGLszszgVq4UkIgX4fVSR9Lllq6VlsyBX7RD3EEMWeztKd6v h3YtodrsKYIdzltGR5qtcmQeX/T+hgTwL68/vCz1af+b3Eeg5BOOkRE/ebhVD4Wl7w 7aIfsrXYjQFKVwU0dUyxn43RPBXkccGEYlvj/N1Y= Feedback-ID: mattiase@acm.or Original-Received: from stanniol.lan (c-6f4fe655.032-75-73746f71.bbcust.telenor.se [85.230.79.111]) (authenticated bits=0) by mail118c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 02QGP2us015483; Thu, 26 Mar 2020 16:25:04 +0000 In-Reply-To: X-Mailer: Apple Mail (2.3445.104.14) X-CTCH-RefID: str=0001.0A782F24.5E7CD741.007D, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=KaGsTjQD c=1 sm=1 tr=0 a=fHaj9vQUQVKQ4sUldAaXuQ==:117 a=fHaj9vQUQVKQ4sUldAaXuQ==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=M51BFTxLslgA:10 a=iRZporoAAAAA:8 a=R2EA26QSunhcKKd7iegA:9 a=fW0Pb-Bpu6cMkULV:21 a=Z4fk0WZcHrUIwyRa:21 a=CjuIK1q_8ugA:10 a=TQ5YWZ3wvtaOTh2gM0cA:9 a=B2y7HmGcmWMA:10 a=tclcd6dtLQvEqt9_mmAA:9 a=NOBgFS-JBQ2l-kSd6-zu:22 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] X-Received-From: 91.136.14.75 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:245813 Archived-At: --Apple-Mail=_2D30B329-9320-4923-AE5A-9E390E3DCE5F Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii 26 mars 2020 kl. 04.42 skrev Stefan Monnier : > Then let's make it into a simple `defvar` rather than a defcustom and > make the docstring clarify that it's only useful for temporary > backward compatibility. Right; patch attached. > In sml-mode.el (GNU ELPA) I set `compilation-error-screen-columns` > buffer-locally but it really should be rule-local. In tuareg-mode = (not > in GNU ELPA, sadly), I set both `compilation-first-column` and > `compilation-error-screen-columns` buffer-locally for the same reason. And here I've been staring at OCaml type errors for years and never = noticed... * Gcc and Clang also count characters rather than columns. (Bytes, in = fact. Perhaps we need a setting for that as well?) * Instead of making compilation-error-regexp-alist entries even more = complex and overloaded, perhaps we should use plists? For example, each = entry could be (REGEXP :file FILE :line LINE ...) Adding :first-column and :screen-columns would then be more a more = natural way of doing it. * There could be multiple tools with different column-number semantics = sharing a single pattern. * Rule-specific column-number semantics can be done today by specifying = a function as COLUMN parameter, so perhaps no extension is necessary. --Apple-Mail=_2D30B329-9320-4923-AE5A-9E390E3DCE5F Content-Disposition: attachment; filename=0001-Turn-compilation-error-case-fold-search-into-a-defva.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Turn-compilation-error-case-fold-search-into-a-defva.patch" Content-Transfer-Encoding: quoted-printable =46rom=20fb842363736881ad045764751d86aae6d1ee4abe=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D=20= =0ADate:=20Thu,=2026=20Mar=202020=2010:58:30=20+0100=0A= Subject:=20[PATCH]=20Turn=20compilation-error-case-fold-search=20into=20= a=20defvar=0A=0ASee=20discussion=20at=0A= https://lists.gnu.org/archive/html/emacs-devel/2020-03/msg00653.html=0A=0A= *=20lisp/progmodes/compile.el=20(compilation-error-case-fold-search):=0A= Turn=20into=20a=20defvar.=0A*=20etc/NEWS:=20Update.=0A---=0A=20etc/NEWS=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20|=20=206=20++++--=0A=20= lisp/progmodes/compile.el=20|=2010=20++++++----=0A=202=20files=20= changed,=2010=20insertions(+),=206=20deletions(-)=0A=0Adiff=20--git=20= a/etc/NEWS=20b/etc/NEWS=0Aindex=20910d9fa2d2..6569158f70=20100644=0A---=20= a/etc/NEWS=0A+++=20b/etc/NEWS=0A@@=20-199,8=20+199,10=20@@=20Defaults=20= to=20Libravatar,=20with=20Unicornify=20and=20Gravatar=20as=20options.=0A=20= **=20Compilation=20mode=0A=20=0A=20***=20Regexp=20matching=20of=20= messages=20is=20now=20case-sensitive=20by=20default.=0A-The=20user=20= option=20'compilation-error-case-fold-search'=20can=20be=20set=0A-for=20= case-insensitive=20matching=20of=20messages.=0A+The=20variable=20= 'compilation-error-case-fold-search'=20can=20be=20set=20for=0A= +case-insensitive=20matching=20of=20messages=20when=20the=20old=20= behaviour=20is=0A+required,=20but=20the=20recommended=20solution=20is=20= to=20use=20a=20correctly=20matching=0A+regexp=20instead.=0A=20=0A=20=0C=0A= =20*=20New=20Modes=20and=20Packages=20in=20Emacs=2028.1=0Adiff=20--git=20= a/lisp/progmodes/compile.el=20b/lisp/progmodes/compile.el=0Aindex=20= f4532b7edb..e5878b28f9=20100644=0A---=20a/lisp/progmodes/compile.el=0A= +++=20b/lisp/progmodes/compile.el=0A@@=20-646,13=20+646,15=20@@=20= compilation-error-regexp-alist=0A=20=20=20:link=20`(file-link=20:tag=20= "example=20file"=0A=20=09=09=20=20=20=20,(expand-file-name=20= "compilation.txt"=20data-directory)))=0A=20=0A-(defcustom=20= compilation-error-case-fold-search=20nil=0A+(defvar=20= compilation-error-case-fold-search=20nil=0A=20=20=20"If=20non-nil,=20use=20= case-insensitive=20matching=20of=20compilation=20errors=0A=20by=20the=20= regexps=20of=20`compilation-error-regexp-alist'=20and=0A=20= `compilation-error-regexp-alist-alist'.=0A-If=20nil,=20matching=20is=20= case-sensitive."=0A-=20=20:type=20'boolean=0A-=20=20:version=20"28.1")=0A= +If=20nil,=20matching=20is=20case-sensitive.=0A+=0A+This=20variable=20= should=20only=20be=20set=20for=20backward=20compatibility=20as=20a=20= temporary=0A+measure.=20=20The=20proper=20solution=20is=20to=20use=20a=20= regexp=20that=20matches=20the=0A+messages=20without=20case-folding.")=0A=20= =0A=20;;;###autoload(put=20'compilation-directory=20'safe-local-variable=20= 'stringp)=0A=20(defvar=20compilation-directory=20nil=0A--=20=0A2.21.1=20= (Apple=20Git-122.3)=0A=0A= --Apple-Mail=_2D30B329-9320-4923-AE5A-9E390E3DCE5F Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii --Apple-Mail=_2D30B329-9320-4923-AE5A-9E390E3DCE5F--