From: Dmitry Gutov <dgutov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>
Cc: stephen.berman@gmx.net, emacs-devel@gnu.org
Subject: Re: dired-do-find-regexp failure with latin-1 encoding
Date: Sun, 29 Nov 2020 21:48:04 +0200 [thread overview]
Message-ID: <284dc041-6b3b-9f9f-aba1-04b7d79d6360@yandex.ru> (raw)
In-Reply-To: <83h7p8knso.fsf@gnu.org>
On 29.11.2020 20:42, Eli Zaretskii wrote:
>> Cc: stephen.berman@gmx.net, emacs-devel@gnu.org
>> From: Dmitry Gutov <dgutov@yandex.ru>
>> Date: Sun, 29 Nov 2020 19:32:17 +0200
>>
>> If the calls to the conversion program are done in parallel to the
>> subsequent searches, reading the file twice might not be a problem (with
>> the benefit of a disk cache).
>
> How do you mean "in parallel"? You cannot start searching until you
> decide on the encoding, so it must not be in parallel.
Since we're passing multiple files to Grep or RG at the same time, it
could start deciding on the encoding of the next file while still
searching the previous one.
>>>> How does Emacs do it? Does it read until the end of the file?
>>>
>>> No, just a small initial part of it. That's one reason why the
>>> results are not guaranteed to be correct.
>>
>> But if we consider that approach good enough for Emacs, it should
>> probably be good enough for doing a search from inside Emacs.
>
> It's good enough when the encoding is the locale's codeset, and in a
> few other (not very important) cases. For an arbitrary combination of
> file's encoding and locale's codeset, the result can be wrong every
> single time.
>
> And searching in non-ASCII files whose encoding is not the locale's
> native one is precisely the case where this will fail. Granted, it's
> a relatively rare use case, but when it does happen, all bets are off.
Which will likely have affected the user (who is foremost an Emacs user)
already, before he/did the search.
> So reading just a small part, as Emacs does, will yield similar
> percentage of wrong guesses.
...so that seems like a good thing.
Anyway, that should work but you don't seem to be crazy about the
approach, and I'm not in love with the potential implementation. So
maybe we should stop and let it brew for a little while.
next prev parent reply other threads:[~2020-11-29 19:48 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-28 18:03 dired-do-find-regexp failure with latin-1 encoding Stephen Berman
2020-11-28 18:11 ` Eli Zaretskii
2020-11-28 18:46 ` Stephen Berman
2020-11-28 19:13 ` Eli Zaretskii
2020-11-28 19:44 ` Stephen Berman
2020-11-28 19:49 ` Eli Zaretskii
2020-11-28 20:16 ` Dmitry Gutov
2020-11-28 20:29 ` Eli Zaretskii
2020-11-28 21:04 ` Dmitry Gutov
2020-11-29 0:49 ` Dmitry Gutov
2020-11-29 15:19 ` Eli Zaretskii
2020-11-29 16:27 ` Dmitry Gutov
2020-11-29 17:18 ` Eli Zaretskii
2020-11-29 17:32 ` Dmitry Gutov
2020-11-29 18:42 ` Eli Zaretskii
2020-11-29 19:48 ` Dmitry Gutov [this message]
2020-11-29 15:06 ` Eli Zaretskii
2020-11-29 15:14 ` Yuri Khan
2020-11-29 15:36 ` Stephen Berman
2020-11-29 15:50 ` Eli Zaretskii
2020-11-29 16:07 ` Dmitry Gutov
2020-11-29 17:12 ` Eli Zaretskii
2020-11-29 17:19 ` Dmitry Gutov
2020-11-29 17:25 ` Eli Zaretskii
2020-11-29 17:44 ` Dmitry Gutov
2020-11-29 18:51 ` Eli Zaretskii
2020-11-29 19:07 ` Dmitry Gutov
2020-11-29 19:32 ` Eli Zaretskii
2020-11-29 19:34 ` Eli Zaretskii
2020-11-29 19:49 ` Stephen Berman
2020-11-29 19:49 ` Gregory Heytings via Emacs development discussions.
2020-11-29 19:37 ` Juri Linkov
2020-11-30 1:08 ` Dmitry Gutov
2020-11-30 20:54 ` Juri Linkov
2020-12-01 0:34 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=284dc041-6b3b-9f9f-aba1-04b7d79d6360@yandex.ru \
--to=dgutov@yandex.ru \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=stephen.berman@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).