From: "Rüdiger Sonderfeld" <ruediger@c-plusplus.de>
To: Leo Liu <sdl.web@gmail.com>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>,
"emacs-devel@gnu.org" <emacs-devel@gnu.org>
Subject: Re: [PATCH 3/3] octave.el: Go to error in inferior-octave.
Date: Thu, 03 Oct 2013 15:39:14 +0200 [thread overview]
Message-ID: <2832315.j8Ubslmhy0@descartes> (raw)
In-Reply-To: <97BF0F35-1CB8-411A-9B47-803CF33130CF@gmail.com>
On Thursday 03 October 2013 12:07:55 Leo Liu wrote:
> On 2013年10月3日, at 11:57, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
> > The way to do that is to use compilation-shell-minor-mode.
> > See how it's used in prolog.el, for example,
> >
> > Stefan
>
> Agree I have that in my local copy and will commit ASAP. - Leo
>
> Sent from my iPhone 4S
Oh, I was looking for something like `compilation-shell-minor-mode' yesterday
but must have missed it. This should probably make patches 1 and 3 obsolete.
But I think patch 2 is still valid. Comint is already having highlight for
the prompt and adding our own highlight in octave.el is not necessary and just
confusing.
Regards,
Rüdiger
next prev parent reply other threads:[~2013-10-03 13:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-02 20:39 [PATCH 3/3] octave.el: Go to error in inferior-octave Rüdiger Sonderfeld
2013-10-03 3:57 ` Stefan Monnier
2013-10-03 4:07 ` Leo Liu
2013-10-03 13:39 ` Rüdiger Sonderfeld [this message]
2013-10-04 10:04 ` Leo Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2832315.j8Ubslmhy0@descartes \
--to=ruediger@c-plusplus.de \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=sdl.web@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).