From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: message-mode toolbars, was: Re: "Why is emacs so square?" Date: Fri, 24 Apr 2020 06:25:30 +0300 Message-ID: <279c7ae5-b6c4-827b-393f-9ab34fbda81a@yandex.ru> References: <8wXYP4GY9hwW-9mYv6_LGMETZ8Vz3Ob1Bec6yh6kPT7yxjTkxA3V6dXY4ELra9tYiJUxJmgXKSIEX4w8HFiPRoeGVSQHDSoBVy1voj1e3Qo=@protonmail.com> <833694f29y.fsf@gnu.org> <4amRIW9fznS6sa3th4xPABzua9LQDlNPeIFxVsGYdq_wsg4-Ea1l9sEP-T6QrnO5QMV3jhgrnAspk2mSIC7COlodqr04koAcIPYPLLmPHFM=@protonmail.com> <83imhzecc5.fsf@gnu.org> <83y2qvcjv6.fsf@gnu.org> <83k12ed20s.fsf@gnu.org> <83blnqctyj.fsf@gnu.org> <9341072a-cf53-9092-2211-aa97c946e5b1@yandex.ru> <838sinfygb.fsf@gnu.org> <16fad982-e95b-7df1-25d0-1c666a6f8120@gmail.com> <83tv1begq5.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="87451"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 Cc: Lars Magne Ingebrigtsen , emacs-devel@gnu.org To: =?UTF-8?Q?Cl=c3=a9ment_Pit-Claudel?= , Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Apr 24 05:26:47 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jRozH-000Mek-5X for ged-emacs-devel@m.gmane-mx.org; Fri, 24 Apr 2020 05:26:47 +0200 Original-Received: from localhost ([::1]:48296 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jRozG-00026I-91 for ged-emacs-devel@m.gmane-mx.org; Thu, 23 Apr 2020 23:26:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56072) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jRoy9-0000qK-P1 for emacs-devel@gnu.org; Thu, 23 Apr 2020 23:25:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jRoy8-0006WP-QC for emacs-devel@gnu.org; Thu, 23 Apr 2020 23:25:37 -0400 Original-Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]:38666) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jRoy8-0006Aq-Ay; Thu, 23 Apr 2020 23:25:36 -0400 Original-Received: by mail-wr1-x42a.google.com with SMTP id x17so8273489wrt.5; Thu, 23 Apr 2020 20:25:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=QHqHCxR7p1V6Ao+tau8yDMD4AvgFNK6mMhUq2uVP+mk=; b=lvF9IRxB0ewk1h5yDA3ntMXcZOsIunqRrs1Uj4Lj2T38ueg6afUoAg6WDs8LCEzs4J fjff8hWjJArT7hPlwMny6W01cPWWQuLTnEq1bvV4mVZsBuM3tRz+PS3RL/gWqbUjzEpx EfN/eQf547NGzC0qvhSZoA9D72sPViyGE+iJlIvk9reoYsdnlqUefx+G9Aes6aUih1iL XP/FcMjkwLbRioTohgMYelbu2loaWnBvO+ffS/zs0i3f7gowPnXcgHDs7FC6rO8CSvTC hSwo97uHyJpjz6+RdJnYSJRRWy3tCCjJhZY8FTsfVzpiOjitzJA7tyMpsoqYZukV0Oss uRwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=QHqHCxR7p1V6Ao+tau8yDMD4AvgFNK6mMhUq2uVP+mk=; b=neHdzxZ3LTM/G1CL+GIcUzzBaZXe04HLROml+KQZTOkSCwdr72TRXoqXfR4SaclvpI UxWWCHBHFaYLeCsYoCpa5NWPTwbZLFqoFBS1RwBUKGpDOQAWx+VYYZimm+Ts7GEjnS0f LY2g1y3lM/L48/su1ffxj7KX4BlNezRV3ixgoqdPKyQHVebRlkAQ0sd4HFxgb/mJlY0c /nPkjOuf7ikAQZr5KADgAV6HAqi4B1Cw8eXlHhvOGMzMYWDup1vLiVwW+Okx2VXYV5MP kozWjX2v78rdhl6QLkXmL2r0/4LtQotcDMjx4j8JMyPuZ1jfZWajc+K5CGnQSjJYqtM2 q2iA== X-Gm-Message-State: AGi0PuYUe87FUhG4f+CHNWsAwBknIDSeDweUpE3T9ej9QVNVBH6LYGve 8n8v9GiZ1hWlQZvSD8ov2is= X-Google-Smtp-Source: APiQypKcvDTLUxH6No2H/wLOZ4CaFeffUzp+G0+3Dfnk6Bh0bCKAvxXVX3D2HV+KHMCOP5QWc2p3vw== X-Received: by 2002:a5d:4ac6:: with SMTP id y6mr8306618wrs.212.1587698734246; Thu, 23 Apr 2020 20:25:34 -0700 (PDT) Original-Received: from [192.168.0.2] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id u127sm962532wme.8.2020.04.23.20.25.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Apr 2020 20:25:33 -0700 (PDT) In-Reply-To: Content-Language: en-US Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=raaahh@gmail.com; helo=mail-wr1-x42a.google.com X-detected-operating-system: by eggs.gnu.org: Error: [-] PROGRAM ABORT : Malformed IPv6 address (bad octet value). Location : parse_addr6(), p0f-client.c:67 X-Received-From: 2a00:1450:4864:20::42a X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:247660 Archived-At: On 22.04.2020 18:17, Clément Pit-Claudel wrote: > IIUC, the claim is that there (likely) are standard icons close to the ones we use, and that using the corresponding icon names would give us good-looking icons by default on Gtk. > Concretely, for the actions shown in the message toolbar, this would be these: > > mail-attachment > document-send or mail-send > tools-check-spelling > mail-mark-important Thanks for the list. Below is a patch that makes use of it. > The spec doesn't seem to have actions for marking an email unimportant or requesting an email receipt. Unfortunately, it doesn't. Nothing for "save-draft" either, but we're currently using the "gtk-close" icon for that. Also, I dug a little deeper into that rabbit hole, and turns out, Gnus normally defines two sets of icons for its toolbars. The first is called "gnome", and the other is "retro". And in 2016 the relevant check was reverted (commit d88118db37d), so we've been using the "retro" version since. I'm guessing Lars doesn't use GTK or toolbars at all. It seems the two versions of toolbars have diverged in contents too, so aside from reverting a part of that commit, someone will need to do the work of merging them. Hopefully into one. Anyway, here's the patch improving the icons a little: diff --git a/lisp/gnus/message.el b/lisp/gnus/message.el index adefa0efd6..bb6a55dc80 100644 --- a/lisp/gnus/message.el +++ b/lisp/gnus/message.el @@ -7969,7 +7969,7 @@ message-tool-bar-gnome (mml-attach-file "attach" mml-mode-map :vert-only t) (mml-preview "mail/preview" mml-mode-map) (mml-secure-message-sign-encrypt "lock" mml-mode-map :visible nil) - (message-insert-importance-high "important" nil :visible nil) + (message-insert-importance-high "mail/important" nil :visible nil) (message-insert-importance-low "unimportant" nil :visible nil) (message-insert-disposition-notification-to "receipt" nil :visible nil)) "List of items for the message tool bar (GNOME style). diff --git a/lisp/term/x-win.el b/lisp/term/x-win.el index 5b8feb14a5..865a8bd4c5 100644 --- a/lisp/term/x-win.el +++ b/lisp/term/x-win.el @@ -1413,7 +1413,7 @@ x-gtk-stock-map ("etc/images/info" . ("dialog-information" "gtk-info")) ("etc/images/bookmark_add" . "n:bookmark_add") ;; Used in Gnus and/or MH-E: - ("etc/images/attach" . "gtk-attach") + ("etc/images/attach" . ("mail-attachment" "gtk-attach")) ("etc/images/connect" . "gtk-connect") ("etc/images/contact" . "gtk-contact") ("etc/images/delete" . ("edit-delete" "gtk-delete")) @@ -1431,18 +1431,20 @@ x-gtk-stock-map ("etc/images/sort-descending" . ("view-sort-descending" "gtk-sort-descending")) ("etc/images/sort-row-ascending" . "gtk-sort-row-ascending") + ("etc/images/spell" . ("tools-check-spelling" "gtk-spell-check")) ("images/gnus/toggle-subscription" . "gtk-task-recurring") ("images/mail/compose" . "gtk-mail-compose") ("images/mail/copy" . "gtk-mail-copy") ("images/mail/forward" . "gtk-mail-forward") ("images/mail/inbox" . "gtk-inbox") + ("images/mail/important" . "mail-mark-important") ("images/mail/move" . "gtk-mail-move") ("images/mail/not-spam" . "gtk-not-spam") ("images/mail/outbox" . "gtk-outbox") ("images/mail/reply-all" . "gtk-mail-reply-to-all") ("images/mail/reply" . "gtk-mail-reply") ("images/mail/save-draft" . "gtk-mail-handling") - ("images/mail/send" . "gtk-mail-send") + ("images/mail/send" . ("mail-send" "gtk-mail-send")) ("images/mail/spam" . "gtk-spam") ;; Used for GDB Graphical Interface ("images/gud/break" . "gtk-no")