From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: undefined reference to `my_heap_start' Date: Wed, 16 Jan 2019 17:36:27 -0800 Organization: UCLA Computer Science Department Message-ID: <27815330-7949-db72-8991-f6f2ebacbf50@cs.ucla.edu> References: <87va2o9aql.fsf@yandex.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------2D78EDC1985FFC99FBDA7336" X-Trace: blaine.gmane.org 1547689065 15725 195.159.176.226 (17 Jan 2019 01:37:45 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 17 Jan 2019 01:37:45 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 Cc: emacs-devel@gnu.org To: Colin Baxter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 17 02:37:41 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gjwcl-0003vD-Fe for ged-emacs-devel@m.gmane.org; Thu, 17 Jan 2019 02:37:39 +0100 Original-Received: from localhost ([127.0.0.1]:36867 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gjwes-0005HY-Gc for ged-emacs-devel@m.gmane.org; Wed, 16 Jan 2019 20:39:50 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:43276) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gjwe5-00057o-VY for emacs-devel@gnu.org; Wed, 16 Jan 2019 20:39:02 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gjwbj-0002ND-8H for emacs-devel@gnu.org; Wed, 16 Jan 2019 20:36:36 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:41008) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gjwbg-0002HT-BC for emacs-devel@gnu.org; Wed, 16 Jan 2019 20:36:33 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 70924160FF2; Wed, 16 Jan 2019 17:36:29 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id wCahvfUHvqTB; Wed, 16 Jan 2019 17:36:28 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 5E09216108D; Wed, 16 Jan 2019 17:36:28 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id VFFwozUvsj14; Wed, 16 Jan 2019 17:36:28 -0800 (PST) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 41CAE160D13; Wed, 16 Jan 2019 17:36:28 -0800 (PST) Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECH In-Reply-To: <87va2o9aql.fsf@yandex.com> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:232411 Archived-At: This is a multi-part message in MIME format. --------------2D78EDC1985FFC99FBDA7336 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 1/16/19 2:07 AM, Colin Baxter wrote: > CCLD temacs.in > alloc.o: In function `malloc_initialize_hook': > /home/redknight/git/emacs/src/alloc.c:140: undefined reference to `my_heap_start' I think I see the problem. I installed the attached patch; please give it a try. --------------2D78EDC1985FFC99FBDA7336 Content-Type: text/x-patch; name="0001-Port-pdumper-to-older-GNU-Linux.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-Port-pdumper-to-older-GNU-Linux.patch" >From 696d43275eaa12982e28ec3b080441d6ca9dec34 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Wed, 16 Jan 2019 17:34:45 -0800 Subject: [PATCH] Port pdumper to older GNU/Linux Problem reported by Colin Baxter in: https://lists.gnu.org/r/emacs-devel/2019-01/msg00321.html * src/alloc.c (my_heap_start): Also define if GNU_LINUX && CANNOT_DUMP && DOUG_LEA_MALLOC. --- src/alloc.c | 32 +++++++++++++++++--------------- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/src/alloc.c b/src/alloc.c index 8054aa5ae5..5ea466beca 100644 --- a/src/alloc.c +++ b/src/alloc.c @@ -103,24 +103,12 @@ along with GNU Emacs. If not, see . */ #include "w32heap.h" /* for sbrk */ #endif -#if defined GNU_LINUX && !defined CANNOT_DUMP -/* The address where the heap starts. */ -void * -my_heap_start (void) -{ - static void *start; - if (! start) - start = sbrk (0); - return start; -} -#endif - #ifdef DOUG_LEA_MALLOC /* Specify maximum number of areas to mmap. It would be nice to use a value that explicitly means "no limit". */ -#define MMAP_MAX_AREAS 100000000 +# define MMAP_MAX_AREAS 100000000 /* A pointer to the memory allocated that copies that static data inside glibc's malloc. */ @@ -136,9 +124,9 @@ malloc_initialize_hook (void) if (! initialized) { -#ifdef GNU_LINUX +# ifdef GNU_LINUX my_heap_start (); -#endif +# endif malloc_using_checking = getenv ("MALLOC_CHECK_") != NULL; } else @@ -201,6 +189,20 @@ alloc_unexec_post (void) free (malloc_state_ptr); # endif } + +# ifdef GNU_LINUX + +/* The address where the heap starts. */ +void * +my_heap_start (void) +{ + static void *start; + if (! start) + start = sbrk (0); + return start; +} +# endif + #endif /* Mark, unmark, query mark bit of a Lisp string. S must be a pointer -- 2.20.1 --------------2D78EDC1985FFC99FBDA7336--