From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: "Eli Zaretskii" Newsgroups: gmane.emacs.devel Subject: Re: Windows port: using Windows' default printer Date: Wed, 24 Sep 2003 20:25:08 +0200 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <2719-Wed24Sep2003202507+0300-eliz@elta.co.il> References: <3E54D5AA.4000805@runestig.com> <3E55CCC0.5050408@runestig.com> <8011-Sun21Sep2003151918+0300-eliz@elta.co.il> <3F7074C8.5010206@runestig.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: deer.gmane.org X-Trace: sea.gmane.org 1064425253 27701 80.91.224.253 (24 Sep 2003 17:40:53 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 24 Sep 2003 17:40:53 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Wed Sep 24 19:40:50 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1A2DdC-0002VU-00 for ; Wed, 24 Sep 2003 19:40:50 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1A2Dk0-0005ZW-00 for ; Wed, 24 Sep 2003 19:47:52 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.22) id 1A2DXx-0007PR-Ko for emacs-devel@quimby.gnus.org; Wed, 24 Sep 2003 13:35:25 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.22) id 1A2DXt-0007Ov-1r for emacs-devel@gnu.org; Wed, 24 Sep 2003 13:35:21 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.22) id 1A2DT6-0006K7-68 for emacs-devel@gnu.org; Wed, 24 Sep 2003 13:30:24 -0400 Original-Received: from [192.114.186.23] (helo=aragorn.inter.net.il) by monty-python.gnu.org with esmtp (Exim 4.22) id 1A2DSx-0006Be-12 for emacs-devel@gnu.org; Wed, 24 Sep 2003 13:30:15 -0400 Original-Received: from zaretski (pns03-208-8.inter.net.il [80.230.208.8]) by aragorn.inter.net.il (Mirapoint Messaging Server MOS 3.3.7-GR) with ESMTP id BMZ11533; Wed, 24 Sep 2003 20:27:46 +0300 (IDT) Original-To: "Peter 'Luna' Runestig" X-Mailer: emacs 21.3.50 (via feedmail 8 I) and Blat ver 1.8.9 In-reply-to: <3F7074C8.5010206@runestig.com> (peter@runestig.com) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.2 Precedence: list List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:16605 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:16605 > Date: Tue, 23 Sep 2003 18:28:56 +0200 > From: "Peter 'Luna' Runestig" > > > >> If I understand you correctly, we already have such a function in > >> lpr.el: it's `print-region-function'. dos-w32.el defines it for the > >> Windows and the DOS ports. > > > > Does ps-print.el use it ? > > If so, great, we just need to add the `default-printer-name' stuff > > to it and be done with It, > > Isn't this what my patch does? Yes, but why did you need to test for default-printer-name to be fboundp? It should simply be called unconditionally, and we should have some provision for the user to override that with printer-name. > I also tampered with the following files, but maybe that isn't necessary: > > lpr.el: Add `default-printer-name' stuff to `print-region-1'. > ps-print.el: Add `default-printer-name' stuff to `ps-do-despool'. > play/handwrite.el: Add `default-printer-name' stuff to `handwrite'. This shouldn't be necessary. I still think that, even for Windows, it's overhead to call default-printer-name each time we print something. But that's me.