From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.devel Subject: Re: Mistakes in commit log messages Date: Sat, 15 Apr 2023 14:23:02 -0700 Message-ID: <265ac2c8-98bf-97db-2567-fce5db06577a@gmail.com> References: <835ya5m4p0.fsf@gnu.org> <83v8i4arzt.fsf@gnu.org> <838rezardu.fsf@gnu.org> <319d616d-9230-0a82-331f-0f57488e4c80@gmail.com> <834jpm9s1g.fsf@gnu.org> <83v8i28b3j.fsf@gnu.org> <693285d2-e50b-289d-4f3e-ddd817ddc75b@gmail.com> <48d4dffa-cfa8-7949-3043-a1efa937902d@gmail.com> <838rew5lak.fsf@gnu.org> <5adfbf6f-fbcb-f4e8-3662-48bd5eb6a269@gmail.com> <9c8826af-a160-d36f-7577-2bc5ec0c2004@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33265"; mail-complaints-to="usenet@ciao.gmane.io" Cc: acm@muc.de, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Apr 15 23:23:49 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pnnN7-0008W4-LN for ged-emacs-devel@m.gmane-mx.org; Sat, 15 Apr 2023 23:23:49 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pnnMT-00009x-Py; Sat, 15 Apr 2023 17:23:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pnnMS-00008h-Av for emacs-devel@gnu.org; Sat, 15 Apr 2023 17:23:08 -0400 Original-Received: from mail-pf1-x436.google.com ([2607:f8b0:4864:20::436]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pnnMP-0007E7-Oe; Sat, 15 Apr 2023 17:23:08 -0400 Original-Received: by mail-pf1-x436.google.com with SMTP id d2e1a72fcca58-63b62d2f729so497112b3a.1; Sat, 15 Apr 2023 14:23:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681593784; x=1684185784; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=MOUNwFmkzjkmWdckUAVfitO29vFNLDAQxHic3DUChJQ=; b=iwP7ywFiTxSuqZMY3l9ucyIODqpwJlyIExM9XkUhtwZJevB0DR2rNXrgFHbOyT+J39 xhFMnuklI7CQ6aoMaj5p9oRA+nicSe6FWViieHQ3r39ZXrcslp4lx5G7d/WWJ87n0oM0 6OZiV0j+WLwIMiDjTvRlHXZtTPQO6fvmJHTwCr0+o61OSG8ydCWe9+kD9LeAGg4EvZus 5hXzbEbxO7jZu3d1whJO5wLNlOVYDJsZYVUbOTyxrG0mFeiF9W3fAEZMDvPhZTcYsQVi RMbeA4BDsPrMraDA/qVa4xE69w1xEZer6vPeRV6qjQGiJDDgOJlSjHshBTLodv2MqjDR edKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681593784; x=1684185784; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MOUNwFmkzjkmWdckUAVfitO29vFNLDAQxHic3DUChJQ=; b=YqCQey0o5NfO0hQ6qrQXta3It11bNJvgcAcbuh21NUDLwhU2H17Rn02d9DoKXiOTfT Z2DcpTUGYEuCHuTipeYdDS2HhpKhBzFWW4UDEOUFHaaRJ2gWqx9SEARaZriUNKE15kib /uJkVjBRnk4hUNd2fTUKRPRbBt5E1U/gKJ2kKZ2r4NT/1wxDuIenTdjHlnlySimoAtEk oApncxxtKjdgRzmV60DU7b7rafXeg9ik46fm3jbrnqkM8/UV3ZnO7NISSoUPkuec/GiP mbXcDqn7+gRPcJyFKoT1xT4c+Kd4LpfcHNXv+aitD3Q4E4pqybYXw931xheXKYI2S0AV lFOA== X-Gm-Message-State: AAQBX9cz9dIOOYDRxY6mJUgRINCvlv/+Sf2cEys58imOYR2l00X7lhOU M1NSvZ7ikEUieiS/pkMeIdIsyDp7FmR+Fg== X-Google-Smtp-Source: AKy350ZmnlQOEVt8wnz5q91Pn1IJ8D4lb+XYTiBf68d0wuociJdIj/7SsOSFBilm2ldskm2m+DHuZw== X-Received: by 2002:a05:6a00:2e87:b0:627:f0e1:4fbf with SMTP id fd7-20020a056a002e8700b00627f0e14fbfmr17190186pfb.33.1681593783451; Sat, 15 Apr 2023 14:23:03 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id f5-20020a631f05000000b0050fb618800dsm4545235pgf.67.2023.04.15.14.23.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 15 Apr 2023 14:23:03 -0700 (PDT) Content-Language: en-US In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::436; envelope-from=jporterbugs@gmail.com; helo=mail-pf1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305332 Archived-At: On 4/15/2023 1:54 PM, Jim Porter wrote: > On 4/14/2023 10:45 PM, Jim Porter wrote: >> Here are a couple small fixes after testing against the 2000 latest >> commits (though I haven't examined *all* the errors in detail). > > Ok, I've now gone over the 5000 latest commits in some closer detail. Oh, and just to give an idea of how common incorrect commit messages are, my hook says that out of the last 5000 commits, 866 have a problem, excluding the Eglot commits. If I also ignore lines starting with "*" that have no "/" in them (these are almost always due to an unnecessary leading "*" on the first line of the commit), we get down to 196 bad commit messages, or 3.9% of commits.