Re: [PATCH] Add user content APIs for WebKit Xwidgets

[Qiantan Hong <qthong@stanford.edu>]

> BTW, there are many other problems with your patch, aside from
> capitalization and interning symbols with a static string.  Please read
> through the entirety of my reply.
Yes I’m aware. I was fixing them one by one.

>> How do I mark it?
> 
> I suggest linking each callback data struct into a list, each element of
> which is then marked in a "mark_xwidget" function that should be called
> by garbage_collect in alloc.c.
It seems that existing code is connecting signal without adding the marking
code, guess that should be fixed too...

> 
>> I’m imitating the usage pattern of what is already in nsxwidget.m.
>> I think if I’m leaking memory then the current code must also have been
>> (which could be the case)...
> 
> I guess that should be fixed.

Those two problems above, I don’t have any existing code to imitate, so it
would take a while to learn the codebase for me to be able to fix them.
I’m also not sure if I should just make my part conforming or also fix all existing code.
Is it acceptable that I submit a patch (with other problems fixed) first,
and work on fixing these two classes of problems later?

Best,
Qiantan