From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "T.V Raman" Newsgroups: gmane.emacs.devel Subject: Re: Should native compilation be enabled by default? Date: Tue, 5 Mar 2024 08:01:37 -0800 Message-ID: <26087.16865.773226.470309@retriever.mtv.corp.google.com> References: <86sf19p0hw.fsf@gnu.org> <26087.13306.377059.686370@retriever.mtv.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21432"; mail-complaints-to="usenet@ciao.gmane.io" Cc: raman@google.com, rms@gnu.org, eliz@gnu.org, emacs-devel@gnu.org To: acorallo@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Mar 05 17:02:42 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rhXFY-0005LY-Hf for ged-emacs-devel@m.gmane-mx.org; Tue, 05 Mar 2024 17:02:40 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rhXEw-0000lT-8u; Tue, 05 Mar 2024 11:02:02 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rhXEm-0000Qv-GQ for emacs-devel@gnu.org; Tue, 05 Mar 2024 11:01:55 -0500 Original-Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rhXEj-0001Zg-MT for emacs-devel@gnu.org; Tue, 05 Mar 2024 11:01:52 -0500 Original-Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-1dc09556599so55364375ad.1 for ; Tue, 05 Mar 2024 08:01:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1709654506; x=1710259306; darn=gnu.org; h=references:in-reply-to:subject:cc:to:date:message-id :content-transfer-encoding:mime-version:from:from:to:cc:subject:date :message-id:reply-to; bh=vlQp/WH30osv+g7qwUeJICGXqyMCJgGB23xQ30cnS3U=; b=KbxzY1lDO5oGYJsH1506NUtNgjEHadi6tD48W268dMb9qwv/kROs5lI8QGJqkPAHeh xytesE676fwy5bnN3Dg/83n/knV76uH3nzaS1T5bUW7yNsjfzunn/sNuCkQli/aT8jXu 853FbaKp8T3cXZJB8nIunYm1AnMZ+3fbAfV6pdw1211VhjTGFKDD05x9j6H+5rpoH20f ZbsdPLc6NUsq1YQbR9iAI6h82+gQi76Aq/4CgErXtSBLUym6fMBaBP4agYQaJWylIO3b j2i/i2c/V4TJRC0GF7LUiyVntDdw9OxagC2vJ4YjVuGN6QOnnBle9XhftmHeMQo56B6T MUXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709654506; x=1710259306; h=references:in-reply-to:subject:cc:to:date:message-id :content-transfer-encoding:mime-version:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=vlQp/WH30osv+g7qwUeJICGXqyMCJgGB23xQ30cnS3U=; b=I9+rSKCr2p9k9FN/CiU4JK+/+fhahwx2hWkpblpZGMAKhgpIZk8Uxwz0EN+wl27ums HuourOgJDxCwOg5VXN15jIjHaALCC58odltjHaA21uVLoeUFUZrA/fM3y18QBMb1t4WF OwTMABapllC8JhrUZ4wKnLdthb7C55RJsi+z3SqPz+NZRF9RwolCxwH437NQIT/SZtgA isKVRgStn25PH0bsaz9fmQM2Afti3cCmkB1cVfJ1ceGwdGNqpTpG1Bg579Pgjc1AKRtG ZpUE6BcVOgy067pw++QgCkep9l1iChDocWSpfaHnvn1fBuucPX1f4jkxV98OR+DDpxBl qATg== X-Forwarded-Encrypted: i=1; AJvYcCXq+5XdyjBMEnyIE17ghNevqdgDMpMdVKaD0xF875x+HkdaGDTTcA31QSYeercy6QASl54ZIzlg2dmtYE8bvSc9V4jR X-Gm-Message-State: AOJu0Yx1nnr/oeBptK7jtn0HixYGob0puEJ+D2bdPvrML+HuhXa436iJ YLYB6Ga1TdFRCWCNafeUE9MW6V9UTemQgDxRppcN8I76+B1gbS74ndBJ9P1p406tvvRFBrdh7KW +qA== X-Google-Smtp-Source: AGHT+IH5IAKfVM6gfffexygFeIlK9ufuSFAfj22P0/LISeP4Yg3xJG12E3/7reQkQCAK9apGmm4VRA== X-Received: by 2002:a17:902:c3c6:b0:1dc:a60f:4bef with SMTP id j6-20020a170902c3c600b001dca60f4befmr1933377plj.63.1709654501140; Tue, 05 Mar 2024 08:01:41 -0800 (PST) Original-Received: from retriever.mtv.corp.google.com ([2620:15c:b5:1:afe5:40c6:1806:4ece]) by smtp.gmail.com with ESMTPSA id kw13-20020a170902f90d00b001dc90ac1cecsm10694129plb.284.2024.03.05.08.01.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Mar 2024 08:01:40 -0800 (PST) In-Reply-To: X-Mailer: VM 8.1.1 under 30.0.50 (x86_64-pc-linux-gnu) Received-SPF: pass client-ip=2607:f8b0:4864:20::62a; envelope-from=raman@google.com; helo=mail-pl1-x62a.google.com X-Spam_score_int: -195 X-Spam_score: -19.6 X-Spam_bar: ------------------- X-Spam_report: (-19.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, NICE_REPLY_A=-1.98, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:316832 Archived-At: it's not my code, which is the issue. VM is a third party package and no longer maintained, but I happen to use it as my primary mail reder It uses macros where it should likely have used defsubst. >From what I remember and this might ell have changed: 1. It's build el->elc relied on specific ordering of byte compilation. 2. Native comp from .elc->.eln -- rather than .el->.eln 3. 1 2 and the different order of compilation resulted in broken eln files that threw errors at random when using VM Andrea Corallo writes: > "T.V Raman" writes: > > > this was discussed more than 2 years ago and closed -- the issue is > > the use of macros in older packages and native-comp compiling files in > > an order different from byte-comp. > > AFAIK we compile correctly correct code. If your code is missing some > require and is relying on some specific compilation order using the byte > compiler such that some library it's by chance loaded when some > compilation unit is compiled, well it's just buggy code. > > If this is unmaintanied code and no-one including you want to fix it, > well just add it to `native-comp-jit-compilation-deny-list'. > > Thanks > > Andrea --