From: "Jostein Kjønigsen" <jostein@secure.kjonigsen.net>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: "Ergus via Emacs development discussions." <emacs-devel@gnu.org>,
Stefan Monnier <monnier@iro.umontreal.ca>
Subject: Re: [PATCH] Adding new schemas to nxml-mode
Date: Thu, 22 Feb 2024 16:13:49 +0100 [thread overview]
Message-ID: <25D87170-E120-4779-A84C-DF527D59EE71@secure.kjonigsen.net> (raw)
In-Reply-To: <CADwFkm=WDkREgZWTaaOaoJnrhAMqEmZtdoEdAxdd5+YOivJaug@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2750 bytes --]
> On 21 Feb 2024, at 04:01, Stefan Kangas <stefankangas@gmail.com> wrote:
>
>> Basically as a minimum make sure it works for more people than just me.
>
> What happens if it doesn't "work" in this context? Can it hurt or is it
> just an extra feature that they won't benefit from?
In terms of “working" I would consider the following:
* The appropriate schemas are activated for the appropriate and expected files.
* The schemas, when activated, do not create warnings for correctly formatted XML-files (according to that schema).
In terms of NOT working, I would consider the following:
* A schema is activated for a file which it is not appropriate for.
* A schema, when activated for an appropriate file-type, flags correctly formatted XML-elements within that file as erroneous.
> - I think this should also come with updates to etc/schemas/README
> describing the copyright and legal status of these new schemas.
> See that file to get an idea of what's needed.
I didn't know about that one. Will look into it!
> - Does "Dotnet" also include "Mono" (or some other free software
> replacement)? If yes, I think the commit message should say so
> explicitly, so that we mention both but advertise mainly the free
> version. I.e. it should say "Mono/Dotnet" rather than "Dotnet/Mono".
Not going to go for a technical deep dive here, but in short:
- .NET Framework was a closed-source Windows only development platform created by Microsoft
- Mono is a open-source cross-platform reimplementation of .NET Framework
Today when one refers to .NET when typically refers to the “new” modern .NET project (with no “framework” suffix), which is both open-source and cross-platform. Modern .NET supersedes .NET Framework, and in many ways Mono as well.
While all file-types covered by schemas submitted here are relevant/applicable to all those three development platforms, as they all work on the same type of source-files and build-systems… I would argue that the “main” development target these days for any developer working on up to date tooling is going to be .NET, not Mono. As such, I think just referring to it as dotnet is appropriate.
> - Should this be called out in NEWS?
It could. I have no opinion on how “big” a feature/change has to be before it’s considered newsworthy.
I’ll let more seasoned Emacs-contributors decide that, if that’s OK.
> - (This should also have a proper ChangeLog in the commit message, of
> course.)
I thought I added a pretty decent one in my commit… Was that not included in the patch?
Or do you mean adding it to a ChangeLog file of some sort? If so, which one?
—
Kind Regards
Jostein Kjønigsen
[-- Attachment #2: Type: text/html, Size: 3766 bytes --]
next prev parent reply other threads:[~2024-02-22 15:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-18 20:12 Adding new schemas to nxml-mode. Am I doing it right? Jostein Kjønigsen
2024-02-19 22:20 ` Stefan Kangas
2024-02-20 20:02 ` [PATCH] Adding new schemas to nxml-mode Jostein Kjønigsen
2024-02-21 3:01 ` Stefan Kangas
2024-02-22 15:13 ` Jostein Kjønigsen [this message]
2024-02-23 14:25 ` Jostein Kjønigsen
2024-05-18 19:48 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25D87170-E120-4779-A84C-DF527D59EE71@secure.kjonigsen.net \
--to=jostein@secure.kjonigsen.net \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).