unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "T.V Raman" <raman@google.com>
To: emacs-devel@gnu.org
Cc: emacs-devel@gnu.org, juri@linkov.net
Subject: Slow completion-at-point was Re: Navigating completions from minibuffer
Date: Wed, 8 Nov 2023 14:11:44 -0800	[thread overview]
Message-ID: <25932.1952.158726.658192@google.com> (raw)
In-Reply-To: <25931.49899.219679.933329@google.com>


Here is some timing information for this issue:



I added the following around advice fragment to completion-at-point debug:

(let ((start (current-time)))
     ad-do-it
     (message "<%.4f %d gcs %.4f>"
              (float-time (time-subtract (current-time) start))
              gcs-done gc-elapsed))

Then I went to a shell buffer, and from my home directory (it contains
a subdir text) typed

cd te <tab>

Messages buffer shows the following:

~/
Making completion list...
Sole completion
<2.0219 14 gcs 1.2927>
--Raman 
T.V Raman writes:
 > Adding emacs-devel after verifying slowness:
 > 
 > 1. completion-at-point appears to have gotten very slow -- from memory
 >    in the last week (emacs built against Git @HEAD)
 >    The slowness is not present in a build from October 4.
 > 
 >    
 > 
 > T.V Raman writes:
 >  > Juri Linkov <juri@linkov.net> writes:
 >  > 
 >  > 
 >  > Agreed. And somewhat related and something that has been causing me
 >  > trouble:
 >  > 
 >  > Q: Why is completion-at-point *soo much* slower than
 >  > hippie-expand?
 >  > 
 >  > I tried to understand why by looking at the code for completion-at-point
 >  > but failed miserably.
 >  > 
 >  > Hope you could look at this since you're working on completion related
 >  > bits.
 >  > 
 >  > 
 >  > Also, how and when completions are displayed can now be controlled by
 >  > multiple custom knobs, but it's hard to map the combinatorial explosion
 >  > of the available possibilities to different user experiences without
 >  > trying all possible settings; a higher level overview with a couple of
 >  > recipes that describe common combinations would help.
 >  > 
 >  > 
 >  > >> everything works, now that I actually applied the complete patch:-)
 >  > >
 >  > > Thanks for confirming and for suggesting this change, now pushed.
 >  > >
 >  > > Probably we have to make RET more smart, so that when more editing
 >  > > was performed in the minibuffer after the completions were displayed,
 >  > > then to use the minibuffer contents with exit-minibuffer,
 >  > > not an obsolete completion candidate that remains selected.
 >  > >
 >  > 
 >  > -- 
 > 
 > -- 
 > 
 > -- 

-- 

-- 



  reply	other threads:[~2023-11-08 22:11 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-07  3:57 Navigating completions from minibuffer T.V Raman
2023-11-07  4:55 ` T.V Raman
2023-11-07  7:20   ` Juri Linkov
2023-11-07 17:53     ` T.V Raman
2023-11-07 19:36       ` T.V Raman
2023-11-08  7:39         ` Juri Linkov
2023-11-08 16:21           ` T.V Raman
2023-11-08 17:18             ` T.V Raman
2023-11-08 22:11               ` T.V Raman [this message]
2023-11-09  7:22                 ` Slow completion-at-point Juri Linkov
2023-11-09 12:10                   ` Dmitry Gutov
2023-11-09 16:20                     ` Juri Linkov
2023-11-09 18:32                       ` João Távora
2023-11-11  2:48                     ` T.V Raman
2023-11-11 10:36                       ` Dmitry Gutov
2023-11-11 16:40                         ` T.V Raman
2023-11-11 19:00                           ` Juri Linkov
2023-11-11 19:43                             ` T.V Raman
2023-11-11 21:50                               ` Dmitry Gutov
2023-11-09 15:39                   ` T.V Raman
2023-11-09 12:20                 ` Slow completion-at-point was Re: Navigating completions from minibuffer Dmitry Gutov
2023-11-09 15:41                   ` T.V Raman
2023-11-09 17:46                 ` T.V Raman
2023-11-10 13:12           ` Spencer Baugh
2023-11-11 18:58             ` Juri Linkov
2023-11-14  7:36               ` Juri Linkov
2023-11-15 21:40                 ` Spencer Baugh
2023-11-16 17:15                   ` T.V Raman
2023-11-15 22:03                 ` Spencer Baugh
2023-11-16  7:16                   ` Juri Linkov
2023-11-16 14:41                     ` Spencer Baugh
2023-11-16 17:28                       ` Juri Linkov
2023-11-16 18:25                         ` Spencer Baugh
2023-11-17  7:09                           ` Juri Linkov
2023-11-17 17:22                             ` Spencer Baugh
2023-11-18 20:58                               ` sbaugh
2023-11-19  7:08                                 ` Juri Linkov
2023-11-19  8:19                                   ` Eli Zaretskii
2023-11-19 14:41                                   ` Spencer Baugh
2023-11-19 18:01                                     ` Juri Linkov
2023-11-19 19:41                                       ` Spencer Baugh
2023-11-20  2:58                                       ` Spencer Baugh
2023-11-23 13:39                                     ` sbaugh
2023-11-24  7:54                                       ` Juri Linkov
2023-11-25 15:19                                         ` Spencer Baugh
2023-11-25 16:08                                           ` Eli Zaretskii
2023-11-25 18:23                                             ` sbaugh
2023-11-25 18:48                                               ` Juri Linkov
2023-11-26 13:10                                                 ` sbaugh
2023-11-25 19:00                                               ` Eli Zaretskii
2023-11-25 17:46                                           ` Juri Linkov
2023-11-26 14:33                                             ` Spencer Baugh
2023-11-27  7:22                                               ` Juri Linkov
2023-11-28 14:48                                                 ` Spencer Baugh
2023-11-28 17:23                                                   ` Juri Linkov
2023-11-29  0:20                                                     ` Spencer Baugh
2023-12-03 17:21                                                       ` Juri Linkov
2023-12-03 18:13                                                         ` Eli Zaretskii
2023-12-06 17:20                                                           ` Juri Linkov
2023-12-06 17:50                                                             ` Eli Zaretskii
2023-12-07  7:44                                                               ` Juri Linkov
2023-12-08  8:46                                                                 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25932.1952.158726.658192@google.com \
    --to=raman@google.com \
    --cc=emacs-devel@gnu.org \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).