From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 55ec674: * lisp/multifile.el: New file, extracted from etags.el Date: Sat, 29 Dec 2018 02:27:33 +0200 Message-ID: <258b0e95-7c9c-0b57-5d80-e3559158d228@yandex.ru> References: <20180922154639.23195.66360@vcs0.savannah.gnu.org> <20180922154640.9D58220310@vcs0.savannah.gnu.org> <54108dbc-9d12-06ff-3f1d-151118e9b234@yandex.ru> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1546045943 9164 195.159.176.226 (29 Dec 2018 01:12:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 29 Dec 2018 01:12:23 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:64.0) Gecko/20100101 Thunderbird/64.0 Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Dec 29 02:12:19 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gd3Ap-0002G4-7h for ged-emacs-devel@m.gmane.org; Sat, 29 Dec 2018 02:12:19 +0100 Original-Received: from localhost ([127.0.0.1]:34102 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gd3Cv-000567-SX for ged-emacs-devel@m.gmane.org; Fri, 28 Dec 2018 20:14:29 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:56104) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gd3CD-00055t-0b for emacs-devel@gnu.org; Fri, 28 Dec 2018 20:13:49 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gd2u8-0003Ud-2z for emacs-devel@gnu.org; Fri, 28 Dec 2018 19:55:09 -0500 Original-Received: from mail-lj1-x22d.google.com ([2a00:1450:4864:20::22d]:36078) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gd2TZ-00084W-Og for emacs-devel@gnu.org; Fri, 28 Dec 2018 19:27:37 -0500 Original-Received: by mail-lj1-x22d.google.com with SMTP id g11-v6so19861023ljk.3 for ; Fri, 28 Dec 2018 16:27:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=v3Yi9DjYgrzZgITAQW1nw+NVUl6rltnHXuAdb00XIcc=; b=pH6rHcweK7et06olMi+lh0m8kzA8wOAsUBtI0eQQSKv7z6cOAjkkXa7/o+vJszlmHp H4z0qXdb5MdyoLXBTbigH+anqoAUE9mik+aBbV0O2qdAo3nzOhq4Dcx/zLIZdLFPLt7b F/aHsqjR2fJWEkhX7YzacUTfoKpesAXwUeEnTE6bS9NulfiLJbZYEnF8zEfgeSYqagiT 1jRR5fhfzVQBoCJErhBB4XNRHMAhHmdGvmQLsnDpGmNqu+/UQgWy8VZjP8FAvMxjBb7F VLC9FXoui0ArcG4YFgi2ioYyrNOenIZo35blbQPCp6SieyqB8cnkOOVawk53Pp+NUGOm zY7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=v3Yi9DjYgrzZgITAQW1nw+NVUl6rltnHXuAdb00XIcc=; b=JsdLeaghbaYatl+lh7rDAVoefd1O1VVrTi7HDz774qPmfvdJDdOUPMC3NTQq/s7e8+ VPA9LEDPNRGSuaNubZz1Qqd1DX4nwlqUXhkhVRA8ZHC3dnQbU28Y11TcvEO6Fn7IuOBc 9hWiLAqeQljxgG8aDtiOLmwuQ+0A9eWlVrhTuRx2CseXKT6rTUbF4AQLyfR7daMIKnrz aEhART2ATpC9vIF8UfCtiRp61B7UCw5WbCZ6/RcBlaFXwKRD8PO8sd2PFyLmbrewG9ne RyLfZ82Q8ailoTET20jLJ57eZksX8Deubf53xg2xviyz6rIZYxJt2Tua7V7R/vUKdPbq DEXg== X-Gm-Message-State: AJcUukdoO5HZ1MZhsy8Bj6wYOlEfAmwQNVUvDARIZW9rU26p0bLxKAEf 1gi9k49zYXrRha00vnc5LQazhYle X-Google-Smtp-Source: ALg8bN7XkKf2Unq6h4dTaI3Zp7xWffhBvyRR6VshoYBtr4Ckmu8HcFM4f+FFeRA6Qiijq9KMhXk8Bw== X-Received: by 2002:a2e:1f01:: with SMTP id f1-v6mr16020249ljf.129.1546043255798; Fri, 28 Dec 2018 16:27:35 -0800 (PST) Original-Received: from [192.168.1.174] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id b21sm8184343lfi.7.2018.12.28.16.27.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Dec 2018 16:27:34 -0800 (PST) In-Reply-To: Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::22d X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:232026 Archived-At: On 27.12.2018 16:39, Stefan Monnier wrote: >>> I think TRT is to take the above common-prefix-directory, add it to the >>> prompt, and remove it from each completion candidate: this will keep >>> substring completion working correctly (and working even better since >>> it won't uselessly find matches in the common prefix) and will also >>> clarify where the search takes place. Now done in master. But I think it illustrates a common completion pitfall we have: 1. M-x project-find-file (while inside Emacs sources) 2. Type 'GNU', then TAB, then TAB again. 3. It completes to 'GNUmakefile' and insists it is 'Sole completion'. Even though e.g. etc/GNUS-USERS exists. > Not necessarily: we could accumulate the prefix as long as it's the > sole completion. I've decided against writing a wrapper that pipes the whole collection through 'substring' every time it is called. So for now it also requires a flat collection.