unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [angeli@caeruleus.net: custom-set-variables overwritten by safe-local-variables]
@ 2006-04-28 15:45 Richard Stallman
  2006-04-29  5:10 ` [angeli@caeruleus.net: custom-set-variables overwritten bysafe-local-variables] Stuart D. Herring
  0 siblings, 1 reply; 6+ messages in thread
From: Richard Stallman @ 2006-04-28 15:45 UTC (permalink / raw)


Would someone please DTRT, then ack?

------- Start of forwarded message -------
From: Ralf Angeli <angeli@caeruleus.net>
To: emacs-pretest-bug@gnu.org
Date: Thu, 27 Apr 2006 23:44:48 +0200
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Subject: custom-set-variables overwritten by safe-local-variables
X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=failed 
	version=3.0.4

- --=-=-=

The following mail was originally sent to the AUCTeX mailing list.  I
can reproduce the problem with a build on GNU/Linux checked out today.


- --=-=-=
Content-Type: message/rfc822
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

Return-Path: <rainer.thiel@googlemail.com>
Delivery-Date: Thu, 27 Apr 2006 13:53:38 +0200
Received-SPF: pass (mxeu12: domain of googlemail.com designates 66.249.82.192
	as permitted sender) client-ip=66.249.82.192;
	envelope-from=rainer.thiel@googlemail.com; helo=xproxy.gmail.com;
Received: from [66.249.82.192] (helo=xproxy.gmail.com)
	by mx.kundenserver.de (node=mxeu12) with ESMTP (Nemesis),
	id 0MKrQq-1FZ53v2ATY-0000rV for angeli@caeruleus.net;
	Thu, 27 Apr 2006 13:53:37 +0200
Received: by xproxy.gmail.com with SMTP id h30so1667599wxd
	for <angeli@caeruleus.net>; Thu, 27 Apr 2006 04:53:34 -0700 (PDT)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=googlemail.com;
	h=received:message-id:date:from:reply-to:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
	b=ippd+8qSagv5UO0TcNEWlPzIySeMCVdQyWpC6JWZEONkSZZILKT52snURhylwvz004wWDn+IdIFjfnlCdcb00phPruZEwcTI3VqlrPn6jmL+jthx4TTf46c5n9shugBC1OBgul4kzSO+M697uq5wr5LIvOronMvF49tywvTV5nk=
Received: by 10.70.105.7 with SMTP id d7mr1946161wxc;
	Thu, 27 Apr 2006 04:53:34 -0700 (PDT)
Received: by 10.70.54.16 with HTTP; Thu, 27 Apr 2006 04:53:34 -0700 (PDT)
Message-ID: <d6b6c7740604270453m1c72c346i8744e1375463e647@mail.gmail.com>
Date: Thu, 27 Apr 2006 13:53:34 +0200
From: "Rainer Thiel" <r.thiel@uni-jena.de>
Reply-To: rainer.thiel@googlemail.com
Sender: rainer.thiel@googlemail.com
To: "Ralf Angeli" <angeli@caeruleus.net>
Subject: Re: [AUCTeX] another Problem with recent emacs + auctex packages
Cc: auctex@gnu.org
In-Reply-To: <87bquo14i6.fsf@neutrino.caeruleus.net>
References: <d6b6c7740604261200y6903a5e8yded2f419ac1dd226@mail.gmail.com>
	<87bquo14i6.fsf@neutrino.caeruleus.net>
Envelope-To: angeli@caeruleus.net
X-SpamScore: 0
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit

2006/4/26, Ralf Angeli <angeli@caeruleus.net>:
> Can you provide a precise test case showing this behavior?  The test
> case should include an exact description of what you are doing, the
> .emacs file before and after you marked the variables as being secure.

I was not very precise indeed.  I was referring to messages like:

     > The local variables list in Kap.tex
     > contains values that may not be safe (*).
     >
     > Do you want to apply it?  You can type
     >
     > y  -- to apply the local variables list.
     > n  -- to ignore the local variables list.
     > !  -- to apply the local variables list, and
     >      mark these values (*) as
     >      safe (in the future, they can be set
     >      automatically.)
     >
     >    * TeX-Master: main.tex

that I got when loading .tex-files like

          >          \section{\"Uberschrift}
          >
          >          Etwas Text.
          >
          >               % Local Variables:
          >               % TeX-master: "main.tex"
          >               % End:

to point auctex to a TeX-master-file such as

          >          \documentclass{article}
          >          \begin{document}
          >          \include{Kap}
          >          \end{document}

I had not got any such message in previous emacs+auctex Versions.

I now see that the problem most certainly is related not to auctex, but
to todo (part of the calendar package).

In case anyone might be interested and able and willing to help all the
same, this is my problem description:

1. I invoke emacs (as in emacs+auctex-w32-2006-03-09.zip) with
   .emacs.el and no .todo-do file in my homedirectory, .emacs.el
   having the following content:

; .emacs.el START
; Time-stamp: <2006-04-27 11:52:16 Rainer Thiel>

         (autoload 'todo-mode "todo-mode"
                   "Major mode for editing TODO lists." t)
         (autoload 'todo-show "todo-mode"
                   "Show TODO items." t)
         (autoload 'todo-insert-item "todo-mode"
                   "Add TODO item." t)

(setq european-calendar-style t) ; oben schon definiert
(setq number-of-diary-entries 14) ; Anzahl der Tage fuer diary
                                  ; ohne Argument

(diary)        ; diary und todo-Liste bei Start anzeigen; deshalb muss
(todo-show)    ; european-calendar-style und number-of-diary-entries
;; 	       ; schon vorher definiert sein


(custom-set-variables
  ;; custom-set-variables was added by Custom.
  ;; If you edit it by hand, you could mess it up, so be careful.
  ;; Your init file should contain only one such instance.
  ;; If there is more than one, they won't work right.
 '(fill-column 72)
 )

; .emacs.el END

- --> emacs starts as exspected

2. I press M-x todo-insert-item and create a todo entry in the [Todo] category.
- --> todo creates .todo-do and .todo-top in my home directory

3. I leave emacs

4. I re-start emacs
- --> the following message is being displayed:

     > The local variables list in .todo-do
     > contains values that may not be safe (*).
     >
     > Do you want to apply it?  You can type
     >
     > y  -- to apply the local variables list.
     > n  -- to ignore the local variables list.
     > !  -- to apply the local variables list, and
     >      mark these values (*) as
     >      safe (in the future, they can be set
     >      automatically.)
     >
     >    * todo-categories : (Todo Todo Todo)

5. I type `!'
- --> .emacs.el is changed as follows:

; .emacs.el START
; Time-stamp: <2006-04-27 12:03:35 Rainer Thiel>

         (autoload 'todo-mode "todo-mode"
                   "Major mode for editing TODO lists." t)
         (autoload 'todo-show "todo-mode"
                   "Show TODO items." t)
         (autoload 'todo-insert-item "todo-mode"
                   "Add TODO item." t)

(setq european-calendar-style t) ; oben schon definiert
(setq number-of-diary-entries 14) ; Anzahl der Tage fuer diary
                                  ; ohne Argument

(diary)        ; diary und todo-Liste bei Start anzeigen; deshalb muss
(todo-show)    ; european-calendar-style und number-of-diary-entries
;; 	       ; schon vorher definiert sein
;; ;--------------------------------------------------------------------


(custom-set-variables
  ;; custom-set-variables was added by Custom.
  ;; If you edit it by hand, you could mess it up, so be careful.
  ;; Your init file should contain only one such instance.
  ;; If there is more than one, they won't work right.
 '(safe-local-variable-values (quote ((todo-categories "Todo" "Todo" "Todo")))))
; .emacs.el END

As is obvious, the line declaring the values as safe replaces the line
defining the fill-column instead of simply being added.  It also
doesn't have the desired effect, in that emacs asks about the unsafe
variable every time it is started.

When, on the other hand, todo is disabled, marking Local variables in
TeX-Files works as expected.

I have now disabled todo.

Many thanks again, also in advance

R.
- --
Prof. Dr. Rainer Thiel
Altertumswiss., Lehrstuhl Gräzistik
07737 Jena, Germany (EU)
r.thiel@uni-jena.de

- --=-=-=
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug

- --=-=-=--
------- End of forwarded message -------

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [angeli@caeruleus.net: custom-set-variables overwritten  bysafe-local-variables]
  2006-04-28 15:45 [angeli@caeruleus.net: custom-set-variables overwritten by safe-local-variables] Richard Stallman
@ 2006-04-29  5:10 ` Stuart D. Herring
  2006-05-02 20:10   ` Ralf Angeli
  2006-05-02 20:43   ` Chong Yidong
  0 siblings, 2 replies; 6+ messages in thread
From: Stuart D. Herring @ 2006-04-29  5:10 UTC (permalink / raw)
  Cc: Ralf Angeli, emacs-devel

> (todo-show)    ; european-calendar-style und number-of-diary-entries
> ;; 	       ; schon vorher definiert sein
>
>
> (custom-set-variables
>   ;; custom-set-variables was added by Custom.
>   ;; If you edit it by hand, you could mess it up, so be careful.
>   ;; Your init file should contain only one such instance.
>   ;; If there is more than one, they won't work right.
>  '(fill-column 72)
>  )
>
> ; .emacs.el END

Well, here's the problem -- the (todo-show) invokes the local-variables
warning, before the `custom-set-variables' has taken place.  This means
that A) the safe-locals setting hasn't taken place yet, so the warning
will always occur, and B) if the .emacs is modified by Custom (via the
local-variables warning), the fill-column hasn't been set yet and will be
forgotten.

Simple workaround is to put (todo-show) after the `custom-set-variables'. 
Better yet, replace with (add-hook 'after-init-hook 'todo-show); .emacs
isn't really supposed to be doing anything user-visible (like opening
buffers), but it can arrange for it to happen later.

I don't know that there's any way to "fix" this, except maybe to have
Custom put its forms at the top of the .emacs.  But that might cause other
problems...

Hope this helps,
Davis

-- 
This product is sold by volume, not by mass.  If it appears too dense or
too sparse, it is because mass-energy conversion has occurred during
shipping.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [angeli@caeruleus.net: custom-set-variables overwritten bysafe-local-variables]
  2006-04-29  5:10 ` [angeli@caeruleus.net: custom-set-variables overwritten bysafe-local-variables] Stuart D. Herring
@ 2006-05-02 20:10   ` Ralf Angeli
  2006-05-02 20:43   ` Chong Yidong
  1 sibling, 0 replies; 6+ messages in thread
From: Ralf Angeli @ 2006-05-02 20:10 UTC (permalink / raw)
  Cc: rms, emacs-devel

* Stuart D. Herring (2006-04-29) writes:

> Well, here's the problem -- the (todo-show) invokes the local-variables
> warning, before the `custom-set-variables' has taken place.  This means
> that A) the safe-locals setting hasn't taken place yet, so the warning
> will always occur, and B) if the .emacs is modified by Custom (via the
> local-variables warning), the fill-column hasn't been set yet and will be
> forgotten.

Oh, that's ugly.

> Simple workaround is to put (todo-show) after the `custom-set-variables'. 
> Better yet, replace with (add-hook 'after-init-hook 'todo-show); .emacs
> isn't really supposed to be doing anything user-visible (like opening
> buffers), but it can arrange for it to happen later.

Thanks for the info.  I informed the original reporter about it.

> I don't know that there's any way to "fix" this, except maybe to have
> Custom put its forms at the top of the .emacs.  But that might cause other
> problems...

Possibly.  For example the first line in my .emacs file is
(setq debug-on-error t)
and should stay like this. (c:

-- 
Ralf

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [angeli@caeruleus.net: custom-set-variables overwritten bysafe-local-variables]
  2006-04-29  5:10 ` [angeli@caeruleus.net: custom-set-variables overwritten bysafe-local-variables] Stuart D. Herring
  2006-05-02 20:10   ` Ralf Angeli
@ 2006-05-02 20:43   ` Chong Yidong
  2006-05-02 20:58     ` Stuart D. Herring
  1 sibling, 1 reply; 6+ messages in thread
From: Chong Yidong @ 2006-05-02 20:43 UTC (permalink / raw)
  Cc: Ralf Angeli, rms, emacs-devel

> Well, here's the problem -- the (todo-show) invokes the local-variables
> warning, before the `custom-set-variables' has taken place.  This means
> that A) the safe-locals setting hasn't taken place yet, so the warning
> will always occur, and B) if the .emacs is modified by Custom (via the
> local-variables warning), the fill-column hasn't been set yet and will be
> forgotten.
>
> Simple workaround is to put (todo-show) after the `custom-set-variables'. 
> Better yet, replace with (add-hook 'after-init-hook 'todo-show); .emacs
> isn't really supposed to be doing anything user-visible (like opening
> buffers), but it can arrange for it to happen later.

Why not make todo-show do

  (let ((enable-local-variables nil))
    ( ... load the files ...))

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [angeli@caeruleus.net: custom-set-variables overwritten   bysafe-local-variables]
  2006-05-02 20:43   ` Chong Yidong
@ 2006-05-02 20:58     ` Stuart D. Herring
  2006-05-02 23:21       ` Chong Yidong
  0 siblings, 1 reply; 6+ messages in thread
From: Stuart D. Herring @ 2006-05-02 20:58 UTC (permalink / raw)
  Cc: Ralf Angeli, emacs-devel

>> Simple workaround is to put (todo-show) after the
>> `custom-set-variables'.
>> Better yet, replace with (add-hook 'after-init-hook 'todo-show); .emacs
>> isn't really supposed to be doing anything user-visible (like opening
>> buffers), but it can arrange for it to happen later.
>
> Why not make todo-show do
>
>   (let ((enable-local-variables nil))
>     ( ... load the files ...))

But what if don't want to ignore the local variables?  It's not like
Custom will go back and install the safe ones in all open buffers once
`safe-local-variables' is set...

Are we attempting to solve different problems?

Davis

-- 
This product is sold by volume, not by mass.  If it appears too dense or
too sparse, it is because mass-energy conversion has occurred during
shipping.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [angeli@caeruleus.net: custom-set-variables overwritten bysafe-local-variables]
  2006-05-02 20:58     ` Stuart D. Herring
@ 2006-05-02 23:21       ` Chong Yidong
  0 siblings, 0 replies; 6+ messages in thread
From: Chong Yidong @ 2006-05-02 23:21 UTC (permalink / raw)
  Cc: Ralf Angeli, emacs-devel

"Stuart D. Herring" <herring@lanl.gov> writes:

>>> Simple workaround is to put (todo-show) after the
>>> `custom-set-variables'.
>>> Better yet, replace with (add-hook 'after-init-hook 'todo-show); .emacs
>>> isn't really supposed to be doing anything user-visible (like opening
>>> buffers), but it can arrange for it to happen later.
>>
>> Why not make todo-show do
>>
>>   (let ((enable-local-variables nil))
>>     ( ... load the files ...))
>
> But what if don't want to ignore the local variables?  It's not like
> Custom will go back and install the safe ones in all open buffers once
> `safe-local-variables' is set...
>
> Are we attempting to solve different problems?

On second thought, my suggestion is no good.  I guess putting
(todo-show) after `custom-set-variables' is the best bet.  Let's stop
worrying about this.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2006-05-02 23:21 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-04-28 15:45 [angeli@caeruleus.net: custom-set-variables overwritten by safe-local-variables] Richard Stallman
2006-04-29  5:10 ` [angeli@caeruleus.net: custom-set-variables overwritten bysafe-local-variables] Stuart D. Herring
2006-05-02 20:10   ` Ralf Angeli
2006-05-02 20:43   ` Chong Yidong
2006-05-02 20:58     ` Stuart D. Herring
2006-05-02 23:21       ` Chong Yidong

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).