From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "T.V Raman" Newsgroups: gmane.emacs.devel Subject: Re: describe-repeat-maps: Possible print bug: Date: Thu, 29 Sep 2022 07:00:06 -0700 Message-ID: <25397.42214.896756.847083@retriever.mtv.corp.google.com> References: <86bkqz5qp3.fsf@mail.linkov.net> <25396.65413.972637.923513@google.com> <86o7uy4qz9.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3686"; mail-complaints-to="usenet@ciao.gmane.io" Cc: raman@google.com, emacs-devel@gnu.org To: juri@linkov.net Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 29 18:24:18 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1odwKf-0000ow-Tw for ged-emacs-devel@m.gmane-mx.org; Thu, 29 Sep 2022 18:24:17 +0200 Original-Received: from localhost ([::1]:60920 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1odwKe-000386-Pi for ged-emacs-devel@m.gmane-mx.org; Thu, 29 Sep 2022 12:24:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45288) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odu5M-0001wo-0f for emacs-devel@gnu.org; Thu, 29 Sep 2022 10:00:20 -0400 Original-Received: from mail-pg1-x52e.google.com ([2607:f8b0:4864:20::52e]:47011) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1odu5J-0000D3-2G for emacs-devel@gnu.org; Thu, 29 Sep 2022 10:00:19 -0400 Original-Received: by mail-pg1-x52e.google.com with SMTP id 78so1508300pgb.13 for ; Thu, 29 Sep 2022 07:00:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=references:in-reply-to:subject:cc:to:date:message-id :content-transfer-encoding:mime-version:from:from:to:cc:subject:date; bh=OwcztELJFT2n8NKXj5FX+yklxh4fs/aqcQEndTqnDAQ=; b=kwi/Mu/D9xz6be9aRsWM/yQ7K5jDb122S1faj5oII3sFsqXFIvJv52b12+e/BIJe6L qjAWvjiyyn2wWH3lfXS3sX/ClE0rp6SMJrSggu8KmOV2Qebf+AFPJbdIMTgnKOEG+kYr 26YgE4XoS4vX09CsNqbpgVXGbUlSFFOntBXoZv91h373zigyVbzgibQuiwZWCrlob0Vs brQthr7oQXt7RPmnu7finWB0KfAoENW2MeSQXekJt8xvbiHhxidRmzO5kGXU6K9IvEOa W4ZfszXcv5EA96lRE3EfpRbfeIBjp8xdgEhFbn9buWXqz+8g4WsIakHGkVlEJjiViGBw SPvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=references:in-reply-to:subject:cc:to:date:message-id :content-transfer-encoding:mime-version:from:x-gm-message-state:from :to:cc:subject:date; bh=OwcztELJFT2n8NKXj5FX+yklxh4fs/aqcQEndTqnDAQ=; b=p6me1BJeXPvpXowxgDgU8v+cq+nFaxqbNoGFYlVL1whuJf+d9p4x7LhWJvN4ASnRg+ PLrWb9267sMkEw1iykzm2G8q+NvkfjgZwVCdDRM2v7r8PDiPKZ91tthHgnlL8zQ/dcF3 BRjE6dGpEkeZu49lk/bZIs96iPzC3YPUj5NaWIKkqqPdfN9FCNkaIJZySSsW+JJvxekY vR7cTKD7ksv8Mtc7SPO+ZxsTwkiAG2twAGsPgvpctr+KUj93OsFw/QZJyUSK7Zx4te39 kUR2D/T1/Zoj40Zy2WXHKurM4MfTi779cS64LO5Zdh+oZAIYY6JC5/wxbkkAR+3THVCl jf2g== X-Gm-Message-State: ACrzQf11MMqSUWpFjLmhAF7+Y0uWJ+tn3VQHYmPoe+/jhqNlotpleS0S Fz8i5NwwANnHQzR3cCHb1M59Z1fu+Br6iQ== X-Google-Smtp-Source: AMsMyM4lp8Btv5zUI8Z6RnrHbBm3tqP5sASmIaPnetQbhHOGH9BjKD88viCn+vv0YCLkChW/w2LBWQ== X-Received: by 2002:aa7:880f:0:b0:558:12e9:178e with SMTP id c15-20020aa7880f000000b0055812e9178emr3699633pfo.23.1664460014219; Thu, 29 Sep 2022 07:00:14 -0700 (PDT) Original-Received: from retriever.mtv.corp.google.com ([2620:0:1000:1612:8b8c:1f54:1e53:9865]) by smtp.gmail.com with ESMTPSA id x26-20020aa7957a000000b0053e47dcfa32sm6119385pfq.155.2022.09.29.07.00.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Sep 2022 07:00:13 -0700 (PDT) In-Reply-To: <86o7uy4qz9.fsf@mail.linkov.net> X-Mailer: VM 8.1.1 under 29.0.50 (x86_64-pc-linux-gnu) Received-SPF: pass client-ip=2607:f8b0:4864:20::52e; envelope-from=raman@google.com; helo=mail-pg1-x52e.google.com X-Spam_score_int: -216 X-Spam_score: -21.7 X-Spam_bar: --------------------- X-Spam_report: (-21.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, NICE_REPLY_A=-4.099, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:296466 Archived-At: Thanks for looking at my code and chasing it down, much apreciated. Juri Linkov writes: > > Interesting, evaluating your test case shows the expected and desi= red > > output C-; 1 is shown as the key. > > > > But sadly it doesn't work for my code. > > > > My media player module is here: (apologies in advance -- it's a la= rge > > module, but the repeat-mode code is only a few lines. > > > > https://github.com/tvraman/emacspeak/blob/master/lisp/emacspeak-m-= player.el#L1442 >=20 > Thanks, this reference helped to understand that > emacspeak-m-player-bind-accelerator binds only global keys, > not keys in the repeat map. Here is a short test case > that confirms this: >=20 > (repeat-mode 1) > (keymap-set global-map "C-; 1" (defun test-repeat-next-line () (in= teractive) (next-line))) > (defvar-keymap test-repeat-map) > (put 'test-repeat-next-line 'repeat-map 'test-repeat-map) >=20 > And indeed 'describe-repeat-maps' outputs empty "(bound to )". > This is because the keys in the global map used to enter the > repeatable sequence currently are not handled by 'describe-repeat-ma= ps'. > This should be fixed before the next release. >=20 > Also it was suggested to allow specifying the keys that enter > the repeatable sequence and exit it, by an additional keyword > in defvar-keymap, or by adding a new macro defvar-repeat-keymap. > This could be implemented as well. --=20 Thanks, --Raman(I Search, I Find, I Misplace, I Research) =E2=99=89 Id: kg:/m/0285kf1 =F0=9F=A6=AE -- Thanks, --Raman(I Search, I Find, I Misplace, I Research) ♉ Id: kg:/m/0285kf1 🦮