From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: jasonr@btinternet.com Newsgroups: gmane.emacs.devel Subject: Re: NT Emacs crashes when selecting a menubar item Date: Thu, 1 Aug 2002 08:54:12 +0100 (BST) Sender: emacs-devel-admin@gnu.org Message-ID: <2515520.1028188452159.JavaMail.root@127.0.0.1> NNTP-Posting-Host: localhost.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 7bit X-Trace: main.gmane.org 1028188480 17825 127.0.0.1 (1 Aug 2002 07:54:40 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Thu, 1 Aug 2002 07:54:40 +0000 (UTC) Cc: emacs-devel@gnu.org Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.33 #1 (Debian)) id 17aAn8-0004dO-00 for ; Thu, 01 Aug 2002 09:54:38 +0200 Original-Received: from fencepost.gnu.org ([199.232.76.164]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 17aB5j-0007dN-00 for ; Thu, 01 Aug 2002 10:13:51 +0200 Original-Received: from localhost ([127.0.0.1] helo=fencepost.gnu.org) by fencepost.gnu.org with esmtp (Exim 3.35 #1 (Debian)) id 17aAnW-00076F-00; Thu, 01 Aug 2002 03:55:02 -0400 Original-Received: from actinium.btinternet.com ([194.73.73.66]) by fencepost.gnu.org with esmtp (Exim 3.35 #1 (Debian)) id 17aAmj-00071v-00; Thu, 01 Aug 2002 03:54:13 -0400 Original-Received: from mendelevium ([194.75.226.23]) by actinium.btinternet.com with esmtp (Exim 3.22 #8) id 17aAmi-0004n5-00; Thu, 01 Aug 2002 08:54:12 +0100 Original-Received: from 212.2.12.67 by mendelevium ([194.75.226.23]); Thu, 01 Aug 02 08:54:12 BST Original-To: david@dponce.com, rms@gnu.org X-Mailer: talk21.com WAS v2 Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.11 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.emacs.devel:6219 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:6219 Are you able to install this yourself, or can someone else do it for you? I am currently without an internet connection (or phone line even) at home. > from: David Ponce > date: Wed, 31 Jul 2002 23:37:05 > to: rms@gnu.org > cc: emacs-devel@gnu.org > subject: Re: NT Emacs crashes when selecting a menubar item > > Richard Stallman wrote: > > >I figured out how Lisp code was getting called during that loop. > >xmenu.c had the same bug, so I fixed it there. > > > >Now we need a Windows hacker to adapt the same fix to w32menu.c. > >Perhaps macmenu.c needs the same change. > > > >Thanks for figuring this out. > > > > > Hi Richard, > > I adapted your changes from xmenu.c to the version of w32menu.c where > I fixed another bug with popup menu, and generalized use of the macros > AREF, ASET, ASIZE, to access vectors. Attached you will find a new > diff. The change log is at end. > > I currently use this new version and can confirm that you fixed the bug > :-) > > Thank you very much for your support! > David > > ------------ Change Log: > > (local_heap, local_alloc, local_free): New macros. > (malloc_widget_value, free_widget_value) > (w32_free_submenu_strings): Use them. > > (push_submenu_start, push_submenu_end, push_left_right_boundary) > (push_menu_pane, push_menu_item, single_keymap_panes) > (single_menu_item, Fx_popup_menu, menubar_selection_callback) > (single_submenu, set_frame_menubar) > (w32_menu_show, w32_dialog_show): Use AREF, ASET, ASIZE. > > (Fx_popup_menu): Don't show pop up menu until preceding one is > actually cleaned up. Moved UNGCPRO outside #ifdef HAVE_MENUS block. > > Changes adapted from xmenu.c > > (set_frame_menubar): First parse all submenus, > then make widget_value trees from them. > Don't allocate any widget_value objects > until we are done with the parsing. > (parse_single_submenu): New function. > (digest_single_submenu): New function. > (single_submenu): Function deleted, replaced by those two. >