From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "T.V Raman" Newsgroups: gmane.emacs.devel Subject: Re: Please fix source of unfixable docstring length warnings Date: Sun, 9 Jan 2022 06:50:22 -0800 Message-ID: <25050.63022.295691.739844@retriever.mtv.corp.google.com> References: <25050.19976.741797.448258@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33271"; mail-complaints-to="usenet@ciao.gmane.io" Cc: raman@google.com, emacs-devel@gnu.org To: stefankangas@gmail.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jan 09 15:51:34 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n6ZXh-0008SM-TS for ged-emacs-devel@m.gmane-mx.org; Sun, 09 Jan 2022 15:51:33 +0100 Original-Received: from localhost ([::1]:46258 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n6ZXg-00080p-Mk for ged-emacs-devel@m.gmane-mx.org; Sun, 09 Jan 2022 09:51:32 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:38862) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n6ZWi-0007Dr-93 for emacs-devel@gnu.org; Sun, 09 Jan 2022 09:50:32 -0500 Original-Received: from [2607:f8b0:4864:20::630] (port=39593 helo=mail-pl1-x630.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n6ZWg-0003dl-Gj for emacs-devel@gnu.org; Sun, 09 Jan 2022 09:50:31 -0500 Original-Received: by mail-pl1-x630.google.com with SMTP id l8so7751515plt.6 for ; Sun, 09 Jan 2022 06:50:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=from:mime-version:content-transfer-encoding:message-id:date:to:cc :subject:in-reply-to:references; bh=pjvXXzv9E+PVxnVUAycRh/Xs7v8rkM4V0SIJvsT3e00=; b=ltzyz8CqlXNtvJUDudrTAcmzp+ObG15rd7Qg0dB8Ctb18D2GNE06eOvL7L3G7+A0Kq cl6hoIXlk4fM2b8s4P8IGqScQoHKVA8e9LpykAnpEIvbLsy7avZeriht1wb+7kUsXPKn TdLaLW42RKC2nPE/XCINj7ph7dfgdvPgxpUvf+6UljI2QeVz54s0udBShP8BFErU40A0 meNY8BoROJhnAda1hDTb3d8QI5hrYoVqu0w51K/xUNctIjvErY6qm9qqVJncrofBySxe CHX2KwvDwkcmYcN0ywT1lJ1MWGh0gY7mfYwe3t4MMgOcj2hYyIPrqur1yztgEiRtnpnA nj+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:mime-version:content-transfer-encoding :message-id:date:to:cc:subject:in-reply-to:references; bh=pjvXXzv9E+PVxnVUAycRh/Xs7v8rkM4V0SIJvsT3e00=; b=1s0VwDQME7u+OI/WHHLaImp2VJ54wx+5SYX9ep3yho2Cg2Ao+Zp+cuoUXvKx/NOpRK vktGU53OE+Yi4oXqwZc7+1C5RCyg3Cz+1kkFwl2wY+bRqY3Ppi99eng5mqzBiYsBE7s4 VMXs6DvGMP8QQkQwKT54xp1kP/TCOteZqE9Ryb5CFzOGHLOZ4+EysuawDyxyqRc3b2w4 z08h63dYkriPSPmwk5Zh6A6hhDDBdIQrAyTAki2iv/psn7I3BzPHD3nxP9U2gn+upkhi N8OBJlwR2xMws4e4yzuuYhpZG289/NKXM7yGKHl6iWBlXd5oMu5G8JLKQ3VFlyIzA1HH IMDw== X-Gm-Message-State: AOAM5327rUfUX0zHsQrdwvNkThmd6+2V3PcOh8nPYShOD/EGbSsZiIyc u6aDmPXmtDlME+67k8kx7gmHiJ18HmHgfw== X-Google-Smtp-Source: ABdhPJwBkuc3+yfc2aCesXV++cdfUnAATRNSXfAzwntPE041R4GLIQfaYCjs060oPi9P0jxjYogmUg== X-Received: by 2002:a17:903:2486:b0:149:2de5:96d6 with SMTP id p6-20020a170903248600b001492de596d6mr72591956plw.54.1641739828392; Sun, 09 Jan 2022 06:50:28 -0800 (PST) Original-Received: from retriever.mtv.corp.google.com ([2620:0:1000:1510:2909:b109:d302:83e1]) by smtp.gmail.com with ESMTPSA id b11sm3182586pge.84.2022.01.09.06.50.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Jan 2022 06:50:27 -0800 (PST) In-Reply-To: X-Mailer: VM 8.1.1 under 29.0.50 (x86_64-pc-linux-gnu) X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::630 (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::630; envelope-from=raman@google.com; helo=mail-pl1-x630.google.com X-Spam_score_int: -167 X-Spam_score: -16.8 X-Spam_bar: ---------------- X-Spam_report: (-16.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:284502 Archived-At: I am running emacs built against the latest HEAD, and the error message in my email was from last evening, so I guess it's not entirely fixed. Stefan Kangas writes: > "T.V Raman" writes: >=20 > > As an example, > > emacspeak-table-ui.el:57:45: Warning: docstring wider than 80 > > characters > > reported on > > https://github.com/tvraman/emacspeak/blob/master/lisp/emacspeak-ta= ble-ui.el#start-of-content > > > > These warnings are unfixable since the source code doesn't actuall= y > > have the problem reported, it appears to happen for things like ca= lls > > to define-derived-mode and similar things and the noise from these= > > spurious warnings means that real warnings will get ignored over t= ime. >=20 > I can't reproduce this, as the below patch makes the warning go away= > here: >=20 > --------------------------------------------------------------------= -- >=20 > Does that patch fix the problem for you too=3F >=20 > I've fixed several warnings for overly long docstrings in automatica= lly > generated strings. If any remain, I would definitely like to find t= hem > and fix them, so I appreciate your help in getting to the root of th= is. > Thanks. >=20 > BTW, if you find these warnings too much of a hassle, you could cons= ider > disabling them with a directory local variable; I believe you would = need > to set `byte-compile-warnings' to e.g. `(not docstrings)'. >=20 > --------------------------------------------------------------------= -- > diff --git a/lisp/emacspeak-table-ui.el b/lisp/emacspeak-table-ui.el= > index 2c1465e0f..0b60769fa 100644 > --- a/lisp/emacspeak-table-ui.el > +++ b/lisp/emacspeak-table-ui.el > @@ -85,7 +85,8 @@ T emacspeak-table-goto-top > =20 > The next two commands let you search the table. > The commands ask you if you want to search rows or columns. > -When searching headers remember that row 0 is the column header, an= d that column 0 is the row header. > +When searching headers remember that row 0 is the column header, > +and that column 0 is the row header. > =20 > h emacspeak-table-search-headers > s emacspeak-table-search --=20 Thanks, --Raman(I Search, I Find, I Misplace, I Research) =E2=99=89 Id: kg:/m/0285kf1 =F0=9F=A6=AE -- Thanks, --Raman(I Search, I Find, I Misplace, I Research) ♉ Id: kg:/m/0285kf1 🦮